Wladimir J. van der Laan 9ae468a6d5 Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc ...

faeb666536 util: Add CHECK_NONFATAL and use it in src/rpc (MarcoFalke)

Pull request description:

  Fixes #17181

  Currently, we use `assert` in RPC code to document logic and code assumptions. However, it seems a bit extreme to abort all of Bitcoin Core on an assert failure in one of the RPC threads. I suggest to replace all `assert`s with a macro `CHECK_NONFATAL(condition)` that throws a runtime error when the condition evaluates to `false`. That runtime error will then be returned to the rpc caller and will include instructions to report the error to our issue tracker.

ACKs for top commit:
  practicalswift:
    ACK faeb666536
  laanwj:
    ACK faeb666536
  ryanofsky:
    Code review ACK faeb666536

Tree-SHA512: 9b748715a5e0767ac11f1324a95a3a6ec672a0e0658013492219223bda83ce4b1b447fd8183bbb235f7df5ef7dddda7666ad569544b4d61cc65f232ca7a800ec

2019-10-28 12:00:36 +01:00

..

bip32.cpp

…

bip32.h

…

bytevectorhash.cpp

…

bytevectorhash.h

…

check.h

util: Add CHECK_NONFATAL and use it in src/rpc

2019-10-18 17:19:36 -04:00

error.cpp

util: Make util/error bilingual_str (refactor)

2019-08-28 15:52:26 -04:00

error.h

util: Make util/error bilingual_str (refactor)

2019-08-28 15:52:26 -04:00

fees.cpp

[wallet] abort when attempting to fund a transaction above maxtxfee

2019-06-28 22:44:38 -04:00

fees.h

…

macros.h

refactor: consolidate PASTE macros

2019-09-25 10:56:00 -04:00

memory.h

…

moneystr.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

moneystr.h

Remove unused includes

2019-10-15 22:56:43 +00:00

rbf.cpp

…

rbf.h

…

spanparsing.cpp

Abstract out some of the descriptor Span-parsing helpers

2019-09-18 12:12:13 -07:00

spanparsing.h

Add documenting comments to spanparsing.h

2019-09-18 12:25:55 -07:00

strencodings.cpp

util: refactor upper/lowercase functions

2019-08-08 11:35:14 +09:00

strencodings.h

util: refactor upper/lowercase functions

2019-08-08 11:35:14 +09:00

string.cpp

util: Add Join helper to join a list of strings

2019-08-20 16:51:41 -04:00

string.h

Remove unused includes

2019-10-15 22:56:43 +00:00

system.cpp

util: Filter out macOS process serial number

2019-10-18 09:12:15 +03:00

system.h

Merge #15864: Fix datadir handling

2019-08-19 10:01:30 -04:00

threadnames.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

threadnames.h

Don't rename main thread at process level

2019-10-03 06:58:47 +02:00

time.cpp

util: Add type safe GetTime

2019-05-23 14:12:32 -04:00

time.h

util: Add count_seconds time helper

2019-09-19 11:30:29 -04:00

translation.h

Remove unused includes

2019-10-15 22:56:43 +00:00

url.cpp

…

url.h

…

validation.cpp

[logging] Don't log REJECT code when transaction is rejected

2019-10-10 11:19:42 -04:00

validation.h

…

vector.h

Add some general std::vector utility functions

2019-10-16 08:56:57 -07:00