highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-13 17:15:11 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
1c4f59728c35dc61c213932ffa593826db10095a
bitcoin/src
History
fanquake 1c4f59728c Merge #19879: [p2p] miscellaneous wtxid followups 
a8a64acaf3 [BroadcastTransaction] Remove unsafe move operator (Amiti Uttarwar)
125c038126 [p2p] Remove dead code (Amiti Uttarwar)
fc66d0a65c [p2p] Check for nullptr before dereferencing pointer (Adam Jonas)
cb79b9dbf4 [mempool] Revert unbroadcast set to tracking just txid (Amiti Uttarwar)

Pull request description:

  Addresses some outstanding review comments from #18044

  - reverts unbroadcast txids to a set instead of a map (simpler, communicates intent better, takes less space, no efficiency advantages of map)
  - adds safety around two touchpoints (check for nullptr before dereferencing pointer, remove an inaccurate std::move operator)
  - removes some dead code

  Links to comments on wtxid PR: [1](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r460495254) [2](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r460496023) [3](https://github.com/bitcoin/bitcoin/pull/18044#discussion_r463532611)

  thanks to jnewbery & adamjonas for flagging these ! !

ACKs for top commit:
  sdaftuar:
    utACK a8a64acaf3
  naumenkogs:
    utACK a8a64acaf3
  jnewbery:
    utACK a8a64acaf3

Tree-SHA512: 7be669cb30cc17fb9e06b50e636ef7887c6a27354697987e4e4d38dba4b8f50e175647587430cd9bc3295bec01ce8b1e6639a50a4249d8fff9b1ca1b9ead3277
2020-09-16 06:30:57 +08:00
..
bench
Add SHA3 benchmark
2020-09-06 18:35:23 -07:00
compat
…
config
…
consensus
Add txids with non-standard inputs to reject filter
2020-08-04 13:29:40 -04:00
crc32c
…
crypto
Merge #19931: Change CSipHasher's count variable to uint8_t
2020-09-14 16:30:17 +08:00
index
Merge #19733: Move comment about BaseIndex::DB from TxIndex::DB
2020-08-21 12:48:46 +08:00
interfaces
Merge #19619: Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp
2020-09-07 11:45:36 +12:00
leveldb
…
logging
…
node
Merge #19879: [p2p] miscellaneous wtxid followups
2020-09-16 06:30:57 +08:00
policy
doc: Add doxygen comment to IsRBFOptIn
2020-09-05 11:45:16 +02:00
primitives
refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic
2020-07-30 13:44:54 -07:00
qt
Merge #19754: wallet, gui: Reload previously loaded wallets on startup
2020-09-03 18:24:32 +02:00
rpc
[rpc] add send method
2020-09-10 13:44:53 +02:00
script
Merge #19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 (Alternative to #18071)
2020-08-25 20:18:40 +08:00
secp256k1
Update src/secp256k1 subtree to upstream libsecp256k1
2020-09-11 12:44:08 -07:00
support
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
test
Merge #19841: Implement Keccak and SHA3_256
2020-09-10 16:37:21 +02:00
univalue
…
util
Merge #19803: Bugfix: Define and use HAVE_FDATASYNC correctly outside LevelDB
2020-08-31 13:07:24 +08:00
wallet
Merge #16378: The ultimate send RPC
2020-09-15 14:49:08 +12:00
zmq
Merge #14687: zmq: enable tcp keepalive
2020-09-02 09:09:18 +02:00
.clang-format
…
addrdb.cpp
…
addrdb.h
…
addrman.cpp
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
addrman.h
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
base58.h
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #19643: Add -netinfo peer connections dashboard
2020-09-15 15:01:50 +08:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Replace usage of GetScriptForWitness with GetScriptForDestination
2020-08-14 08:44:42 +12:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
refactor: Create interfaces earlier during initialization
2020-08-27 14:33:00 -04:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
Make CHash256/CHash160 output to Span
2020-07-30 13:57:54 -07:00
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
chain: Remove UB CChain comparison
2020-08-27 20:07:27 -04:00
chainparams.cpp
Merge #19316: [net] Cleanup logic around connection types
2020-08-12 10:01:44 +08:00
chainparams.h
help: Generate checkpoint height from chainparams
2020-08-20 18:20:27 +00:00
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compat.h
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
refactor: Avoid duplicate map lookup in ScriptToAsmStr
2020-09-04 10:25:44 +01:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
dummywallet.cpp
Merge #19671: wallet: Remove -zapwallettxes
2020-09-01 09:26:28 +08:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
Add SHA256Uint256 helper functions
2020-08-06 16:28:26 -07:00
hash.h
Add SHA256Uint256 helper functions
2020-08-06 16:28:26 -07:00
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
indirectmap.h
…
init.cpp
Merge #19241: help: Generate checkpoint height from chainparams
2020-09-15 15:46:08 +02:00
init.h
refactor: Create interfaces earlier during initialization
2020-08-27 14:33:00 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
tests: Add fuzzing harness for ec_seckey_import_der(...) and ec_seckey_export_der(...)
2020-08-18 18:03:57 +00:00
key.h
…
limitedmap.h
…
logging.cpp
…
logging.h
…
Makefile.am
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
Makefile.bench.include
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
Makefile.qttest.include
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
memusage.h
…
merkleblock.cpp
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
merkleblock.h
…
miner.cpp
…
miner.h
Remove mapLinks in favor of entry inlined structs with iterator type erasure
2020-09-04 09:46:44 -07:00
net_permissions.cpp
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_permissions.h
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_processing.cpp
Merge #19879: [p2p] miscellaneous wtxid followups
2020-09-16 06:30:57 +08:00
net_processing.h
Do not pass chain params to CheckForStaleTipAndEvictPeers twice
2020-09-08 07:55:11 +02:00
net_types.h
…
net.cpp
Merge #19670: Protect localhost and block-relay-only peers from eviction
2020-09-03 17:20:47 +02:00
net.h
[doc] Follow developer notes, add comment about missing default.
2020-09-02 17:18:22 -07:00
netaddress.cpp
Merge #19797: net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes
2020-08-28 17:51:37 +02:00
netaddress.h
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.cpp
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
optional.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: remove unused header <arpa/inet.h> in protocol.cpp
2020-09-06 02:29:30 +02:00
protocol.h
Merge #19818: p2p: change CInv::type from int to uint32_t, fix UBSan warning
2020-09-03 17:23:52 +02:00
psbt.cpp
…
psbt.h
…
pubkey.cpp
tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...)
2020-08-18 18:03:56 +00:00
pubkey.h
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
Remove mempool global
2020-09-05 16:24:56 +02:00
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
…
shutdown.h
…
span.h
Add MakeUCharSpan, to help constructing Span<[const] unsigned char>
2020-07-30 13:57:09 -07:00
streams.h
…
sync.cpp
sync.h: Make runtime lock checks require compile-time lock checks
2020-08-29 20:46:47 +03:00
sync.h
sync.h: Make runtime lock checks require compile-time lock checks
2020-08-29 20:46:47 +03:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations
2020-08-18 10:46:53 +03:00
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
Replace hidden service with onion service
2020-08-07 14:55:02 +02:00
torcontrol.h
…
txdb.cpp
…
txdb.h
…
txmempool.cpp
Get rid of unused functions CTxMemPool::GetMemPoolChildren, CTxMemPool::GetMemPoolParents
2020-09-04 09:46:44 -07:00
txmempool.h
Merge #19879: [p2p] miscellaneous wtxid followups
2020-09-16 06:30:57 +08:00
uint256.cpp
refactor: Make HexStr take a span
2020-08-06 19:41:43 +02:00
uint256.h
Make uint256 Span-convertible by adding ::data()
2020-07-30 13:57:09 -07:00
undo.h
…
validation.cpp
Merge #19879: [p2p] miscellaneous wtxid followups
2020-09-16 06:30:57 +08:00
validation.h
Remove mempool global
2020-09-05 16:24:56 +02:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…