highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-27 09:40:51 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
1f352cf2fd7c616480e403ecebb52597e61dbfb1
bitcoin/src
History
fanquake a7f4f1a09c Merge bitcoin/bitcoin#28894: wallet: batch all individual spkms setup db writes in a single db txn 
f053024273 wallet: batch external signer descriptor import (Sjors Provoost)
1f65241b73 wallet: descriptors setup, batch db operations (furszy)
3eb769f150 wallet: batch legacy spkm TopUp (furszy)
075aa44ceb wallet: batch descriptor spkm TopUp (furszy)
bb4554c81e bench: add benchmark for wallet creation procedure (furszy)

Pull request description:

  Work decoupled from #28574.

  Instead of performing multiple single write operations per spkm
  setup call, this PR batches them all within a single atomic db txn.

  Speeding up the process and preventing the wallet from entering
  an inconsistent state if any of the intermediate transactions fail
  (which shouldn't happen but.. if it does, it is better to not store
  any spkm rather than storing them partially).

  To compare the changes, added benchmark in the first commit.

ACKs for top commit:
  Sjors:
    re-utACK f053024273
  achow101:
    ACK f053024273
  BrandonOdiwuor:
    ACK f053024273
  theStack:
    Code-review ACK f053024273

Tree-SHA512: aead8548473e17d4d53e8e7039bbaf5e8bf2fe83f33b33f81cdedefe8a31b7003ceb6d5379b1bad1ca2692e909492009a21284ec8338eede078df3d19046ab5a
2023-12-08 11:25:01 +00:00
..
bench
Merge bitcoin/bitcoin#28894: wallet: batch all individual spkms setup db writes in a single db txn
2023-12-08 11:25:01 +00:00
common
Merge bitcoin/bitcoin#28486: test, bench: Initialize and terminate use of Winsock properly
2023-11-29 17:14:34 +00:00
compat
Remove __cplusplus from compat/assumptions.h
2023-10-04 11:11:37 +02:00
config
…
consensus
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
crc32c
…
crypto
Add ability to specify SHA256 implementation for benchmark purposes
2023-09-20 21:11:55 +01:00
index
blockstorage: switch from CAutoFile to AutoFile
2023-11-18 03:01:03 +10:00
init
init: remove config option names from translated -loglevel strings
2023-06-15 10:27:56 -06:00
interfaces
Use ParamsWrapper for witness serialization
2023-11-14 08:45:30 +10:00
ipc
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
kernel
Merge bitcoin/bitcoin#28368: Fee Estimator updates from Validation Interface/CScheduler thread
2023-12-01 15:07:23 -05:00
leveldb
…
logging
Use steady clock for logging timer
2023-01-31 18:48:50 +01:00
minisketch
…
node
Merge bitcoin/bitcoin#28368: Fee Estimator updates from Validation Interface/CScheduler thread
2023-12-01 15:07:23 -05:00
policy
tx fees, policy: CBlockPolicyEstimator update from CValidationInterface notifications
2023-11-22 11:48:21 +01:00
primitives
Merge bitcoin/bitcoin#28766: Improve peformance of CTransaction::HasWitness (28107 follow-up)
2023-11-28 08:44:41 -05:00
qt
Merge bitcoin/bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2)
2023-11-30 14:28:46 -05:00
rpc
rpc: fix getrawtransaction segfault
2023-12-05 13:11:02 -05:00
script
Fix IWYU for the script_flags fuzz target
2023-11-23 17:57:53 +01:00
secp256k1
Update secp256k1 subtree to upstream release 0.4.0
2023-09-04 12:51:20 -04:00
support
pool: make sure PoolAllocator uses the correct alignment
2023-11-19 18:43:29 +01:00
test
Merge bitcoin/bitcoin#28924: refactor: Remove unused and fragile string interface from arith_uint256
2023-12-07 16:02:05 +00:00
univalue
Remove unused raw-pointer read helper from univalue
2023-07-27 14:24:52 +02:00
util
Merge bitcoin/bitcoin#28933: fuzz: Faster wallet_notifications target
2023-11-27 17:35:45 +00:00
wallet
Merge bitcoin/bitcoin#28894: wallet: batch all individual spkms setup db writes in a single db txn
2023-12-08 11:25:01 +00:00
zmq
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
.bear-tidy-config
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
.clang-format
…
.clang-tidy
refactor: Fix bugprone-string-constructor warning
2023-10-30 14:59:17 +01:00
addrdb.cpp
build: Bump minimum supported Clang to clang-13
2023-10-24 18:52:00 +02:00
addrdb.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addresstype.cpp
Add PubKeyDestination for P2PK scripts
2023-09-12 12:14:31 -04:00
addresstype.h
bugfix: Mark CNoDestination and PubKeyDestination constructor explicit
2023-10-25 22:46:55 +02:00
addrman_impl.h
net: Optionally include terrible addresses in GetAddr results
2023-10-04 18:08:49 +02:00
addrman.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
addrman.h
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
arith_uint256.cpp
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
arith_uint256.h
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
attributes.h
Introduce platform-agnostic ALWAYS_INLINE macro
2023-05-04 20:57:51 +01:00
banman.cpp
Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it
2023-11-02 14:09:27 -04:00
banman.h
Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it
2023-11-02 14:09:27 -04:00
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bip324.h
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bitcoin-chainstate.cpp
Merge bitcoin/bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2)
2023-11-30 14:28:46 -05:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Use Txid in COutpoint
2023-11-21 13:15:44 +00:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
blockencodings.cpp
serialize: Drop useless version param from GetSerializeSize()
2023-11-16 11:14:13 +10:00
blockencodings.h
Use ParamsWrapper for witness serialization
2023-11-14 08:45:30 +10:00
blockfilter.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
blockfilter.h
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
chain.cpp
…
chain.h
refactor: Remove CBlockFileInfo::SetNull
2023-10-20 16:29:02 +02:00
chainparams.cpp
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparams.h
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparamsbase.cpp
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsbase.h
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsseeds.h
p2p: update hardcoded mainnet seeds for 25.x
2023-04-20 06:08:22 -07:00
checkqueue.h
refactor: Make CCheckQueue non-copyable and non-movable explicitly
2023-10-03 10:52:17 +01:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
Use Txid in COutpoint
2023-11-21 13:15:44 +00:00
coins.h
Merge bitcoin/bitcoin#28922: Use Txid in COutpoint
2023-11-24 14:41:58 +00:00
compressor.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
compressor.h
…
core_io.h
Use ParamsWrapper for witness serialization
2023-11-14 08:45:30 +10:00
core_memusage.h
…
core_read.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
core_write.cpp
Use ParamsWrapper for witness serialization
2023-11-14 08:45:30 +10:00
cuckoocache.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
dbwrapper.cpp
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
dbwrapper.h
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
deploymentinfo.cpp
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentinfo.h
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
external_signer.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
external_signer.h
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
flatfile.cpp
refactor: Extract util/fs_helpers from util/system
2023-03-23 12:52:00 +01:00
flatfile.h
Merge bitcoin/bitcoin#27254: refactor: Extract util/fs from util/system
2023-04-03 14:41:22 +01:00
hash.cpp
…
hash.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
headerssync.cpp
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
headerssync.h
…
httprpc.cpp
refactor: drop protocol.h include header in rpc/util.h
2023-09-19 15:54:17 -06:00
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet
2023-10-26 14:29:47 -04:00
httpserver.h
…
i2p.cpp
Merge bitcoin/bitcoin#28695: net: Sanity check private keys received from SAM proxy
2023-10-30 14:44:40 +01:00
i2p.h
i2p: destroy the session if we get an unexpected error from the I2P router
2023-10-05 14:11:13 +02:00
indirectmap.h
…
init.cpp
init: don't delete PID file if it was not generated
2023-12-04 12:54:20 +00:00
init.h
refactor: index, decouple 'Init' from 'Start'
2023-07-10 10:47:17 -03:00
key_io.cpp
Merge bitcoin/bitcoin#28246: wallet: Use CTxDestination in CRecipient instead of just scriptPubKey
2023-09-19 16:48:43 +00:00
key_io.h
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
key.cpp
key: don't allocate secure mem for null (invalid) key
2023-09-27 15:05:26 -04:00
key.h
key: don't allocate secure mem for null (invalid) key
2023-09-27 15:05:26 -04:00
logging.cpp
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
logging.h
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
Makefile.am
Merge bitcoin/bitcoin#28368: Fee Estimator updates from Validation Interface/CScheduler thread
2023-12-01 15:07:23 -05:00
Makefile.bench.include
bench: add benchmark for wallet creation procedure
2023-11-16 11:27:17 -03:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
qt: Translation updates from Transifex
2023-09-01 07:39:00 +01:00
Makefile.qt.include
Merge bitcoin/bitcoin#22764: build: Include qt sources for parsing with extract_strings.py
2023-10-19 13:25:49 +01:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
fuzz: move MockedDescriptorConverter to fuzz/util
2023-11-20 15:57:50 -03:00
Makefile.test_util.include
Merge bitcoin/bitcoin#27425: test: move remaining rand code from util/setup_common to util/random
2023-07-19 10:26:11 +01:00
Makefile.test.include
fuzz: add target for DescriptorScriptPubKeyMan
2023-11-20 15:57:56 -03:00
Makefile.univalue.include
…
mapport.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
mapport.h
Remove configure-time setting of DEFAULT_UPNP
2023-01-28 15:24:13 +00:00
memusage.h
add std::list to memusage
2023-09-13 11:37:45 +01:00
merkleblock.cpp
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
merkleblock.h
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
net_permissions.cpp
Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet
2023-10-26 14:29:47 -04:00
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#28579: refactor: Remove redundant checks in compat/assumptions.h
2023-11-28 16:51:28 -05:00
net_processing.h
refactor: P2P transport without serialize version and type
2023-11-23 13:43:39 +01:00
net_types.cpp
p2p: return CSubNet in LookupSubNet
2023-05-30 16:27:21 -03:00
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
net.h
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netaddress.cpp
Inline short, often-called, rarely-changed basic CNetAddr getters
2023-07-19 12:43:05 -06:00
netaddress.h
net: put CJDNS prefix byte in a constant
2023-10-05 15:10:32 +02:00
netbase.cpp
Merge bitcoin/bitcoin#28649: Do the SOCKS5 handshake reliably
2023-11-07 14:11:58 -05:00
netbase.h
Merge bitcoin/bitcoin#28649: Do the SOCKS5 handshake reliably
2023-11-07 14:11:58 -05:00
netgroup.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netgroup.h
net: Add continuous ASMap health check logging
2023-12-02 22:03:08 +01:00
netmessagemaker.h
refactor: NetMsg::Make() without nVersion
2023-11-20 14:02:27 +01:00
noui.cpp
…
noui.h
…
outputtype.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
outputtype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
pow.cpp
…
pow.h
…
prevector.h
util: implement prevector's move ctor & move assignment
2023-03-26 15:49:52 +02:00
protocol.cpp
refactor: Initialize magic bytes in constructor initializer
2023-11-13 14:17:59 +01:00
protocol.h
scripted-diff: Use ser params operator
2023-10-13 10:30:49 +02:00
psbt.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
psbt.h
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
pubkey.cpp
pubkey: introduce a GetEvenCorrespondingCPubKey helper
2023-10-08 02:43:19 +02:00
pubkey.h
pubkey: introduce a GetEvenCorrespondingCPubKey helper
2023-10-08 02:43:19 +02:00
random.cpp
Merge bitcoin/bitcoin#26839: Add support for RNDR/RNDRRS for AArch64 on Linux
2023-11-07 15:00:38 -05:00
random.h
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
randomenv.cpp
[refactor] Remove compat.h from kernel headers
2023-09-12 22:51:48 +02:00
randomenv.h
…
rest.cpp
Use Txid in COutpoint
2023-11-21 13:15:44 +00:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
scheduler.h
…
serialize.h
Remove unused SER_NETWORK, SER_DISK
2023-11-30 11:28:17 +01:00
shutdown.cpp
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
shutdown.h
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
signet.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
signet.h
…
span.h
span: Make Span template deduction guides work in SFINAE context
2023-10-20 10:30:16 -04:00
streams.cpp
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
streams.h
Remove unused CDataStream
2023-11-30 11:27:54 +01:00
sync.cpp
sync: unpublish LocksHeld() which is used only in sync.cpp
2023-02-17 11:42:41 +01:00
sync.h
Merge bitcoin/bitcoin#27116: doc: clarify that LOCK() internally checks whether the mutex is held
2023-10-26 15:02:13 -04:00
threadsafety.h
…
timedata.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
timedata.h
…
tinyformat.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
torcontrol.cpp
doc: fix typos
2023-11-07 10:21:51 +09:00
torcontrol.h
doc, refactor: Changing -torcontrol help to specify that a default port is used
2023-08-17 23:58:47 -05:00
txdb.cpp
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
txdb.h
move-only: Move CBlockTreeDB to node/blockstorage
2023-08-01 15:27:33 +02:00
txmempool.cpp
Merge bitcoin/bitcoin#28368: Fee Estimator updates from Validation Interface/CScheduler thread
2023-12-01 15:07:23 -05:00
txmempool.h
tx fees, policy: CBlockPolicyEstimator update from CValidationInterface notifications
2023-11-22 11:48:21 +01:00
txorphanage.cpp
Use type-safe txid types in orphanage
2023-10-12 11:56:37 +01:00
txorphanage.h
Use type-safe txid types in orphanage
2023-10-12 11:56:37 +01:00
txrequest.cpp
refactor: Remove unused gcc-9 workaround in txrequest
2023-10-30 15:18:40 +01:00
txrequest.h
…
uint256.cpp
…
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
validation.cpp
Merge bitcoin/bitcoin#28368: Fee Estimator updates from Validation Interface/CScheduler thread
2023-12-01 15:07:23 -05:00
validation.h
Merge bitcoin/bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2)
2023-11-30 14:28:46 -05:00
validationinterface.cpp
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
validationinterface.h
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
warnings.h
…