MarcoFalke 1b313cacc9 Merge #19927: validation: Reduce direct g_chainman usage ...

72a1d5c6f3 validation: Remove review-only comments + assertions (Carl Dong)
3756853b15 docs: Move FindFilesToPrune{,Manual} doxygen comment (Carl Dong)
485899a93c style: Make FindFilesToPrune{,Manual} match style guide (Carl Dong)
3f5b5f3f6d validation: Move FindFilesToPrune{,Manual} to BlockManager (Carl Dong)
f8d4975ab3 validation: Move PruneOneBlockFile to BlockManager (Carl Dong)
74f73c783d validation: Pass in chainman to UnloadBlockIndex (Carl Dong)
4668ded6d6 validation: Move ~CMainCleanup logic to ~BlockManager (Carl Dong)

Pull request description:

  This PR paves the way for de-globalizing `g_chainman` entirely by removing the usage of `g_chainman` in the following functions/methods:
  - `~CMainCleanup`
  - `CChainState::FlushStateToDisk`
  - `UnloadBlockIndex`

  The remaining direct uses of `g_chainman` are as follows:
  1. In initialization codepaths:
  	- `AppTests`
  	- `AppInitMain`
  	- `TestingSetup::TestingSetup`
  2. `::ChainstateActive`
  3. `LookupBlockIndex`
  	- Note: `LookupBlockIndex` is used extensively throughout the codebase and require a much larger set of changes, therefore I've left it out of this initial PR

ACKs for top commit:
  MarcoFalke:
    re-ACK 72a1d5c6f3 👚
  jnewbery:
    utACK 72a1d5c6f3

Tree-SHA512: 944a4fa8405eecf39706ff944375d6824373aaeea849d11473f08181eff26b12f70043a8348a5b08e6e9021b243b481842fbdfbc7c3140ca795fce3688b7f5c3

2020-09-23 20:35:54 +02:00

..

coinselector_tests.cpp

Remove WalletLocation class

2020-09-03 12:24:32 -04:00

db_tests.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

init_test_fixture.cpp

Do not create default wallet

2020-09-08 21:02:53 -04:00

init_test_fixture.h

refactor: Move wallet methods out of chain.h and node.h

2020-08-27 14:33:00 -04:00

init_tests.cpp

refactor: Move wallet methods out of chain.h and node.h

2020-08-27 14:33:00 -04:00

ismine_tests.cpp

Remove WalletLocation class

2020-09-03 12:24:32 -04:00

psbt_wallet_tests.cpp

psbt: always put a non_witness_utxo and don't remove it

2020-06-24 16:32:19 -04:00

scriptpubkeyman_tests.cpp

Remove WalletLocation class

2020-09-03 12:24:32 -04:00

wallet_crypto_tests.cpp

refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o)

2020-06-24 18:41:45 +02:00

wallet_test_fixture.cpp

Remove WalletLocation class

2020-09-03 12:24:32 -04:00

wallet_test_fixture.h

Do not create default wallet

2020-09-08 21:02:53 -04:00

wallet_tests.cpp

validation: Move PruneOneBlockFile to BlockManager

2020-09-15 14:13:44 -04:00