fanquake 205877e55f Merge bitcoin/bitcoin#23546: scripted-diff: Use clang-tidy syntax for C++ named arguments (tests only) ...

fa00447442 scripted-diff: Use clang-tidy syntax for C++ named arguments (MarcoFalke)
fae13c3989 doc: Use clang-tidy comments in crypto_tests (MarcoFalke)

Pull request description:

  Incorrect named args are source of bugs, like #22979.

  To allow them being checked by `clang-tidy`, use a format it can understand.

ACKs for top commit:
  shaavan:
    ACK fa00447442
  rajarshimaitra:
    ACK fa00447442
  jonatack:
    ACK fa00447442
  fanquake:
    ACK fa00447442

Tree-SHA512: 4d23a8363da81dfea21a4cd8516ab5e0dc70119e4d503f3f240f38573218b2c2e84083b97e956c62942d78b2f17490f8b3b2e8077d257644fda1d901e2b80507

2021-12-01 18:44:54 +08:00

..

rpc

wallet: Split signmessage from rpcwallet

2021-11-26 14:50:49 +01:00

test

Merge bitcoin/bitcoin#23546: scripted-diff: Use clang-tidy syntax for C++ named arguments (tests only)

2021-12-01 18:44:54 +08:00

bdb.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

bdb.h

wallet: Fixed Grammatical error in bdb.h

2021-11-09 12:41:37 +01:00

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

External input fund support cleanups

2021-10-06 06:55:34 +08:00

coinselection.cpp

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

coinselection.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Call load handlers without cs_wallet locked

2021-11-22 09:42:36 +00:00

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

db.cpp

refactor: get wallet path relative to wallet_dir

2021-10-29 09:36:32 -05:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

dump.h

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

external_signer_scriptpubkeyman.cpp

psbt: sign without finalizing

2021-09-28 19:13:42 -04:00

external_signer_scriptpubkeyman.h

psbt: sign without finalizing

2021-09-28 19:13:42 -04:00

feebumper.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

feebumper.h

…

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

init.cpp

Mention bech32m in -addresstype and -changetype help

2021-11-16 12:20:13 -05:00

interfaces.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

ismine.h

refactor: Use underlying type of isminetype for isminefilter

2021-11-25 14:56:30 +01:00

load.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

load.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

receive.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

receive.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

rpcdump.cpp

Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe

2021-11-25 19:41:53 +01:00

rpcwallet.cpp

Merge bitcoin/bitcoin#23602: wallet: Split stuff from rpcwallet

2021-11-30 13:09:20 +01:00

rpcwallet.h

wallet: Split signmessage from rpcwallet

2021-11-26 14:50:49 +01:00

salvage.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#22513: rpc: Allow walletprocesspsbt to sign without finalizing

2021-11-29 17:20:20 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#22513: rpc: Allow walletprocesspsbt to sign without finalizing

2021-11-29 17:20:20 +01:00

spend.cpp

External input fund support cleanups

2021-10-06 06:55:34 +08:00

spend.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

sqlite.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

sqlite.h

doc: fix various typos

2021-01-04 12:31:31 +08:00

transaction.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

transaction.h

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

wallet.cpp

Merge bitcoin/bitcoin#22513: rpc: Allow walletprocesspsbt to sign without finalizing

2021-11-29 17:20:20 +01:00

wallet.h

Merge bitcoin/bitcoin#22513: rpc: Allow walletprocesspsbt to sign without finalizing

2021-11-29 17:20:20 +01:00

walletdb.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

walletdb.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

wallettool.cpp

Merge bitcoin/bitcoin#23349: util: Use FEATURE_LATEST for wallets created with bitcoin-wallet

2021-11-16 15:32:18 +13:00

wallettool.h

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

walletutil.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

walletutil.h

wallet: Upgrade existing descriptor caches

2021-06-24 13:49:22 -04:00