mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-08 03:33:32 +01:00

Files

MarcoFalke 0fc6ea216c Merge #19096 : Remove g_rpc_chain global

4a7253ab6c Remove g_rpc_chain global (Russell Yanofsky)
e783197bf0 refactor: replace RegisterWalletRPCCommands with GetWalletRPCCommands (Russell Yanofsky)

Pull request description:

  Replace with RPC request reference to new WalletContext struct similar to the existing NodeContext struct and reference.

  This PR is a followup to #18740 removing the g_rpc_node global.

  Some later PRs will follow this up and move more wallet globals to the WalletContext struct.

ACKs for top commit:
  MarcoFalke:
    ACK 4a7253ab6c 🎋
  ariard:
    Code Review ACK 4a7253a, feel free to ignore comment it's super nit.

Tree-SHA512: 5bb5561c89f81811ca5232a58bf450e230d4218e62471c03227d142395fd36131672e99cb88329b33b9680a235db01e8b9d1c1e2a18288349e57205528deabab

2020-06-05 08:29:18 -04:00

chain.cpp

wallet: Minimal fix to restore conflicted transaction notifications

2020-05-15 09:23:55 -04:00

chain.h

wallet: Minimal fix to restore conflicted transaction notifications

2020-05-15 09:23:55 -04:00

handler.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

handler.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

node.cpp

Merge #18452 : qt: Fix shutdown when waitfor* cmds are called from RPC console

2020-05-29 15:49:46 +02:00

node.h

BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals.

2020-05-23 20:02:10 -03:00

README.md

…

wallet.cpp

Merge #19096 : Remove g_rpc_chain global

2020-06-05 08:29:18 -04:00

wallet.h

Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.

2020-05-23 20:02:04 -03:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.