highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-11 13:13:49 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
2324aa1dc409e9496b7083aaef5fcb20849f33c0
bitcoin/src
History
fanquake 2296fe65f5 Merge #16251: Improve signrawtransaction error reporting 
ec4c79326b signrawtransaction*: improve error for partial signing (Anthony Towns)
3c481f8921 signrawtransactionwithkey: better error messages for bad redeemScript/witnessScript (Anthony Towns)

Pull request description:

  Two fixes for `signrawtransactionwith{key,wallet}` (in addition to #16250): one that checks redeemScript/witnessScript matches scriptPubKey (and if both are provided that they match each other sanely), and the other changes the warning when some-but-not-all the signatures for a CHECKMULTISIG are provided to something that suggests more signatures may be all that's required.

  Fixes: #13218
  Fixes: #14823

ACKs for top commit:
  instagibbs:
    utACK ec4c79326b
  achow101:
    Code Review ACK ec4c79326b
  meshcollider:
    utACK ec4c79326b

Tree-SHA512: 0c95c91d498e85b834662b9e5c83f336ed5fd306be7701ce1dbfa0836fbeb448a267a796585512f7496e820be668b07c2a0a2f45e52dc23f09ee7d9c87e42b35
2019-09-11 15:37:13 +10:00
..
bench
scripted-diff: Use ArgsManager::DEBUG_ONLY flag
2019-07-27 15:05:14 +03:00
compat
…
config
…
consensus
[Consensus] Bury segwit deployment
2019-08-14 15:52:52 -04:00
crypto
Add ChaCha20Poly1305@Bitcoin AEAD implementation
2019-06-25 15:13:02 +02:00
index
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
interfaces
Expose wallet creation to the GUI via WalletController
2019-09-05 20:36:57 -04:00
leveldb
…
node
move-only: move coins statistics utils out of RPC
2019-08-27 11:51:56 -04:00
policy
[wallet] abort when attempting to fund a transaction above maxtxfee
2019-06-28 22:44:38 -04:00
primitives
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
qt
Merge #16680: Preparations for more testchains
2019-09-10 12:44:01 +03:00
rpc
Merge #16251: Improve signrawtransaction error reporting
2019-09-11 15:37:13 +10:00
script
Give more errors for specific failure conditions
2019-08-16 19:34:01 -04:00
secp256k1
Update the secp256k1 subtree to the latest upstream version
2019-03-31 11:41:05 -07:00
support
Improve documentation of memory_cleanse()
2019-07-01 12:59:44 +02:00
test
Merge #16680: Preparations for more testchains
2019-09-10 12:44:01 +03:00
univalue
…
util
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
wallet
Merge #16796: wallet: Fix segfault in CreateWalletFromFile
2019-09-09 23:34:05 +12:00
zmq
rpc: switch to using RPCHelpMan.Check()
2019-07-08 09:53:52 +09:00
.clang-format
…
addrdb.cpp
addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests.
2019-06-14 08:30:43 +02:00
addrdb.h
…
addrman.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
addrman.h
…
amount.h
…
arith_uint256.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
arith_uint256.h
…
attributes.h
…
banman.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bech32.h
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Merge #15864: Fix datadir handling
2019-08-19 10:01:30 -04:00
bitcoind-res.rc
…
bitcoind.cpp
Merge #16680: Preparations for more testchains
2019-09-10 12:44:01 +03:00
blockencodings.cpp
CorruptionPossible -> BLOCK_MUTATED
2019-05-02 15:14:12 -04:00
blockencodings.h
…
blockfilter.cpp
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
blockfilter.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
bloom.cpp
refactor: Improve CRollingBloomFilter::reset by using std::fill
2019-05-22 15:55:50 +01:00
bloom.h
…
chain.cpp
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chain.h
[doc] chain: Declare BLOCK_VALID_HEADER reserved
2019-08-05 07:58:58 -04:00
chainparams.cpp
[Consensus] Bury segwit deployment
2019-08-14 15:52:52 -04:00
chainparams.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsbase.cpp
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
chainparamsbase.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
2019-07-21 21:00:31 -04:00
coins.h
move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
2019-07-21 21:00:31 -04:00
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
Move PSBT decoding functions from core_io to psbt.cpp
2019-03-26 17:38:00 -07:00
core_memusage.h
…
core_read.cpp
Include core_io.h from core_read.cpp
2019-06-06 08:00:33 +02:00
core_write.cpp
Don't show addresses or P2PK in decoderawtransaction
2019-08-30 11:29:21 +09:00
cuckoocache.h
…
dbwrapper.cpp
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
dbwrapper.h
…
dummywallet.cpp
Expose wallet creation to the GUI via WalletController
2019-09-05 20:36:57 -04:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
Avoid redefine warning
2019-04-10 12:16:52 +01:00
fs.h
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063
2019-03-31 11:41:05 -07:00
httprpc.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
httprpc.h
…
httpserver.cpp
Remove global symbols: Avoid using the global namespace if possible
2019-05-25 23:23:11 +02:00
httpserver.h
[build] Add several util units
2019-04-09 17:53:08 -04:00
indirectmap.h
…
init.cpp
Merge #16796: wallet: Fix segfault in CreateWalletFromFile
2019-09-09 23:34:05 +12:00
init.h
…
key_io.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
key_io.h
…
key.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
key.h
CKey: add method to negate the key
2019-03-27 13:59:50 +01:00
limitedmap.h
…
logging.cpp
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
logging.h
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
Makefile.am
move-only: move coins statistics utils out of RPC
2019-08-27 11:51:56 -04:00
Makefile.bench.include
Merge #15649: Add ChaCha20Poly1305@Bitcoin AEAD
2019-07-11 22:00:16 +02:00
Makefile.leveldb.include
…
Makefile.qt.include
Add CreateWalletDialog to create wallets from the GUI
2019-09-05 20:36:57 -04:00
Makefile.qttest.include
scripted-diff: Rename test_bitcoin to test/setup_common
2019-04-11 10:12:36 -04:00
Makefile.test.include
Move ismine to wallet module
2019-06-19 18:06:30 -04:00
memusage.h
…
merkleblock.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
merkleblock.h
…
miner.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
miner.h
…
net_permissions.cpp
util: Move ResolveErrMsg to util/error
2019-08-15 10:05:32 -04:00
net_permissions.h
Make whitebind/whitelist permissions more flexible
2019-08-11 11:33:27 +09:00
net_processing.cpp
Merge #15759: p2p: Add 2 outbound block-relay-only connections
2019-09-07 17:45:03 +08:00
net_processing.h
refactor : use RelayTransaction in BroadcastTransaction utility
2019-07-24 19:47:56 -04:00
net.cpp
Merge #15759: p2p: Add 2 outbound block-relay-only connections
2019-09-07 17:45:03 +08:00
net.h
Merge #15759: p2p: Add 2 outbound block-relay-only connections
2019-09-07 17:45:03 +08:00
netaddress.cpp
Fix spelling errors identified by codespell 1.15.0
2019-06-11 17:18:16 +02:00
netaddress.h
netaddress: Update CNetAddr for ORCHIDv2
2019-05-15 14:21:48 -04:00
netbase.cpp
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netbase.h
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netmessagemaker.h
…
noui.cpp
Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors
2019-08-01 15:17:10 +02:00
noui.h
Suppress output in test_bitcoin for expected errors
2019-07-03 14:03:21 +02:00
optional.h
…
outputtype.cpp
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
outputtype.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pow.cpp
…
pow.h
…
prevector.h
Merge #12324: speed up Unserialize_impl for prevector
2019-06-18 17:12:02 +02:00
protocol.cpp
…
protocol.h
Remove unused bits from the service flags enum
2019-07-12 14:14:54 -04:00
psbt.cpp
Merge #15427: Add support for descriptors to utxoupdatepsbt
2019-07-02 16:53:22 +02:00
psbt.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pubkey.cpp
…
pubkey.h
…
random.cpp
net: Use mockable time for tx download
2019-06-17 14:12:32 -04:00
random.h
net: Use mockable time for tx download
2019-06-17 14:12:32 -04:00
rest.cpp
refactor: pcoinsTip -> CChainState::CoinsTip()
2019-08-06 13:13:06 -04:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Support serialization of std::vector<bool>
2019-08-26 11:36:33 -07:00
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
…
sync.cpp
Replace remaining fprintf with tfm::format manually
2019-06-13 11:46:38 -04:00
sync.h
scripted-diff: Rename LockAnnotation to LockAssertion
2019-05-17 13:29:04 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
2019-05-17 13:29:04 +02:00
timedata.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
timedata.h
…
tinyformat.h
tinyformat: Add doc to Bitcoin Core specific strprintf
2019-06-13 09:30:40 -04:00
torcontrol.cpp
fix: tor: Call event_base_loopbreak from the event's callback
2019-07-17 15:32:38 +01:00
torcontrol.h
…
txdb.cpp
refactor: have CCoins* data managed under CChainState
2019-08-15 11:04:10 -04:00
txdb.h
refactor: have CCoins* data managed under CChainState
2019-08-15 11:04:10 -04:00
txmempool.cpp
validation: Add missing mempool locks
2019-06-07 11:07:09 +02:00
txmempool.h
refactor: pcoinsTip -> CChainState::CoinsTip()
2019-08-06 13:13:06 -04:00
ui_interface.cpp
Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit
2019-06-18 15:59:53 -04:00
ui_interface.h
Add MSG_NOPREFIX flag for user messages
2019-06-19 19:22:34 +03:00
uint256.cpp
Merge #14734: fix an undefined behavior in uint::SetHex
2019-07-03 14:18:29 +02:00
uint256.h
…
undo.h
…
validation.cpp
Merge #16421: Conservatively accept RBF bumps bumping one tx at the package limits
2019-09-07 10:15:43 +08:00
validation.h
[Fix] The default whitelistrelay should be true
2019-08-17 00:43:22 +09:00
validationinterface.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
validationinterface.h
Remove extra CBlockIndex declaration
2019-06-25 15:02:34 -04:00
version.h
…
versionbits.cpp
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbits.h
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbitsinfo.cpp
[Consensus] Bury segwit deployment
2019-08-14 15:52:52 -04:00
versionbitsinfo.h
…
walletinitinterface.h
refactor: Cleanup walletinitinterface.h
2019-09-08 17:29:30 +03:00
warnings.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
warnings.h
…