00d22328b0
Since #32420, createNewBlock has thrown `bad-cb-length` errors when called at low block heights because `OP_0` padding stopped being added to coinbase transactions. (#32420 did add an `include_dummy_extranonce` option which could bypass this, but it was not exposed to IPC clients.) Fix the problem by padding coinbase transactions with `OP_0` when necessary to produce valid blocks. Additionally this commit stops adding `OP_0` padding to the template `script_sig_prefix` field when `include_dummy_extranonce` is true. This is safe because non-IPC clients don't use this field, and IPC clients could never set the option to true, and are expected to add their own nonces in any case. This also improves documentation about the `script_sig_prefix` field and `getCoinbaseTx` method.
Internal c++ interfaces
The following interfaces are defined here:
-
Chain— used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973. -
ChainClient— used by node to start & stopChainclients. Added in #14437. -
Node— used by GUI to start & stop bitcoin node. Added in #10244. -
Handler— returned byhandleEventmethods on interfaces above and used to manage lifetimes of event handlers. -
Init— used by multiprocess code to access interfaces above on startup. Added in #19160. -
Ipc— used by multiprocess code to accessInitinterface across processes. Added in #19160. -
Rpc— used bybitcoin-clito be able to call RPC methods over a unix socket instead of TCP.
The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.