MarcoFalke 0f55294cc1 Merge #18875: fuzz: Stop nodes in process_message* fuzzers ...

fab860aed4 fuzz: Stop nodes in process_message* fuzzers (MarcoFalke)
6666c828e0 fuzz: Give CNode ownership to ConnmanTestMsg in process_message fuzz harness (MarcoFalke)

Pull request description:

  Background is that I saw an integer overflow in net_processing

  ```
  #30629113	REDUCE cov: 25793 ft: 142917 corp: 3421/2417Kb lim: 4096 exec/s: 89 rss: 614Mb L: 1719/4096 MS: 1 EraseBytes-
  net_processing.cpp:977:25: runtime error: signed integer overflow: 2147483624 + 100 cannot be represented in type 'int'
  SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior net_processing.cpp:977:25 in
  net_processing.cpp:985:9: runtime error: signed integer overflow: -2147483572 - 100 cannot be represented in type 'int'
  SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior net_processing.cpp:985:9 in
  ```

  Telling from the line numbers, it looks like `nMisbehavior` wrapped around.

  Fix that by calling `StopNodes` after each exec, which should clear the node state and thus `nMisbehavior`.

ACKs for top commit:
  practicalswift:
    ACK fab860aed4

Tree-SHA512: 891c081d5843565d891aec028b6c27ef3fa39bc40ae78238e81d8f784b4d4b49cb870998574725a5159dd03aeeb2e0b9bc3d3bb51d57d1231ef42e3394b2d639

2020-06-03 07:23:41 -04:00

..

addition_overflow.cpp

…

addrdb.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

asmap_direct.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

asmap.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

base_encode_decode.cpp

…

bech32.cpp

…

block_header.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

block.cpp

tests: Fill fuzzing coverage gaps for functions in consensus/validation.h

2020-05-14 18:45:42 +00:00

blockfilter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

bloom_filter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

chain.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

checkqueue.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

coins_view.cpp

tests: Add fuzzing harness for CCoinsViewCache

2020-05-25 10:05:06 +00:00

cuckoocache.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

flatfile.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

float.cpp

…

fuzz.cpp

tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers)

2020-05-22 15:15:46 +00:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

hex.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

http_request.cpp

…

integer.cpp

Merge #18413: script: prevent UB when computing abs value for num opcode serialize

2020-05-02 21:24:05 +08:00

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

locale.cpp

…

merkleblock.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

message.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

multiplication_overflow.cpp

…

net_permissions.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

netaddress.cpp

…

p2p_transport_deserializer.cpp

…

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

policy_estimator.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

pow.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

prevector.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

primitives_transaction.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

process_message.cpp

Merge #18875: fuzz: Stop nodes in process_message* fuzzers

2020-06-03 07:23:41 -04:00

process_messages.cpp

fuzz: Stop nodes in process_message* fuzzers

2020-05-12 07:28:12 -04:00

protocol.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

psbt.cpp

…

random.cpp

…

rbf.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

rolling_bloom_filter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

script_bitcoin_consensus.cpp

tests: Add fuzzing harness for functions in script/bitcoinconsensus.h

2020-05-30 10:37:01 +00:00

script_descriptor_cache.cpp

tests: Add fuzzing harness for functions in script/descriptor.h

2020-05-30 10:37:01 +00:00

script_flags.cpp

…

script_interpreter.cpp

tests: Add fuzzing harness for functions in script/interpreter.h

2020-05-30 10:37:01 +00:00

script_ops.cpp

…

script_sigcache.cpp

tests: Add fuzzing harness for functions in script/sigcache.h

2020-05-30 10:37:01 +00:00

script_sign.cpp

tests: Add fuzzing harness for functions in script/sign.h

2020-05-30 10:37:01 +00:00

script.cpp

tests: Fill fuzzing coverage gaps for functions in script/script.h, script/script_error.h and script/standard.h

2020-05-30 10:37:01 +00:00

scriptnum_ops.cpp

…

signature_checker.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

tests: Fill fuzzing coverage gaps for functions in script/script.h, script/script_error.h and script/standard.h

2020-05-30 10:37:01 +00:00

strprintf.cpp

tests: Fill fuzzing coverage gaps for functions in util/translation.h

2020-05-14 18:52:57 +00:00

system.cpp

fuzz: fix vector size problem in system fuzzer

2020-05-08 20:21:48 +02:00

timedata.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

util.h

tests: Add fuzzing helper functions ConsumeDataStream, ConsumeTxDestination and ConsumeUInt160

2020-05-29 16:44:22 +00:00