merge-script 053a5fc7d9 Merge bitcoin/bitcoin#22762: Raise InitError when peers.dat is invalid or corrupted ...

fa55c3dc1b Raise InitError when peers.dat is invalid or corrupted (MarcoFalke)
fa4e2ccfd8 Inline ReadPeerAddresses (MarcoFalke)
fa5aeec80c Move LoadAddrman from init to addrdb (MarcoFalke)

Pull request description:

  peers.dat is silently erased when it can not be parsed or when it appears corrupted. Fix that by notifying the user. This might help in the following examples:

  * The user provided the database, but picked the wrong one.
  * A future version of Bitcoin Core wrote the file and it can't be read.
  * The file was corrupted by a logic bug in Bitcoin Core.
  * The file was corrupted by a disk failure.

ACKs for top commit:
  jonatack:
    Code review re-ACK fa55c3dc1b per `git range-diff eb1f570 fa59c6d fa55c3` and verified the new tests fail on master, except "Check mocked addrman is valid", as expected
  prayank23:
    tACK fa55c3dc1b
  vasild:
    ACK fa55c3dc1b

Tree-SHA512: 78264a78ee570a3c3262cf9c8542b5ffaffa5f52da1eef66c8c381f346989272967cfe1769c573502d9d7d3f7ad68c3ac3b2ec734185d2e4e7595b7122b14196

2021-09-10 11:41:20 +02:00

..

addition_overflow.cpp

…

addrman.cpp

[asmap] Remove SanityCheckASMap() from netaddress

2021-09-07 13:31:10 +01:00

asmap_direct.cpp

…

asmap.cpp

[asmap] Remove SanityCheckASMap() from netaddress

2021-09-07 13:31:10 +01:00

autofile.cpp

…

banman.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

base_encode_decode.cpp

…

bech32.cpp

…

block_header.cpp

…

block.cpp

…

blockfilter.cpp

fuzz: Avoid timeout in blockfilter fuzz target

2021-08-20 15:45:15 +02:00

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

coins_view.cpp

…

connman.cpp

[addrman] Set m_asmap in CAddrMan initializer list

2021-08-27 10:55:41 +01:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20_poly1305_aead.cpp

…

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

cuckoocache.cpp

…

data_stream.cpp

Raise InitError when peers.dat is invalid or corrupted

2021-09-09 09:20:43 +02:00

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

Merge bitcoin/bitcoin#22791: init: Fix asmap/addrman initialization order bug

2021-09-06 12:41:36 +02:00

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

…

fuzz.h

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

FuzzedDataProvider.h

…

golomb_rice.cpp

…

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

Fix addrdb includes

2021-09-07 10:44:48 +02:00

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

make ParseOutputType return a std::optional<OutputType>

2021-08-04 19:20:32 +08:00

load_external_block_file.cpp

…

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

build: Fix undefined reference to __mulodi4

2021-07-27 14:53:24 +03:00

net_permissions.cpp

…

net.cpp

[net] Remove asmap argument from CNode::CopyStats()

2021-09-07 15:24:14 +01:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

p2p_transport_serialization.cpp

…

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

util: make ParseMoney return a std::optional<CAmount>

2021-08-04 19:48:24 +08:00

parse_script.cpp

…

parse_univalue.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

…

pow.cpp

…

prevector.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

primitives_transaction.cpp

…

process_message.cpp

…

process_messages.cpp

…

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

…

rolling_bloom_filter.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

make ParseOutputType return a std::optional<OutputType>

2021-08-04 19:20:32 +08:00

strprintf.cpp

…

system.cpp

fuzz: Avoid OOM in system fuzz target

2021-08-06 12:31:28 +02:00

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

txrequest.cpp

…

util.cpp

…

util.h

…

utxo_snapshot.cpp

…

validation_load_mempool.cpp

…

versionbits.cpp

Move addrman includes from .h to .cpp

2021-09-07 10:44:43 +02:00