bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-08 11:44:14 +01:00

Files

fanquake 0a13d15c14 Merge #20530 : lint, refactor: Update cppcheck linter to c++17 and improve explicit usage

1e62350ca2 refactor: Improve use of explicit keyword (Fabian Jahr)
c502a6dbfb lint: Use c++17 std in cppcheck linter (Fabian Jahr)

Pull request description:

  I found the `extended-lint-cppcheck` linter still uses `std=c++11` when reviewing #20471. The only difference in the output after this change is one line is missing:

  ```
  src/script/descriptor.cpp:159:5: warning: Struct 'PubkeyProvider' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  ```

  After some digging, I am still not sure why this one is ignored with c++17 when 40 other`noExplicitConstructor` warnings were still appearing.

  In the second commit, I fix these warnings, adding `explicit` where appropriate and adding fixes to ignore otherwise.

ACKs for top commit:
  practicalswift:
    cr ACK 1e62350ca2: patch looks correct!
  MarcoFalke:
    review ACK 1e62350ca2

Tree-SHA512: dff7b324429a57160e217cf38d9ddbb6e70c6cb3d3e3e0bd4013d88e07afc2292c3df94d0acf7122e9d486322821682ecf15c8f2724a78667764c05d47f89a12

2020-12-02 20:52:19 +08:00

test

Merge #15710 : wallet: Catch ios_base::failure specifically

2020-11-19 12:32:48 +01:00

bdb.cpp

…

bdb.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

coincontrol.cpp

…

coincontrol.h