Andrew Chow 25d045a9ec Merge bitcoin/bitcoin#24225: wallet: Add sanity checks to DiscourageFeeSniping ...

fa8e76bb90 wallet: Add sanity checks to AntiFeeSnipe (MarcoFalke)

Pull request description:

  I added those sanity checks as part of implementing BIP 326, but I think they make sense on their own. The checks require the transaction to be passed in to `DiscourageFeeSniping`. Also, replace `(int)locktime` cast with the equivalent `int(locktime)` cast.

ACKs for top commit:
  chris-belcher:
    ACK fa8e76bb90
  S3RK:
    Code review ACK fa8e76bb90
  achow101:
    ACK fa8e76bb90
  w0xlt:
    Code Review ACK fa8e76bb90

Tree-SHA512: 6fe37c85f074851ef09cae8addcb836257089290fecec515c129c3180e9ccb64740aaac76043af10ce7c213e5001568ca6b4b62ae9631f0994ed676b07118074

2022-03-14 10:31:25 +00:00

..

rpc

Merge bitcoin/bitcoin#24505: wallet: Add a deprecation warning for newly created legacy wallets

2022-03-14 08:37:46 +01:00

test

…

bdb.cpp

…

bdb.h

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

[wallet] assert BnB internally calculated waste is the same as GetSelectionWaste()

2022-03-11 12:22:34 +00:00

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

…

ismine.h

…

load.cpp

…

load.h

…

receive.cpp

…

receive.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

spend.cpp

Merge bitcoin/bitcoin#24225: wallet: Add sanity checks to DiscourageFeeSniping

2022-03-14 10:31:25 +00:00

spend.h

…

sqlite.cpp

wallet: refactor: dedup sqlite blob binding

2022-03-06 20:43:16 +01:00

sqlite.h

…

transaction.cpp

…

transaction.h

…

wallet.cpp

wallet: Add a deprecation warning for newly created legacy wallets

2022-03-10 07:32:02 -05:00

wallet.h

…

walletdb.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

walletdb.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…