highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-21 07:39:08 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
2649e655b9203d6d08cb1a26fa4846f2c403b297
bitcoin/src
History
Ava Chow 2649e655b9 Merge bitcoin/bitcoin#29412: p2p: Don't process mutated blocks 
d8087adc7e [test] IsBlockMutated unit tests (dergoegge)
1ed2c98297 Add transaction_identifier::size to allow Span conversion (dergoegge)
1ec6bbeb8d [validation] Cache merkle root and witness commitment checks (dergoegge)
5bf4f5ba32 [test] Add regression test for #27608 (dergoegge)
49257c0304 [net processing] Don't process mutated blocks (dergoegge)
2d8495e080 [validation] Merkle root malleation should be caught by IsBlockMutated (dergoegge)
66abce1d98 [validation] Introduce IsBlockMutated (dergoegge)
e7669e1343 [refactor] Cleanup merkle root checks (dergoegge)
95bddb930a [validation] Isolate merkle root checks (dergoegge)

Pull request description:

  This PR proposes to check for mutated blocks early as a defense-in-depth mitigation against attacks leveraging mutated blocks.

  We introduce `IsBlockMutated` which catches all known forms of block malleation and use it to do an early mutation check whenever we receive a `block` message.

  We have observed attacks that abused mutated blocks in the past, which could have been prevented by simply not processing mutated blocks (e.g. https://github.com/bitcoin/bitcoin/pull/27608 for which a regression test is included in this PR).

ACKs for top commit:
  achow101:
    ACK d8087adc7e
  maflcko:
    ACK d8087adc7e 🏄
  fjahr:
    Code review ACK d8087adc7e
  sr-gi:
    Code review ACK d8087adc7e

Tree-SHA512: 618ff4ea7f168e10f07504d3651290efbb1bb2ab3b838ffff3527c028caf6c52dedad18d04d3dbc627977479710930e200f2dfae18a08f627efe7e64a57e535f
2024-02-28 17:54:49 -05:00
..
bench
refactor: Add missing include for USE_BDB, USE_SQLITE to bench/wallet_ismine.cpp
2024-02-20 15:11:58 +01:00
common
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
compat
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
config
…
consensus
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
crc32c
Update crc32c subtree to latest upstream master
2024-02-27 18:28:19 +00:00
crypto
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
index
refactor: Remove calls to StartShutdown from KernelNotifications
2023-12-04 15:39:15 -04:00
init
doc: add unconditional info loglevel following merge of PR 28318
2024-01-11 11:01:28 -06:00
interfaces
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
ipc
multiprocess: Add type conversion code for UniValue types
2023-11-28 12:35:50 -05:00
kernel
Merge bitcoin/bitcoin#29254: log: Don't use scientific notation in log messages
2024-02-05 14:21:10 +00:00
leveldb
Update leveldb-subtree subtree to latest upstream
2022-09-29 16:43:30 +01:00
logging
Use steady clock for logging timer
2023-01-31 18:48:50 +01:00
minisketch
Update minisketch subtree to latest upstream
2022-10-23 15:03:04 +01:00
node
refactor: Fix timedata includes
2024-02-01 13:52:05 +01:00
policy
[doc] fix docs and comments from v3
2024-02-12 14:27:25 +00:00
primitives
[validation] Cache merkle root and witness commitment checks
2024-02-27 14:19:15 +00:00
qt
Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup
2024-02-20 13:07:48 +00:00
rpc
Merge bitcoin/bitcoin#29345: rpc: Do not wait for headers inside loadtxoutset
2024-02-26 11:11:25 +00:00
script
wallet: fix key parsing check for miniscript expressions in ParseScript
2023-12-08 06:54:00 -03:00
secp256k1
Update secp256k1 subtree to latest master
2024-01-04 14:40:28 +00:00
support
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
test
Merge bitcoin/bitcoin#29412: p2p: Don't process mutated blocks
2024-02-28 17:54:49 -05:00
univalue
Remove unused raw-pointer read helper from univalue
2023-07-27 14:24:52 +02:00
util
Add transaction_identifier::size to allow Span conversion
2024-02-27 14:19:15 +00:00
wallet
Fix CI-detected codespell warnings
2024-02-23 23:01:07 +01:00
zmq
Remove deprecated -rpcserialversion
2023-12-11 18:22:13 +01:00
.bear-tidy-config
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
.clang-format
refactor: Print verbose serialize compiler error messages
2023-12-15 15:20:54 +01:00
.clang-tidy
refactor: Fix bugprone-string-constructor warning
2023-10-30 14:59:17 +01:00
addrdb.cpp
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
addrdb.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addresstype.cpp
Add PubKeyDestination for P2PK scripts
2023-09-12 12:14:31 -04:00
addresstype.h
bugfix: Mark CNoDestination and PubKeyDestination constructor explicit
2023-10-25 22:46:55 +02:00
addrman_impl.h
net: Optionally include terrible addresses in GetAddr results
2023-10-04 18:08:49 +02:00
addrman.cpp
Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup
2024-02-20 13:07:48 +00:00
addrman.h
doc, test: Test and explain service flag handling
2024-01-15 16:19:53 -05:00
arith_uint256.cpp
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
arith_uint256.h
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
attributes.h
Introduce platform-agnostic ALWAYS_INLINE macro
2023-05-04 20:57:51 +01:00
banman.cpp
Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it
2023-11-02 14:09:27 -04:00
banman.h
Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it
2023-11-02 14:09:27 -04:00
base58.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
base58.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
bech32.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
bech32.h
…
bip324.cpp
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bip324.h
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bitcoin-chainstate.cpp
Remove GetAdjustedTime
2024-01-05 17:16:38 +00:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Fix -netinfo backward compat with getpeerinfo pre-v26
2024-01-09 15:27:08 -06:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
doc: Update bitcoin-tx replaceable documentation
2023-12-11 13:08:46 -05:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
blockencodings.cpp
serialize: Drop useless version param from GetSerializeSize()
2023-11-16 11:14:13 +10:00
blockencodings.h
Use ParamsWrapper for witness serialization
2023-11-14 08:45:30 +10:00
blockfilter.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
blockfilter.h
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
chain.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
chain.h
refactor: Fix timedata includes
2024-02-01 13:52:05 +01:00
chainparams.cpp
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparams.h
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparamsbase.cpp
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsbase.h
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsseeds.h
p2p: update hardcoded mainnet seeds for 25.x
2023-04-20 06:08:22 -07:00
checkqueue.h
refactor: Make CCheckQueue non-copyable and non-movable explicitly
2023-10-03 10:52:17 +01:00
clientversion.cpp
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
clientversion.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins.cpp
Use Txid in COutpoint
2023-11-21 13:15:44 +00:00
coins.h
Merge bitcoin/bitcoin#28922: Use Txid in COutpoint
2023-11-24 14:41:58 +00:00
compressor.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
compressor.h
…
core_io.h
Remove deprecated -rpcserialversion
2023-12-11 18:22:13 +01:00
core_memusage.h
…
core_read.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
core_write.cpp
Remove deprecated -rpcserialversion
2023-12-11 18:22:13 +01:00
cuckoocache.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
dbwrapper.cpp
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
dbwrapper.h
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
deploymentinfo.cpp
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentinfo.h
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentstatus.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
deploymentstatus.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
dummywallet.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
external_signer.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
external_signer.h
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
flatfile.cpp
refactor: Extract util/fs_helpers from util/system
2023-03-23 12:52:00 +01:00
flatfile.h
Merge bitcoin/bitcoin#27254: refactor: Extract util/fs from util/system
2023-04-03 14:41:22 +01:00
hash.cpp
crypto, hash: replace custom rotl32 with std::rotl
2024-01-05 17:12:38 +01:00
hash.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
headerssync.cpp
refactor: Fix timedata includes
2024-02-01 13:52:05 +01:00
headerssync.h
[headerssync] Make m_commit_offset protected
2022-12-12 21:06:04 +00:00
httprpc.cpp
refactor: drop protocol.h include header in rpc/util.h
2023-09-19 15:54:17 -06:00
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#28318: logging: Simplify API for level based logging
2024-01-10 14:11:32 -05:00
httpserver.h
refactor: Remove call to ShutdownRequested from HTTPRequest
2023-12-04 15:39:15 -04:00
i2p.cpp
net: create I2P sessions with both ECIES-X25519 and ElGamal encryption
2024-01-07 16:24:08 -06:00
i2p.h
i2p: destroy the session if we get an unexpected error from the I2P router
2023-10-05 14:11:13 +02:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#28956: Nuke adjusted time from validation (attempt 2)
2024-01-31 15:58:47 -05:00
init.h
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
key_io.cpp
refactor: Allow std::span construction from CKey
2024-01-16 15:29:18 +01:00
key_io.h
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
key.cpp
refactor: Allow std::span construction from CKey
2024-01-16 15:29:18 +01:00
key.h
refactor: Allow std::span construction from CKey
2024-01-16 15:29:18 +01:00
logging.cpp
logging: add -loglevelalways=1 option
2023-12-15 11:03:25 +10:00
logging.h
logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace
2023-12-20 15:59:48 +10:00
Makefile.am
Merge bitcoin/bitcoin#28948: v3 transaction policy for anti-pinning
2024-02-09 23:37:57 -05:00
Makefile.bench.include
bench: Add a benchmark for ismine
2024-02-16 14:35:33 -05:00
Makefile.crc32c.include
build: Create .la library for crc32c
2022-04-26 16:25:38 -04:00
Makefile.leveldb.include
Use more specific path when including memenv.h header
2022-06-23 15:33:01 +02:00
Makefile.minisketch.include
build: Build minisketch test in make check, not in make
2022-07-21 10:42:09 +01:00
Makefile.qt_locale.include
qt: Translation updates from Transifex
2024-02-07 09:23:42 +00:00
Makefile.qt.include
Merge bitcoin/bitcoin#22764: build: Include qt sources for parsing with extract_strings.py
2023-10-19 13:25:49 +01:00
Makefile.qttest.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.test_fuzz.include
fuzz: move MockedDescriptorConverter to fuzz/util
2023-11-20 15:57:50 -03:00
Makefile.test_util.include
Merge bitcoin/bitcoin#27425: test: move remaining rand code from util/setup_common to util/random
2023-07-19 10:26:11 +01:00
Makefile.test.include
test: Add makefile target for running unit tests
2024-02-03 17:59:43 +01:00
Makefile.univalue.include
…
mapport.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
mapport.h
Remove configure-time setting of DEFAULT_UPNP
2023-01-28 15:24:13 +00:00
memusage.h
add std::list to memusage
2023-09-13 11:37:45 +01:00
merkleblock.cpp
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
merkleblock.h
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
net_permissions.cpp
Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet
2023-10-26 14:29:47 -04:00
net_permissions.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
net_processing.cpp
[net processing] Don't process mutated blocks
2024-02-27 14:19:15 +00:00
net_processing.h
net: move state dependent peer services flags
2024-01-15 10:28:20 -03:00
net_types.cpp
p2p: return CSubNet in LookupSubNet
2023-05-30 16:27:21 -03:00
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#28170: p2p: adaptive connections services flags
2024-01-31 11:44:41 -05:00
net.h
Merge bitcoin/bitcoin#29347: net: enable v2transport by default
2024-01-31 15:33:57 -05:00
netaddress.cpp
Inline short, often-called, rarely-changed basic CNetAddr getters
2023-07-19 12:43:05 -06:00
netaddress.h
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
netbase.cpp
Merge bitcoin/bitcoin#28649: Do the SOCKS5 handshake reliably
2023-11-07 14:11:58 -05:00
netbase.h
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
netgroup.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netgroup.h
net: Add continuous ASMap health check logging
2023-12-02 22:03:08 +01:00
netmessagemaker.h
refactor: NetMsg::Make() without nVersion
2023-11-20 14:02:27 +01:00
noui.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
noui.h
…
outputtype.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
outputtype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
pow.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
pow.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
prevector.h
refactor: Mark prevector iterator with std::contiguous_iterator_tag
2024-01-18 19:29:34 +01:00
protocol.cpp
net: remove now unused global 'g_initial_block_download_completed'
2024-01-23 10:25:16 -03:00
protocol.h
net: remove now unused global 'g_initial_block_download_completed'
2024-01-23 10:25:16 -03:00
psbt.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
psbt.h
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
pubkey.cpp
pubkey: introduce a GetEvenCorrespondingCPubKey helper
2023-10-08 02:43:19 +02:00
pubkey.h
Add missing XOnlyPubKey::data() to get mutable data
2024-01-16 10:58:57 +01:00
random.cpp
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
random.h
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
randomenv.cpp
[refactor] Remove compat.h from kernel headers
2023-09-12 22:51:48 +02:00
randomenv.h
…
rest.cpp
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
rest.h
…
reverse_iterator.h
doc: remove usages of C++11
2023-01-12 13:42:44 +00:00
scheduler.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
scheduler.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
serialize.h
serialization: replace char-is-int8_t autoconf detection with c++20 concept
2024-02-27 19:03:26 +00:00
signet.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
signet.h
…
span.h
Allow int8_t optimized vector serialization
2023-12-22 09:58:19 +01:00
streams.cpp
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
streams.h
Remove unused CDataStream
2023-11-30 11:27:54 +01:00
sync.cpp
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
sync.h
Merge bitcoin/bitcoin#27116: doc: clarify that LOCK() internally checks whether the mutex is held
2023-10-26 15:02:13 -04:00
threadsafety.h
…
timedata.cpp
Remove GetAdjustedTime
2024-01-05 17:16:38 +00:00
timedata.h
refactor: Fix timedata includes
2024-02-01 13:52:05 +01:00
tinyformat.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
torcontrol.cpp
Merge bitcoin/bitcoin#28318: logging: Simplify API for level based logging
2024-01-10 14:11:32 -05:00
torcontrol.h
doc, refactor: Changing -torcontrol help to specify that a default port is used
2023-08-17 23:58:47 -05:00
txdb.cpp
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
txdb.h
move-only: Move CBlockTreeDB to node/blockstorage
2023-08-01 15:27:33 +02:00
txmempool.cpp
Merge bitcoin/bitcoin#28948: v3 transaction policy for anti-pinning
2024-02-09 23:37:57 -05:00
txmempool.h
Merge bitcoin/bitcoin#28948: v3 transaction policy for anti-pinning
2024-02-09 23:37:57 -05:00
txorphanage.cpp
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
txorphanage.h
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
txrequest.cpp
refactor: modernize-use-default-member-init for bit-fields (C++20)
2023-12-07 11:06:01 +01:00
txrequest.h
…
uint256.cpp
refactor: modernize the implementation of uint256.*
2022-12-10 14:34:44 -06:00
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
validation.cpp
Merge bitcoin/bitcoin#29412: p2p: Don't process mutated blocks
2024-02-28 17:54:49 -05:00
validation.h
Merge bitcoin/bitcoin#29412: p2p: Don't process mutated blocks
2024-02-28 17:54:49 -05:00
validationinterface.cpp
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
validationinterface.h
doc: fix typo and update incorrect comment
2024-01-02 12:40:11 +01:00
versionbits.cpp
refactor: use braced init for integer constants instead of c style casts
2023-01-03 19:31:29 -06:00
versionbits.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
walletinitinterface.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
warnings.cpp
scripted-diff: Fix bitcoin_config_h includes
2024-02-13 20:10:44 +00:00
warnings.h
…