mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-19 20:20:00 +01:00
27d12cf17f
0ea84bc362test: explicitly check boolean verbosity is disallowed (tdb3)7a2e6b68cddoc: add rpc guidance for boolean verbosity avoidance (tdb3)698f302df8rpc: disallow boolean verbosity in getorphantxs (tdb3)63f5e6ec79test: add entry and expiration time checks (tdb3)808a708107rpc: add entry time to getorphantxs (tdb3)56bf302714refactor: rename rpc_getorphantxs to rpc_orphans (tdb3)7824f6b077test: check that getorphantxs is hidden (tdb3)ac68fcca70rpc: disallow undefined verbosity in getorphantxs (tdb3) Pull request description: Implements follow-up suggestions from #30793. - Now disallows undefined verbosity levels (below and above valid values) (https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1786093549) - Disallows boolean verbosity (https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1788273274) and adds guidance to developer-notes - Checks that `getorphantxs` is a hidden rpc (https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1786107786) - Adds a test for `expiration` time - Adds `entry` time to the returned orphan objects (verbosity >=1) to relieve the user from having to calculate it from `expiration`. Also adds associated test. (https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1743687732) - Minor cleanup (blank line removal and log message move) (https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1786092641) Included a commit to rename the test to a more generic `get_orphans` to better accommodate future orphanage-related RPCs (e.g. `getorphanangeinfo`). Can drop the refactor commit from this PR if people feel strongly about it. ACKs for top commit: achow101: ACK0ea84bc362glozow: utACK0ea84bc362rkrux: tACK0ea84bc362itornaza: tACK0ea84bc362Tree-SHA512: e48a088f333ebde132923072da58e970461e74362d0acebbc799c3043d5727cdf5f28e82b43cb38bbed27c603df6710695dba91ff0695e623ad168e985dce08e