highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-03 19:49:12 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
286de1e7b3c2d00dcadc8f1e79bb69c2858f17f7
bitcoin/src
History
merge-script 286de1e7b3 Merge bitcoin/bitcoin#34093: netif: fix compilation warning in QueryDefaultGatewayImpl() 
c1361fc42d netif: fix compilation warning in QueryDefaultGatewayImpl() (MarcoFalke)

Pull request description:

  ```
  src/common/netif.cpp:137:51: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'unsigned long' [-Werror,-Wsign-compare]
    137 |         for (nlmsghdr* hdr = (nlmsghdr*)response; NLMSG_OK(hdr, recv_result); hdr = NLMSG_NEXT(hdr, recv_result)) {
        |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
  /usr/include/netlink/netlink.h:220:31: note: expanded from macro 'NLMSG_OK'
    220 | #define NLMSG_OK(_hdr, _len)            NL_ITEM_OK(_hdr, _len, NLMSG_HDRLEN, _NLMSG_LEN)
        |                                         ^                ~~~~  ~~~~~~~~~~~~
  /usr/include/netlink/netlink.h:203:10: note: expanded from macro 'NL_ITEM_OK'
    203 |         ((_len) >= _hlen && _LEN_M(_ptr) >= _hlen && _LEN_M(_ptr) <= (_len))
        |           ~~~~  ^  ~~~~~
  1 error generated.
  ```

  Happens on FreeBSD 15.0, with the default compiler (Clang 19).

  On FreeBSD 14, `/usr/include/netlink/netlink.h` contains:
  ```
   #define NLMSG_HDRLEN                    ((int)sizeof(struct nlmsghdr))
  ```

  On FreeBSD 15, `/usr/include/netlink/netlink.h` contains:
  ```
   #define NLMSG_HDRLEN                    (sizeof(struct nlmsghdr))
  ```

ACKs for top commit:
  maflcko:
    lgtm ACK c1361fc42d
  hebasto:
    ACK c1361fc42d.

Tree-SHA512: f8f00e2106fdf91550ab388a65bb8408fcf8c4557da9614e2e1dd90e70fc010dff72bfabbbec4315335afdedb546f7b554f5c98133c5aa1d3077c5641d94b956
2026-02-27 11:59:03 +00:00
..
bench
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
common
Merge bitcoin/bitcoin#34093: netif: fix compilation warning in QueryDefaultGatewayImpl()
2026-02-27 11:59:03 +00:00
compat
refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning
2026-02-18 21:29:07 +01:00
consensus
consensus/doc: explain GetValueOut() precondition
2026-02-02 19:32:14 +01:00
crc32c
…
crypto
iwyu: Add temporary mapping to work around upstream bug
2026-01-30 11:50:17 +00:00
index
Merge bitcoin/bitcoin#29770: index: Check all necessary block data is available before starting to sync
2026-02-20 15:58:48 -08:00
init
log: Print warning about privacy-sensitive log info unconditionally
2026-01-27 13:08:50 +01:00
interfaces
mining: add interrupt()
2026-02-20 16:49:52 +01:00
ipc
test: refactor, decouple HasReason from test framework machinery
2026-02-26 11:28:55 -03:00
kernel
Merge bitcoin/bitcoin#34546: kernel: Avoid duplicating symbols in the kernel library
2026-02-13 11:11:14 +00:00
leveldb
Bump leveldb subtree
2026-02-03 11:19:01 +01:00
logging
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
minisketch
…
node
Merge bitcoin/bitcoin#34184: mining: add cooldown to createNewBlock() immediately after IBD
2026-02-24 06:54:17 -05:00
policy
Merge bitcoin/bitcoin#33616: policy: don't CheckEphemeralSpends on reorg
2026-02-25 17:38:13 +01:00
primitives
txgraph: pass fallback_order to TxGraph (preparation)
2026-02-09 15:55:58 -05:00
qt
qt: Update src/qt/locale/bitcoin_en.xlf after string freeze
2026-02-20 10:31:10 +00:00
rpc
Merge bitcoin/bitcoin#34184: mining: add cooldown to createNewBlock() immediately after IBD
2026-02-24 06:54:17 -05:00
script
Merge bitcoin/bitcoin#34141: miniscript: Use Func and Expr when parsing keys, hashes, and locktimes
2026-02-21 12:18:56 +01:00
secp256k1
Update secp256k1 subtree to latest master
2026-02-02 15:21:14 +00:00
support
kernel: avoid potential duplicate object in shared library/binary
2026-02-13 08:50:50 +01:00
test
Merge bitcoin/bitcoin#34562: ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
2026-02-26 12:44:11 -08:00
univalue
ci, iwyu: Fix warnings in src/univalue and treat them as errors
2026-01-31 10:41:50 +00:00
util
Merge bitcoin/bitcoin#34562: ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
2026-02-26 12:44:11 -08:00
wallet
Merge bitcoin/bitcoin#34562: ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
2026-02-26 12:44:11 -08:00
zmq
ci, iwyu: Fix warnings in src/zmq and treat them as errors
2026-01-29 14:38:35 +00:00
.clang-format
ci, iwyu: Fix warnings in src/zmq and treat them as errors
2026-01-29 14:38:35 +00:00
.clang-tidy
doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false
2026-02-06 08:37:19 +01:00
addrdb.cpp
…
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
addrman.cpp
refactor: Unify asmap version calculation and naming
2026-01-20 23:45:29 +01:00
addrman.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Add Handle/View pattern for BlockValidationState
2026-01-21 19:40:25 +05:30
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoin.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
…
blockencodings.cpp
log,blocks: avoid ComputeTotalSize and GetHash work when logging is disabled
2026-01-19 20:20:13 +01:00
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
chain.h
validation: remove BLOCK_FAILED_MASK
2026-02-17 21:40:46 +05:30
chainparams.cpp
…
chainparams.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsbase.cpp
…
chainparamsbase.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsseeds.h
…
checkqueue.h
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
clientversion.cpp
…
clientversion.h
…
cluster_linearize.h
clusterlin: adopt trained cost model (feature)
2026-02-24 12:05:17 -05:00
CMakeLists.txt
Merge bitcoin/bitcoin#24539: Add a "tx output spender" index
2026-02-20 09:27:17 +01:00
coins.cpp
util: introduce TrySub to prevent unsigned underflow
2026-02-23 15:56:25 +01:00
coins.h
util: introduce TrySub to prevent unsigned underflow
2026-02-23 15:56:25 +01:00
compressor.cpp
…
compressor.h
…
core_io.cpp
Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)
2026-02-09 13:32:28 +00:00
core_io.h
refactor: [move-only] Merge core_io module
2026-01-19 12:57:16 +01:00
core_memusage.h
…
cuckoocache.h
…
dbwrapper.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
dbwrapper.h
refactor: Use SpanReader over DataStream
2026-02-02 18:42:44 +01:00
deploymentinfo.cpp
…
deploymentinfo.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
external_signer.cpp
util: Remove brittle and confusing sp::Popen(std::string)
2026-02-17 12:55:26 +01:00
external_signer.h
util: Remove brittle and confusing sp::Popen(std::string)
2026-02-17 12:55:26 +01:00
flatfile.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
flatfile.h
…
hash.cpp
…
hash.h
…
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#34577: http: fix submission during shutdown race
2026-02-19 12:41:12 -08:00
httpserver.h
http: replace WorkQueue and threads handling for ThreadPool
2026-01-30 16:17:12 -05:00
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#29770: index: Check all necessary block data is available before starting to sync
2026-02-20 15:58:48 -08:00
init.h
…
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
logging: Move message formatting to util/log.h
2026-02-02 17:22:31 +00:00
logging.h
logging: Move message formatting to util/log.h
2026-02-02 17:22:31 +00:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
merkleblock.h
…
musig.cpp
…
musig.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#34054: net processing: Add ibd check before processing block for txdownloadman
2026-02-26 10:33:29 +00:00
net_processing.h
rpc: Add abortprivatebroadcast
2026-02-11 19:46:19 -05:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#34483: refactor: Use SpanReader over DataStream
2026-02-06 18:00:18 -08:00
net.h
Merge bitcoin/bitcoin#34511: test: fully reset the state of CConnman in tests
2026-02-13 11:17:26 +00:00
netaddress.cpp
…
netaddress.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
netbase.cpp
Modernize GetBindAddress()
2026-01-22 10:35:14 -05:00
netbase.h
Merge bitcoin/bitcoin#34242: Prepare string and net utils for future HTTP operations
2026-01-23 13:25:42 +01:00
netgroup.cpp
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netgroup.h
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netmessagemaker.h
…
noui.cpp
noui: Remove always empty caption while formatting
2026-01-14 19:39:01 +01:00
noui.h
refactor: Remove empty caption from ThreadSafeMessageBox
2026-01-14 19:36:14 +01:00
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
prevector.h
…
private_broadcast.cpp
net: Add PrivateBroadcast::GetBroadcastInfo
2026-02-11 19:46:12 -05:00
private_broadcast.h
net: Add PrivateBroadcast::GetBroadcastInfo
2026-02-11 19:46:12 -05:00
protocol.cpp
…
protocol.h
…
psbt.cpp
refactor: Use SpanReader over DataStream
2026-02-06 07:56:57 +01:00
psbt.h
refactor: Avoid copies by using const references or by move-construction
2026-01-14 23:03:47 +01:00
pubkey.cpp
…
pubkey.h
…
random.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
random.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
randomenv.cpp
…
randomenv.h
…
rest.cpp
Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2)
2026-02-09 13:32:28 +00:00
rest.h
…
scheduler.cpp
…
scheduler.h
…
semaphore_grant.h
…
serialize.h
refactor: Use empty() over eof() in the streams interface
2026-02-02 17:55:10 +01:00
signet.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
signet.h
…
span.h
…
streams.cpp
…
streams.h
Merge bitcoin/bitcoin#34465: refactor: separate log generation from log handling
2026-02-07 23:01:17 +01:00
sync.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
sync.h
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
threadsafety.h
…
tinyformat.h
…
torcontrol.cpp
refactor: Use std::bind_front over std::bind
2026-01-20 15:30:46 +01:00
torcontrol.h
…
txdb.cpp
validation: Use dirty entry count in flush warnings and disk space checks
2026-02-08 08:23:37 +01:00
txdb.h
Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void
2026-01-02 16:49:23 -08:00
txgraph.cpp
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txgraph.h
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txmempool.cpp
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txmempool.h
clusterlin: rescale costs (preparation)
2026-02-24 10:45:49 -05:00
txrequest.cpp
…
txrequest.h
doc: fix double-word typos in comments
2025-12-30 12:12:26 -08:00
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#33616: policy: don't CheckEphemeralSpends on reorg
2026-02-25 17:38:13 +01:00
validation.h
mining: add cooldown argument to createNewBlock()
2026-02-20 16:49:15 +01:00
validationinterface.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
validationinterface.h
…
versionbits_impl.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…