mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 13:42:10 +02:00
Using `&&` in `BOOST_CHECK` is problematic as failures will not indicate which condition failed. By unrolling these checks, the user knows exactly which expression is the failing case. As an example, here is a line that would be particularly hard to debug if it failed: ``` src/test/net_tests.cpp BOOST_CHECK((*ret)[1] && (*ret)[1]->m_type == "headers" && std::ranges::equal((*ret)[1]->m_recv, MakeByteSpan(msg_data_2))); ``` If any one of these conditions fail, the whole expression fails, with no values printed or indication as to which condition failed. This is also required when using test macros that support value decomposition, which requires `&&` and `||` are `delete`. Examples include `BOOST_TEST`, doctest, Catch2, etc. ref: https://catch2-temp.readthedocs.io/en/latest/assertions.html#other-limitations ref: https://fekir.info/post/decomposing-an-expression/
217 lines
7.9 KiB
C++
217 lines
7.9 KiB
C++
// Copyright (c) 2012-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <random.h>
|
|
#include <scheduler.h>
|
|
#include <util/time.h>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
#include <functional>
|
|
#include <mutex>
|
|
#include <thread>
|
|
#include <vector>
|
|
|
|
BOOST_AUTO_TEST_SUITE(scheduler_tests)
|
|
|
|
static void microTask(CScheduler& s, std::mutex& mutex, int& counter, int delta, std::chrono::steady_clock::time_point rescheduleTime)
|
|
{
|
|
{
|
|
std::lock_guard<std::mutex> lock(mutex);
|
|
counter += delta;
|
|
}
|
|
auto noTime = std::chrono::steady_clock::time_point::min();
|
|
if (rescheduleTime != noTime) {
|
|
CScheduler::Function f = std::bind_front(µTask, std::ref(s), std::ref(mutex), std::ref(counter), -delta + 1, noTime);
|
|
s.schedule(f, rescheduleTime);
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(manythreads)
|
|
{
|
|
// Stress test: hundreds of microsecond-scheduled tasks,
|
|
// serviced by 10 threads.
|
|
//
|
|
// So... ten shared counters, which if all the tasks execute
|
|
// properly will sum to the number of tasks done.
|
|
// Each task adds or subtracts a random amount from one of the
|
|
// counters, and then schedules another task 0-1000
|
|
// microseconds in the future to subtract or add from
|
|
// the counter -random_amount+1, so in the end the shared
|
|
// counters should sum to the number of initial tasks performed.
|
|
CScheduler microTasks;
|
|
|
|
std::mutex counterMutex[10];
|
|
int counter[10] = { 0 };
|
|
FastRandomContext rng{/*fDeterministic=*/true};
|
|
auto zeroToNine = [](FastRandomContext& rc) -> int { return rc.randrange(10); }; // [0, 9]
|
|
auto randomMsec = [](FastRandomContext& rc) -> int { return -11 + (int)rc.randrange(1012); }; // [-11, 1000]
|
|
auto randomDelta = [](FastRandomContext& rc) -> int { return -1000 + (int)rc.randrange(2001); }; // [-1000, 1000]
|
|
|
|
auto start = std::chrono::steady_clock::now();
|
|
auto now = start;
|
|
std::chrono::steady_clock::time_point first, last;
|
|
size_t nTasks = microTasks.getQueueInfo(first, last);
|
|
BOOST_CHECK(nTasks == 0);
|
|
|
|
for (int i = 0; i < 100; ++i) {
|
|
auto t = now + std::chrono::microseconds(randomMsec(rng));
|
|
auto tReschedule = now + std::chrono::microseconds(500 + randomMsec(rng));
|
|
int whichCounter = zeroToNine(rng);
|
|
CScheduler::Function f = std::bind_front(µTask, std::ref(microTasks),
|
|
std::ref(counterMutex[whichCounter]), std::ref(counter[whichCounter]),
|
|
randomDelta(rng), tReschedule);
|
|
microTasks.schedule(f, t);
|
|
}
|
|
nTasks = microTasks.getQueueInfo(first, last);
|
|
BOOST_CHECK(nTasks == 100);
|
|
BOOST_CHECK(first < last);
|
|
BOOST_CHECK(last > now);
|
|
|
|
// As soon as these are created they will start running and servicing the queue
|
|
std::vector<std::thread> microThreads;
|
|
microThreads.reserve(10);
|
|
for (int i = 0; i < 5; i++)
|
|
microThreads.emplace_back(std::bind_front(&CScheduler::serviceQueue, µTasks));
|
|
|
|
UninterruptibleSleep(std::chrono::microseconds{600});
|
|
now = std::chrono::steady_clock::now();
|
|
|
|
// More threads and more tasks:
|
|
for (int i = 0; i < 5; i++)
|
|
microThreads.emplace_back(std::bind_front(&CScheduler::serviceQueue, µTasks));
|
|
for (int i = 0; i < 100; i++) {
|
|
auto t = now + std::chrono::microseconds(randomMsec(rng));
|
|
auto tReschedule = now + std::chrono::microseconds(500 + randomMsec(rng));
|
|
int whichCounter = zeroToNine(rng);
|
|
CScheduler::Function f = std::bind_front(µTask, std::ref(microTasks),
|
|
std::ref(counterMutex[whichCounter]), std::ref(counter[whichCounter]),
|
|
randomDelta(rng), tReschedule);
|
|
microTasks.schedule(f, t);
|
|
}
|
|
|
|
// Drain the task queue then exit threads
|
|
microTasks.StopWhenDrained();
|
|
// wait until all the threads are done
|
|
for (auto& thread: microThreads) {
|
|
if (thread.joinable()) thread.join();
|
|
}
|
|
|
|
int counterSum = 0;
|
|
for (int i = 0; i < 10; i++) {
|
|
BOOST_CHECK(counter[i] != 0);
|
|
counterSum += counter[i];
|
|
}
|
|
BOOST_CHECK_EQUAL(counterSum, 200);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(wait_until_past)
|
|
{
|
|
std::condition_variable condvar;
|
|
Mutex mtx;
|
|
WAIT_LOCK(mtx, lock);
|
|
|
|
const auto no_wait = [&](const std::chrono::seconds& d) {
|
|
return condvar.wait_until(lock, std::chrono::steady_clock::now() - d);
|
|
};
|
|
|
|
BOOST_CHECK(std::cv_status::timeout == no_wait(std::chrono::seconds{1}));
|
|
BOOST_CHECK(std::cv_status::timeout == no_wait(std::chrono::minutes{1}));
|
|
BOOST_CHECK(std::cv_status::timeout == no_wait(std::chrono::hours{1}));
|
|
BOOST_CHECK(std::cv_status::timeout == no_wait(std::chrono::hours{10}));
|
|
BOOST_CHECK(std::cv_status::timeout == no_wait(std::chrono::hours{100}));
|
|
BOOST_CHECK(std::cv_status::timeout == no_wait(std::chrono::hours{1000}));
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(singlethreadedscheduler_ordered)
|
|
{
|
|
CScheduler scheduler;
|
|
|
|
// each queue should be well ordered with respect to itself but not other queues
|
|
SerialTaskRunner queue1(scheduler);
|
|
SerialTaskRunner queue2(scheduler);
|
|
|
|
// create more threads than queues
|
|
// if the queues only permit execution of one task at once then
|
|
// the extra threads should effectively be doing nothing
|
|
// if they don't we'll get out of order behaviour
|
|
std::vector<std::thread> threads;
|
|
threads.reserve(5);
|
|
for (int i = 0; i < 5; ++i) {
|
|
threads.emplace_back([&] { scheduler.serviceQueue(); });
|
|
}
|
|
|
|
// these are not atomic, if SerialTaskRunner prevents
|
|
// parallel execution at the queue level no synchronization should be required here
|
|
int counter1 = 0;
|
|
int counter2 = 0;
|
|
|
|
// just simply count up on each queue - if execution is properly ordered then
|
|
// the callbacks should run in exactly the order in which they were enqueued
|
|
for (int i = 0; i < 100; ++i) {
|
|
queue1.insert([i, &counter1]() {
|
|
bool expectation = i == counter1++;
|
|
assert(expectation);
|
|
});
|
|
|
|
queue2.insert([i, &counter2]() {
|
|
bool expectation = i == counter2++;
|
|
assert(expectation);
|
|
});
|
|
}
|
|
|
|
// finish up
|
|
scheduler.StopWhenDrained();
|
|
for (auto& thread: threads) {
|
|
if (thread.joinable()) thread.join();
|
|
}
|
|
|
|
BOOST_CHECK_EQUAL(counter1, 100);
|
|
BOOST_CHECK_EQUAL(counter2, 100);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(mockforward)
|
|
{
|
|
CScheduler scheduler;
|
|
|
|
int counter{0};
|
|
CScheduler::Function dummy = [&counter]{counter++;};
|
|
|
|
// schedule jobs for 2, 5 & 8 minutes into the future
|
|
|
|
scheduler.scheduleFromNow(dummy, std::chrono::minutes{2});
|
|
scheduler.scheduleFromNow(dummy, std::chrono::minutes{5});
|
|
scheduler.scheduleFromNow(dummy, std::chrono::minutes{8});
|
|
|
|
// check taskQueue
|
|
std::chrono::steady_clock::time_point first, last;
|
|
size_t num_tasks = scheduler.getQueueInfo(first, last);
|
|
BOOST_CHECK_EQUAL(num_tasks, 3ul);
|
|
|
|
std::thread scheduler_thread([&]() { scheduler.serviceQueue(); });
|
|
|
|
// bump the scheduler forward 5 minutes
|
|
scheduler.MockForward(std::chrono::minutes{5});
|
|
|
|
// ensure scheduler has chance to process all tasks queued for before 1 ms from now.
|
|
scheduler.scheduleFromNow([&scheduler] { scheduler.stop(); }, std::chrono::milliseconds{1});
|
|
scheduler_thread.join();
|
|
|
|
// check that the queue only has one job remaining
|
|
num_tasks = scheduler.getQueueInfo(first, last);
|
|
BOOST_CHECK_EQUAL(num_tasks, 1ul);
|
|
|
|
// check that the dummy function actually ran
|
|
BOOST_CHECK_EQUAL(counter, 2);
|
|
|
|
// check that the time of the remaining job has been updated
|
|
auto now = std::chrono::steady_clock::now();
|
|
int delta = std::chrono::duration_cast<std::chrono::seconds>(first - now).count();
|
|
// should be between 2 & 3 minutes from now
|
|
BOOST_CHECK(delta > 2*60);
|
|
BOOST_CHECK(delta < 3*60);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|