Wladimir J. van der Laan 31145a3d7c Merge #13480: Avoid copies in range-for loops and add a warning to detect them ...

d92204c900 build: add warning to detect hidden copies in range-for loops (Cory Fields)
466e16e0e8 cleanup: avoid hidden copies in range-for loops (Cory Fields)

Pull request description:

  Following-up on #13241, which was itself a follow-up of #12169.

  See title. Fixing these would otherwise be a continuous process, adding the warning should keep them from cropping up.

  Note that the warning seems to be Clang-only for now.

Tree-SHA512: ccfb769c3128b3f92c95715abcf21ee2496fe2aa384f80efead1529a28eeb56b98995b531b49a089f8142601389e63f7bb935963d724eacde4f5e1b4a024934b

2018-06-24 16:36:40 +02:00

..

blockchain.cpp

cleanup: avoid hidden copies in range-for loops

2018-06-15 13:40:00 -04:00

blockchain.h

Drop the chain argument to GetDifficulty

2018-05-20 22:19:42 -07:00

client.cpp

Merge #13060: [wallet] [rpc] Remove getlabeladdress RPC

2018-06-11 15:21:24 +02:00

client.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

mining.cpp

Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock

2018-06-19 09:25:17 +02:00

mining.h

scripted-diff: Replace #include "" with #include <> (ryanofsky)

2017-11-16 08:23:01 +13:00

misc.cpp

Make it clear which functions that are intended to be translation unit local

2018-05-03 21:47:40 +02:00

net.cpp

scripted-diff: Avoid temporary copies when looping over std::map

2018-06-11 13:12:55 -07:00

protocol.cpp

scripted-diff: Use UniValue.pushKV instead of push_back(Pair())

2018-02-10 10:05:07 -05:00

protocol.h

rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section

2018-04-27 09:19:09 +02:00

rawtransaction.cpp

Merge #13269: refactoring: Drop UpdateTransaction in favor of UpdateInput

2018-06-05 19:06:16 +02:00

rawtransaction.h

Declare CMutableTransaction a struct in rawtransaction.h

2018-02-20 14:16:37 -08:00

register.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

server.cpp

Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}

2018-05-14 08:46:54 -04:00

server.h

Merge #12757: Clarify include guard naming convention

2018-04-01 18:30:21 -04:00

util.cpp

Merge #12542: Remove redundant includes. Conform to header include guidelines.

2018-03-16 16:59:27 -07:00

util.h

Remove redundant includes. Conform to header include guidelines.

2018-02-27 22:30:40 +01:00