merge-script 2d380aee43 Merge bitcoin/bitcoin#34243: doc: validation: fix PackageMempoolChecks incorrect comment ...

7fc465ece8 doc: fix incorrect description of `PackageMempoolChecks` (ismaelsadeeq)
1412b779ad refactor: execute `PackageMempoolChecks` during package rbf only (ismaelsadeeq)

Pull request description:

  This is a simple PR that fixes the incorrect description of what is done in `PackageMempoolChecks`

  >  // Enforce package mempool ancestor/descendant limits (distinct from individual
  > // ancestor/descendant limits done in PreChecks) and run Package RBF checks.

  After cluster mempool, we no longer enforce ancestor/descendant limits in both `PreChecks` and  `PackageMempoolChecks`; instead, cluster limit is enforced in `PackageMempoolChecks`.
   This PR fixes the incorrect comment  by;
     - Making it clear why it is necessary to have two calls of  `CheckMempoolPolicyLimts` in both `PackageMempoolChecks` and after in `AcceptMultipleTransactionsInternal` by executing `PackageMempoolChecks` only during package RBF only. No need to jump into the next subroutine when there is no conflict.
     - Renames `PackageMempoolChecks` to `PackageRBFChecks`; the method name is self-explanatory now, hence no need for a description comment.

ACKs for top commit:
  yashbhutwala:
    ACK 7fc465ece8
  instagibbs:
    ACK 7fc465ece8
  glozow:
    utACK 7fc465ece8

Tree-SHA512: 38655f9d05be54cadd224fad376da9871a85efc7801306b58d4f51aee658036cdce2ab406143a3439d7211fc9bb0fc86bd330852e8926d79660944872b8fae8d

2026-01-14 16:31:15 +00:00

..

bench

Merge bitcoin/bitcoin#33142: test: Run bench sanity checks in parallel with functional tests

2026-01-05 15:47:49 -08:00

common

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

compat

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

consensus

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crc32c

…

crypto

Merge bitcoin/bitcoin#33810: ci: Add IWYU job

2025-12-22 17:38:50 +00:00

index

Merge bitcoin/bitcoin#32997: index: Deduplicate HashKey / HeightKey handling

2025-12-27 16:18:34 +00:00

init

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

interfaces

Merge bitcoin/bitcoin#33819: mining: getCoinbase() returns struct instead of raw tx

2026-01-13 08:01:57 -05:00

ipc

Merge bitcoin/bitcoin#33819: mining: getCoinbase() returns struct instead of raw tx

2026-01-13 08:01:57 -05:00

kernel

Merge bitcoin/bitcoin#33891: kernel: Expose reusable PrecomputedTransactionData in script validation

2025-12-27 16:20:43 +00:00

leveldb

Update leveldb subtree to latest master

2025-10-16 13:49:49 +01:00

logging

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

minisketch

Update minisketch subtree to latest upstream

2025-10-13 12:33:23 +01:00

node

Merge bitcoin/bitcoin#33819: mining: getCoinbase() returns struct instead of raw tx

2026-01-13 08:01:57 -05:00

policy

Merge bitcoin/bitcoin#34109: refactor: Use uint64_t over size_t for serialize corruption check in fees.dat

2026-01-14 09:18:36 +00:00

primitives

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

qt

Merge bitcoin/bitcoin#34224: init: Return EXIT_SUCCESS on interrupt

2026-01-13 15:23:12 -08:00

rpc

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

script

Merge bitcoin/bitcoin#33135: wallet: warn against accidental unsafe older() import

2026-01-02 16:15:50 -08:00

secp256k1

Update secp256k1 subtree to latest master

2025-10-15 09:49:11 +01:00

support

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

test

Merge bitcoin/bitcoin#34145: test: Add unit test for OP_NUMEQUALVERIFY

2026-01-14 16:15:57 +00:00

univalue

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

util

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

wallet

Merge bitcoin/bitcoin#34230: fuzz: Reject too large descriptor leaf sizes in scriptpubkeyman target

2026-01-13 15:28:25 -08:00

zmq

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

.clang-format

iwyu, clang-format: Sort includes

2025-12-17 20:29:36 +00:00

.clang-tidy

refactor: enable readability-container-contains clang-tidy rule

2025-12-18 22:38:02 +01:00

addrdb.cpp

…

addrdb.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addresstype.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addresstype.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addrman_impl.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addrman.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

addrman.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

arith_uint256.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

arith_uint256.h

refactor(headerssync): Extract test constants ahead of breakup into functions

2025-09-12 22:28:41 +02:00

attributes.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

banman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bip324.cpp

…

bip324.h

…

bitcoin-chainstate.cpp

kernel: revert accidentally removed copyright header

2025-12-18 16:07:31 +01:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

bitcoin-res.rc

…

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

bitcoin-util-res.rc

…

bitcoin-util.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

Remove no longer necessary WinCmdLineArgs class

2025-10-06 19:41:35 +01:00

bitcoin.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bitcoind-res.rc

…

bitcoind.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockencodings.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockencodings.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockfilter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockfilter.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chain.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chain.h

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

chainparams.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chainparams.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chainparamsbase.cpp

…

chainparamsbase.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chainparamsseeds.h

contrib: update fixed seeds

2025-09-03 11:23:30 +01:00

checkqueue.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

clientversion.cpp

refactor: Avoid -W*-whitespace in git archive

2025-11-13 09:33:36 +01:00

clientversion.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cluster_linearize.h

clusterlin: remove unused FixLinearization (cleanup)

2026-01-05 11:48:34 -05:00

CMakeLists.txt

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

coins.cpp

Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void

2026-01-02 16:49:23 -08:00

coins.h

refactor: Let CCoinsViewCache::BatchWrite return void

2025-12-14 22:25:31 +01:00

compressor.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

compressor.h

…

core_io.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

core_memusage.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

core_read.cpp

kernel: Remove some unnecessary non-kernel includes

2025-12-21 10:24:09 +01:00

core_write.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cuckoocache.h

…

dbwrapper.cpp

refactor: Add Chainstate::StoragePath() method

2025-12-12 06:49:59 -04:00

dbwrapper.h

refactor: Add Chainstate::StoragePath() method

2025-12-12 06:49:59 -04:00

deploymentinfo.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

deploymentinfo.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

deploymentstatus.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

deploymentstatus.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

dummywallet.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

external_signer.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

external_signer.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

flatfile.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

flatfile.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

hash.cpp

…

hash.h

…

headerssync.cpp

headerssync: Make HeadersSyncState more flexible and move constants

2025-09-12 22:28:41 +02:00

headerssync.h

headerssync: Make HeadersSyncState more flexible and move constants

2025-09-12 22:28:41 +02:00

httprpc.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

httprpc.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

httpserver.cpp

libevent: separate log statements per level

2025-12-13 12:48:27 +01:00

httpserver.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

i2p.cpp

log: Remove brittle and confusing LogPrintLevel

2025-12-13 13:43:24 +01:00

i2p.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

indirectmap.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

init.cpp

Merge bitcoin/bitcoin#34224: init: Return EXIT_SUCCESS on interrupt

2026-01-13 15:23:12 -08:00

init.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

key_io.cpp

…

key_io.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

key.cpp

Merge bitcoin/bitcoin#29675: wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys

2025-10-14 16:25:52 -04:00

key.h

sign: Add CreateMuSig2PartialSig

2025-09-30 11:06:43 -07:00

logging.cpp

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

logging.h

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

mapport.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

mapport.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

memusage.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

merkleblock.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

merkleblock.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

musig.cpp

musig: Move MUSIG_CHAINCODE to musig.cpp

2025-11-24 18:48:43 +01:00

musig.h

musig: Move MUSIG_CHAINCODE to musig.cpp

2025-11-24 18:48:43 +01:00

net_permissions.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_permissions.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_processing.cpp

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

net_processing.h

net_processing: retry private broadcast

2025-12-16 17:53:50 +01:00

net_types.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_types.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net.cpp

Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections

2026-01-12 15:02:14 -05:00

net.h

net: implement opening PRIVATE_BROADCAST connections

2025-12-16 17:53:42 +01:00

netaddress.cpp

refactor: increase string_view usage

2025-10-02 12:53:55 +01:00

netaddress.h

refactor: Remove all operator!= definitions

2025-11-03 14:39:48 +01:00

netbase.cpp

Merge bitcoin/bitcoin#34033: scripted-diff: Unify error and warning log formatting

2025-12-11 09:00:18 -08:00

netbase.h

refactor: unify container presence checks - trivial counts

2025-12-03 13:36:58 +01:00

netgroup.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netgroup.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netmessagemaker.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

noui.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

noui.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

outputtype.cpp

refactor: increase string_view usage

2025-10-02 12:53:55 +01:00

outputtype.h

refactor: increase string_view usage

2025-10-02 12:53:55 +01:00

pow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

pow.h

…

prevector.h

refactor: Prefer <=> over multiple relational operators

2025-11-03 14:39:50 +01:00

private_broadcast.cpp

net_processing: retry private broadcast

2025-12-16 17:53:50 +01:00

private_broadcast.h

net_processing: retry private broadcast

2025-12-16 17:53:50 +01:00

protocol.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

protocol.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

psbt.cpp

psbt: Fix PSBTInputSignedAndVerified bounds assert

2026-01-13 12:58:53 +01:00

psbt.h

Merge bitcoin/bitcoin#34010: psbt: detect invalid MuSig2 pubkeys in deserialization

2026-01-05 14:56:25 -08:00

pubkey.cpp

pubkey: Return tweaks from BIP32 derivation

2025-09-30 11:06:09 -07:00

pubkey.h

refactor: Remove all operator!= definitions

2025-11-03 14:39:48 +01:00

random.cpp

…

random.h

…

randomenv.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

randomenv.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

rest.cpp

rest: reformat uri_prefixes initializer list

2025-12-14 10:04:37 +01:00

rest.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

scheduler.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

scheduler.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

semaphore_grant.h

…

serialize.h

refactor: Return uint64_t from GetSerializeSize

2025-10-30 17:51:53 +01:00

signet.cpp

kernel: Remove some unnecessary non-kernel includes

2025-12-21 10:24:09 +01:00

signet.h

kernel: Remove some unnecessary non-kernel includes

2025-12-21 10:24:09 +01:00

span.h

…

streams.cpp

refactor: Add AutoFile::size

2025-11-14 01:17:38 +02:00

streams.h

refactor: Add AutoFile::size

2025-11-14 01:17:38 +02:00

sync.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

sync.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

threadsafety.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

tinyformat.h

…

torcontrol.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

torcontrol.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

txdb.cpp

Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void

2026-01-02 16:49:23 -08:00

txdb.h

Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void

2026-01-02 16:49:23 -08:00

txgraph.cpp

txgraph: permit non-topological clusters to defer fixing (optimization)

2026-01-05 11:48:30 -05:00

txgraph.h

txgraph: drop move assignment operator

2025-11-25 07:36:50 -05:00

txmempool.cpp

Fix compilation for old Boost versions

2025-12-18 22:38:02 +01:00

txmempool.h

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

txrequest.cpp

Fix compilation for old Boost versions

2025-12-18 22:38:02 +01:00

txrequest.h

doc: fix double-word typos in comments

2025-12-30 12:12:26 -08:00

uint256.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

uint256.h

refactor: Remove all operator!= definitions

2025-11-03 14:39:48 +01:00

undo.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

validation.cpp

doc: fix incorrect description of PackageMempoolChecks

2026-01-13 18:52:44 +00:00

validation.h

test: Wrap validation functions with TestChainstateManager

2025-12-16 11:25:46 -05:00

validationinterface.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

validationinterface.h

refactor: Convert ChainstateRole enum to struct

2025-12-12 06:49:59 -04:00

versionbits_impl.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

versionbits.cpp

Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers

2025-12-19 16:56:02 +00:00

versionbits.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

walletinitinterface.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00