MarcoFalke d0bf9bb6a5 Merge bitcoin/bitcoin#23373: test: Parse command line arguments from unit and fuzz tests, make addrman consistency check ratio easier to change ...

7f122a4188 fuzz: non-addrman fuzz tests: override-able check ratio (Vasil Dimov)
3bd83e273d fuzz: addrman fuzz tests: override-able check ratio (Vasil Dimov)
46b0fe7829 test: non-addrman unit tests: override-able check ratio (Vasil Dimov)
81e4d54d3a test: addrman unit tests: override-able check ratio (Vasil Dimov)
6dff6214be bench: put addrman check ratio in a variable (Vasil Dimov)
6f7c7567c5 fuzz: parse the command line arguments in fuzz tests (Vasil Dimov)
92a0f7e58d test: parse the command line arguments in unit tests (Vasil Dimov)

Pull request description:

  Previously command line arguments passed to unit and fuzz tests would be ignored by the tests themselves. They would be used by the boost test framework (e.g. `--run_test="addrman_tests/*"`) or by the fuzzer (e.g. `-runs=1`). However both provide ways to pass down the extra arguments to the test itself. Use that, parse the arguments and make them available to the tests via `gArgs`.

  This makes the tests more flexible as they can be run with any bitcoind config option specified on the command line.

  When creating `AddrMan` objects in tests, use `-checkaddrman=` (if provided) instead of hardcoding the check ratio in many different places. See https://github.com/bitcoin/bitcoin/pull/20233#issuecomment-889813074 for further motivation for this.

ACKs for top commit:
  mzumsande:
    re-ACK 7f122a4188
  josibake:
    reACK 7f122a4188

Tree-SHA512: 3a05e61e4d70a0569bb67594bcce3aad8fdef63cdcc54e2823a3bc9f18679571985004412b6c332a210f67849bab32d8467b4115fbff8f5fac9834982e60dcf3

2022-01-17 09:10:21 +01:00

..

addition_overflow.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

addrman.cpp

fuzz: addrman fuzz tests: override-able check ratio

2022-01-11 12:08:43 +01:00

asmap_direct.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

asmap.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

autofile.cpp

…

banman.cpp

…

base_encode_decode.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bech32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

block_header.cpp

…

block.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

blockfilter.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

checkqueue.cpp

…

coins_view.cpp

Remove cs_main lock annotation from ChainstateManager.m_blockman

2022-01-11 05:11:00 -05:00

connman.cpp

fuzz: non-addrman fuzz tests: override-able check ratio

2022-01-11 12:08:44 +01:00

crypto_aes256.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_aes256cbc.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_chacha20_poly1305_aead.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

Refactor the chacha20 differential fuzz test

2021-12-17 23:04:04 +05:30

crypto_hkdf_hmac_sha256_l32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

decode_tx.cpp

…

descriptor_parse.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

deserialize.cpp

fuzz: non-addrman fuzz tests: override-able check ratio

2022-01-11 12:08:44 +01:00

eval_script.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fee_rate.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fees.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

flatfile.cpp

…

float.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fuzz.cpp

fuzz: parse the command line arguments in fuzz tests

2022-01-11 11:53:34 +01:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

scripted-diff: rename MapIntoRange to FastRange64

2022-01-06 11:29:55 -05:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

Merge bitcoin/bitcoin#23411: refactor: Avoid integer overflow in ApplyStats when activating snapshot

2022-01-05 10:34:29 +01:00

key_io.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

key.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

merkleblock.cpp

…

message.cpp

…

minisketch.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

muhash.cpp

…

multiplication_overflow.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

net_permissions.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

net.cpp

…

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

p2p_transport_serialization.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_numbers.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_script.cpp

…

parse_univalue.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

policy_estimator_io.cpp

…

policy_estimator.cpp

…

pow.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

prevector.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

primitives_transaction.cpp

…

process_message.cpp

…

process_messages.cpp

…

protocol.cpp

…

psbt.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

random.cpp

…

rbf.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

rolling_bloom_filter.cpp

…

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script_flags.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

…

script_sign.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

util: Restore GetIntArg saturating behavior

2022-01-11 19:54:36 -05:00

strprintf.cpp

…

system.cpp

…

timedata.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

torcontrol.cpp

…

transaction.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

txrequest.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

util.cpp

fuzz: Limit fuzzed time to years 2000-2100

2022-01-10 11:15:38 +01:00

util.h

Merge bitcoin/bitcoin#21879: refactor: wrap accept() and extend usage of Sock

2022-01-05 15:32:53 +01:00

utxo_snapshot.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

validation_load_mempool.cpp

…

versionbits.cpp

…