mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 23:29:12 +01:00

Files

laanwj 6300b9556e Merge bitcoin/bitcoin#24357 : refactor: make setsockopt() and SetSocketNoDelay() mockable/testable

a2c4a7acd1 net: use Sock::SetSockOpt() instead of standalone SetSocketNoDelay() (Vasil Dimov)
d65b6c3fb9 net: use Sock::SetSockOpt() instead of setsockopt() (Vasil Dimov)
184e56d668 net: add new method Sock::SetSockOpt() that wraps setsockopt() (Vasil Dimov)

Pull request description:

  _This is a piece of #21878, chopped off to ease review._

  Add a `virtual` (thus mockable) method `Sock::SetSockOpt()` that wraps the system `setsockopt()`.

  Convert the standalone `SetSocketNoDelay()` function to a `virtual` (thus mockable) method `Sock::SetNoDelay()`.

  This will help avoid syscalls during testing and to mock them to return whatever is suitable for the tests.

ACKs for top commit:
  laanwj:
    Code review ACK a2c4a7acd1
  jonatack:
    ACK a2c4a7acd1 change since last review is folding `Sock::SetNoDelay()` into the callers

Tree-SHA512: 3e2b016c1e4128317a28c17dc9b30472949e1ac3b071b2697c6d30cbcc830df1ee4392a4e23b2ea1ab4e3fb0f59ef450e2a4f3c1df3d8c803dd081652b6c7387

2022-04-19 16:43:47 +02:00

blockfilter.cpp

Require CBlockIndex::GetBlockPos() to hold mutex cs_main

2022-01-25 20:43:12 +01:00

blockfilter.h

scripted-diff: test: Move setup_common to test library

2019-11-06 11:56:41 -05:00

chainstate.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

logging.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

logging.h

util, refactor: Add UNIQUE_NAME helper macro

2022-02-16 14:59:20 +02:00

mining.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

mining.h

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

net.cpp

scripted-diff: rename TxRelay members

2022-03-18 11:35:58 +00:00

net.h

net: add new method Sock::SetSockOpt() that wraps setsockopt()

2022-04-15 09:14:49 +02:00

README.md

doc: Add documentation for new test/lib

2019-11-06 11:56:53 -05:00

script.cpp

fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target

2021-03-30 10:42:45 +02:00

script.h

fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target

2021-03-30 10:42:45 +02:00

setup_common.cpp

test: fix connman UB by calling derived constructor

2022-04-16 11:16:32 +08:00

setup_common.h

test: parse the command line arguments in unit tests

2022-01-11 11:53:30 +01:00

str.cpp

tests: Move CaseInsensitiveEqual to test/util/str

2019-11-05 09:23:44 +00:00

str.h

[test] move string helper functions into test library

2019-11-25 01:33:17 +01:00

transaction_utils.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

transaction_utils.h

scripted-diff: TxoutType C++11 scoped enum class

2020-06-21 06:41:55 -04:00

validation.cpp

Add coinstatsindex_unclean_shutdown test

2022-02-25 16:06:27 -05:00

validation.h

Add coinstatsindex_unclean_shutdown test

2022-02-25 16:06:27 -05:00

wallet.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

wallet.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).