Ava Chow fbabe86190 Merge bitcoin/bitcoin#34870: wallet: feebumper, fix crash when combined bump fee is unavailable ...

6072a2a6a1 wallet: feebumper, fix crash when combined bump fee is unavailable (furszy)

Pull request description:

  When a large cluster of unconfirmed transactions exceeds the limit,
  `calculateCombinedBumpFee()` returns `std::nullopt`.

  Previously, we continued executing and the optional value was
  accessed unconditionally, leading to a `std::bad_optional_access`
  exception (https://en.cppreference.com/w/cpp/utility/optional/value.html).

  Fix this by returning early when the bumped fee is null.

  Note:
  This is a crash for the GUI, and an uncaught exception for the RPC
  `bumpfee` and `psbtbumpfee`.

ACKs for top commit:
  achow101:
    ACK 6072a2a6a1
  luke-jr:
    utACK 6072a2a6a1
  rkrux:
    crACK 6072a2a6a1 based on returning before accessing the null optional.

Tree-SHA512: f863ace1426b2e743e2281e5c624b523de7317c1f305f88f369e77d60005460e4af58b424bc784304fd1ac30a3bfa575137537ec334fa6e449c827daeb262a99

2026-03-23 17:51:23 -07:00

..

rpc

Merge bitcoin/bitcoin#34684: refactor: Enable -Wswitch in exhaustive switch'es, Enable -Wcovered-switch-default

2026-03-19 14:15:38 -07:00

test

Merge bitcoin/bitcoin#32624: fuzz: wallet: add target for MigrateToDescriptor

2026-03-19 13:40:32 +01:00

CMakeLists.txt

cmake: Migrate away from deprecated SQLite3 target

2026-03-18 11:51:42 +01:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

refactor: Enable -Wswitch in exhaustive switch

2026-03-13 09:02:09 +01:00

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

wallet: feebumper, fix crash when combined bump fee is unavailable

2026-03-19 15:10:54 -04:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

…

load.cpp

…

load.h

…

migrate.cpp

…

migrate.h

…

receive.cpp

…

receive.h

…

scriptpubkeyman.cpp

…

scriptpubkeyman.h

…

spend.cpp

wallet: fix amount computed as boolean in coin selection

2026-03-21 21:13:01 -04:00

spend.h

…

sqlite.cpp

…

sqlite.h

…

transaction.cpp

…

transaction.h

…

types.h

…

wallet.cpp

Merge bitcoin/bitcoin#31774: crypto: Use secure_allocator for AES256_ctx

2026-03-13 13:34:35 -07:00

wallet.h

refactor: Enable -Wswitch in exhaustive switch

2026-03-13 09:02:09 +01:00

walletdb.cpp

Merge bitcoin/bitcoin#34301: wallet: remove outdated RewriteDB calls from SPKM & DBErrors::NEED_REWRITE enum value

2026-03-11 13:57:33 +01:00

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…