mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-09 08:43:04 +01:00
11f68cc810
95a0104f2etest: Add tests for directories in place of config files (Hodlinator)e85abe92c7args: Catch directories in place of config files (Hodlinator)e4b6b1822ctest: Add tests for -noconf (Hodlinator)483f0dacc4args: Properly support -noconf (Hodlinator)312ec64cc0test refactor: feature_config_args.py - Stop nodes at the end of tests, not at the beginning (Hodlinator)7402658bc2test: -norpccookiefile (Hodlinator)39cbd4f37cargs: Support -norpccookiefile for bitcoind and bitcoin-cli (Hodlinator)e82ad88452logs: Use correct path and more appropriate macros in cookie-related code (Hodlinator)6e28c76907test: Harden testing of cookie file existence (Hodlinator)75bacabb55test: combine_logs.py - Output debug.log paths on error (Hodlinator)bffd92f00fargs: Support -nopid (Hodlinator)12f8d848fdargs: Disallow -nodatadir (Hodlinator)6ff9662760scripted-diff: Avoid printing version information for -noversion (Hodlinator)e8a2054edcdoc args: Document narrow scope of -color (Hodlinator) Pull request description: - Document `-color` as only applying to `-getinfo`, to be less confusing for bitcoin-cli users. - No longer print version information when getting passed `-noversion`. - Disallow `-nodatadir` as we cannot run without one. It was previously interpreted as a mix of unset and as a relative path of "0". - Support `-norpccookiefile` - Support `-nopid` - Properly support `-noconf` (instead of working by accident). Also detect when directories are specified instead of files. Prompted by investigation in https://github.com/bitcoin/bitcoin/pull/16545#pullrequestreview-2316714013. ACKs for top commit: l0rinc: utACK95a0104f2eachow101: ACK95a0104f2eryanofsky: Code review ACK95a0104f2e. Looks good! Thanks for all your work on this breaking the changes down and making them simple. Tree-SHA512: 5174251e6b9196a9c6d135eddcb94130295c551bcfccc78e633d9e118ff91523b1be0d72828fb49603ceae312e6e1f8ee2651c6a2b9e0f195603a73a9a622785