highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-18 22:35:39 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
32d55e28af69ef09094ba921289bf4d1ad79905a
bitcoin/src
History
Hennadii Stepanov d2ac748e9e Merge bitcoin-core/gui#864: Crash fix, disconnect numBlocksChanged() signal during shutdown 
71656bdfaa gui: crash fix, disconnect numBlocksChanged() signal during shutdown (furszy)

Pull request description:

  Aiming to fix bitcoin-core/gui#862.

  The crash stems from the order of the shutdown procedure:
  We first unset the client model, then destroy the wallet controller—but we leave
  the internal wallet models (`m_wallets`) untouched for a brief period. As a result,
  there’s a point in time where views still have connected signals and access to
  wallet models that are not connected to any wallet controller.
  Now.. since the `clientModel` is only replaced with nullptr locally and not destroyed
  yet, signals like `numBlocksChanged` can still emit. Thus, when wallet views receive
  them, they see a non-null wallet model ptr, and proceed to call backend functions
  from a model that is being torn down.

  As the shutdown procedure begins by unsetting `clientModel` from all views. It’s safe
  to ignore events when `clientModel` is nullptr.

ACKs for top commit:
  maflcko:
    lgtm ACK 71656bdfaa
  pablomartin4btc:
    re-ACK 71656bdfaa
  hebasto:
    ACK 71656bdfaa, I have reviewed the code and it looks OK.

Tree-SHA512: e6a369c40aad8a5a3da64e92daa10250006f60c53feef353a5580e1bdb17fe8e1ad102abf5419ddeff1caa703b69ab634265ef3b9cfef87e9304f97bfdd2c4aa
2025-04-26 13:45:31 +01:00
..
bench
Merge bitcoin/bitcoin#31250: wallet: Disable creating and loading legacy wallets
2025-04-25 13:11:24 +01:00
common
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
compat
netbase: refactor CreateSock() to accept sa_family_t
2024-03-01 13:13:07 -05:00
consensus
Remove checkpoints
2025-03-13 11:13:13 +00:00
crc32c
Update crc32c subtree to latest upstream master
2024-02-27 18:28:19 +00:00
crypto
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
index
scripted-diff: rename block and undo functions for consistency
2025-01-09 15:17:02 +01:00
init
refactor: Avoid using IsArgSet() on -debug, -loglevel, and -vbparams list options
2025-02-13 12:30:15 -05:00
interfaces
Merge bitcoin/bitcoin#31785: Have createNewBlock() wait for tip, make rpc handle shutdown during long poll and wait methods
2025-04-14 14:39:57 -07:00
ipc
Merge commit 'a2f28e4be96e92079a219567cf20214996aefc53' as 'src/ipc/libmultiprocess'
2025-04-02 21:41:16 +08:00
kernel
Merge bitcoin/bitcoin#31910: qa: fix an off-by-one in utxo snapshot fuzz target and sanity check its snapshot data
2025-03-21 16:46:54 +08:00
leveldb
Update leveldb subtree to latest upstream
2025-03-17 15:59:05 +08:00
logging
scripted-diff: modernize outdated trait patterns - values
2025-02-21 10:43:01 +01:00
minisketch
Update minisketch subtree to latest master
2025-03-05 15:36:56 +00:00
node
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
policy
doc: Update comments for AreInputsStandard to match code
2025-03-26 18:58:02 +10:00
primitives
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
qt
Merge bitcoin-core/gui#864: Crash fix, disconnect numBlocksChanged() signal during shutdown
2025-04-26 13:45:31 +01:00
rpc
Merge bitcoin/bitcoin#31247: psbt: MuSig2 Fields
2025-04-18 16:44:33 -04:00
script
descriptors: Have GetPrivKey fill keys directly
2025-04-14 16:32:01 -07:00
secp256k1
Update secp256k1 subtree to v0.6.0
2024-11-04 14:59:46 -05:00
support
util: Add missing types in make_secure_unique
2024-12-10 21:51:48 +01:00
test
Merge bitcoin/bitcoin#32318: Fix failing util_time_GetTime test on Windows
2025-04-24 15:10:04 -07:00
univalue
Merge bitcoin/bitcoin#31904: refactor: modernize outdated trait patterns using helper aliases (C++14/C++17)
2025-03-17 13:10:10 +08:00
util
Merge bitcoin/bitcoin#32226: ci: switch to LLVM 20 in tidy job
2025-04-23 13:35:43 +01:00
wallet
Merge bitcoin/bitcoin#31250: wallet: Disable creating and loading legacy wallets
2025-04-25 13:11:24 +01:00
zmq
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
.clang-format
refactor: Print verbose serialize compiler error messages
2023-12-15 15:20:54 +01:00
.clang-tidy
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
addrdb.cpp
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
addrdb.h
…
addresstype.cpp
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addresstype.h
refactor: deduplicate anchor witness program bytes (0x4e,0x73)
2025-03-23 21:58:39 +01:00
addrman_impl.h
Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t
2024-09-20 12:55:22 -04:00
addrman.cpp
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
addrman.h
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
arith_uint256.cpp
Add a fuzz test for Num3072 multiplication and inversion
2025-01-09 10:11:46 -05:00
arith_uint256.h
arith_uint256: modernize comparison operators
2025-04-07 10:45:13 -04:00
attributes.h
…
banman.cpp
refactor: Delay translation of _() literals
2025-01-14 19:21:37 +01:00
banman.h
doc: banman: reference past vuln due to unbounded banlist
2025-02-12 15:10:28 -05:00
base58.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
base58.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
bech32.cpp
Split out bech32 separator char to header
2024-10-19 18:49:53 +02:00
bech32.h
Split out bech32 separator char to header
2024-10-19 18:49:53 +02:00
bip324.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
bip324.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
bitcoin-chainstate.cpp
Remove checkpoints
2025-03-13 11:13:13 +00:00
bitcoin-cli-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-cli.cpp
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
bitcoin-tx-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-tx.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-util-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-util.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-wallet-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-wallet.cpp
wallet: Remove wallettool salvage
2025-04-23 12:10:30 -07:00
bitcoind-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoind.cpp
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
blockencodings.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
blockencodings.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
blockfilter.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
blockfilter.h
…
chain.cpp
…
chain.h
Remove checkpoints
2025-03-13 11:13:13 +00:00
chainparams.cpp
refactor: Avoid using IsArgSet() on -signetseednode and -signetchallenge list options
2025-02-13 12:30:15 -05:00
chainparams.h
…
chainparamsbase.cpp
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsbase.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsseeds.h
seeds: update fixed dns seeds
2025-03-06 15:39:58 -06:00
checkqueue.h
Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
2024-12-03 18:02:37 -05:00
clientversion.cpp
refactor: Delay translation of _() literals
2025-01-14 19:21:37 +01:00
clientversion.h
scripted-diff: Clarify "user agent" variable name
2024-10-28 12:35:49 +00:00
cluster_linearize.h
clusterlin: add GetConnectedComponent
2025-03-27 15:48:44 -04:00
CMakeLists.txt
cmake: Support building with libmultiprocess subtree
2025-04-02 08:41:16 -05:00
coins.cpp
Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests
2024-12-04 14:09:05 -05:00
coins.h
coins, refactor: Remove direct GetFlags access
2024-12-02 13:52:34 +01:00
compressor.cpp
…
compressor.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
core_io.h
rpc: add getdescriptoractivity
2024-11-26 20:47:08 -05:00
core_memusage.h
…
core_read.cpp
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
core_write.cpp
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
cuckoocache.h
validation: Don't error if maxsigcachesize exceeds uint32::max
2024-07-04 22:35:29 +02:00
dbwrapper.cpp
refactor: Remove manual CDBBatch size estimation
2025-04-07 15:59:41 +02:00
dbwrapper.h
refactor: Remove manual CDBBatch size estimation
2025-04-07 15:59:41 +02:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
scripted-diff: modernize outdated trait patterns - types
2025-02-21 10:41:27 +01:00
deploymentstatus.h
…
dummywallet.cpp
wallet, test: Be able to always swap BDB endianness
2024-05-16 15:03:13 -04:00
external_signer.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
external_signer.h
…
flatfile.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
flatfile.h
refactor: Add FlatFileSeq member variables in BlockManager
2024-07-24 09:39:35 +02:00
hash.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
hash.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
headerssync.cpp
[headerssync] update headerssync config for v29
2025-03-04 14:23:18 -05:00
headerssync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
httprpc.cpp
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
httprpc.h
…
httpserver.cpp
Fix nonsensical -norpcbind and -norpcallowip behavior
2025-02-13 12:30:15 -05:00
httpserver.h
rpc: increase the defaults for -rpcthreads and -rpcworkqueue
2024-11-04 17:08:21 +01:00
i2p.cpp
refactor: starts/ends_with changes for clang-tidy 20
2025-04-22 13:16:54 +01:00
i2p.h
i2p: log errors properly according to their severity
2024-06-12 16:19:50 -03:00
indirectmap.h
…
init.cpp
net: Rename _randomize_credentials Proxy parameter to tor_stream_isolation
2025-04-01 20:18:59 +02:00
init.h
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
key_io.cpp
key: clear out secret data in DecodeExtKey
2024-10-27 15:38:54 +01:00
key_io.h
…
key.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
key.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
logging.cpp
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
logging.h
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
mapport.cpp
mapport: make ProcessPCP void
2024-11-04 14:19:40 -05:00
mapport.h
mapport: rename 'use_pcp' to 'enable'
2024-10-29 11:58:51 -04:00
memusage.h
memusage: Add DynamicUsage for std::string
2024-11-04 18:46:40 +01:00
merkleblock.cpp
[clang-tidy] Enable the misc-no-recursion check
2024-04-07 14:04:45 +01:00
merkleblock.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_permissions.cpp
util: move fees.h and error.h to common/messages.h
2024-05-16 10:16:08 -05:00
net_permissions.h
scripted-diff: modernize outdated trait patterns - types
2025-02-21 10:41:27 +01:00
net_processing.cpp
Merge bitcoin/bitcoin#31282: refactor: Make node_id a const& in RemoveBlockRequest
2025-04-14 14:22:56 -07:00
net_processing.h
refactor: Fix net_processing iwyu includes
2024-11-13 14:09:58 +01:00
net_types.cpp
rpc: avoid copying into UniValue
2024-05-20 16:48:19 +00:00
net_types.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net.cpp
Merge bitcoin/bitcoin#32073: net: Block v2->v1 transport downgrade if !fNetworkActive
2025-03-24 16:54:40 -04:00
net.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
netaddress.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
netaddress.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
netbase.cpp
Merge bitcoin/bitcoin#32176: net: Prevent accidental circuit sharing when using Tor stream isolation
2025-04-10 12:42:34 -04:00
netbase.h
net: Rename _randomize_credentials Proxy parameter to tor_stream_isolation
2025-04-01 20:18:59 +02:00
netgroup.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netgroup.h
net: Add continuous ASMap health check logging
2023-12-02 22:03:08 +01:00
netmessagemaker.h
refactor: NetMsg::Make() without nVersion
2023-11-20 14:02:27 +01:00
noui.cpp
node: Use log levels in noui_ThreadSafeMessageBox
2024-03-21 16:41:16 +01:00
noui.h
…
outputtype.cpp
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
outputtype.h
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
pow.cpp
fuzz: enable running fuzz test cases in Debug mode
2025-04-22 17:11:24 +10:00
pow.h
consensus: add DeriveTarget() to pow.h
2025-01-22 11:29:05 +01:00
prevector.h
prevector: avoid GCC bogus warnings in insert method
2024-09-11 17:41:26 +02:00
protocol.cpp
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
protocol.h
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
psbt.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
psbt.h
psbt: Implement un/ser of musig2 fields
2025-04-17 16:31:57 -07:00
pubkey.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
pubkey.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
random.cpp
Remove support for RNDR/RNDRRS for aarch64 on Linux
2025-04-11 08:11:41 +02:00
random.h
Merge bitcoin/bitcoin#31519: refactor: Use std::span over Span
2025-03-20 13:41:54 +08:00
randomenv.cpp
refactor: modernize remaining outdated trait patterns
2025-02-21 10:43:41 +01:00
randomenv.h
…
rest.cpp
Merge bitcoin/bitcoin#31583: rpc: add target to getmininginfo field and show next block info
2025-01-22 15:01:23 -05:00
rest.h
…
scheduler.cpp
scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner
2024-02-15 14:43:14 +01:00
scheduler.h
kernel: Remove dependency on CScheduler
2024-02-16 17:12:52 +01:00
serialize.h
Merge bitcoin/bitcoin#31519: refactor: Use std::span over Span
2025-03-20 13:41:54 +08:00
signet.cpp
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
signet.h
…
span.h
scripted-diff: Bump copyright headers after std::span changes
2025-03-12 19:46:54 +01:00
streams.cpp
optimization: bulk serialization writes in WriteBlockUndo and WriteBlock
2025-04-14 12:04:06 +02:00
streams.h
optimization: bulk serialization writes in WriteBlockUndo and WriteBlock
2025-04-14 12:04:06 +02:00
sync.cpp
scripted-diff: modernize outdated trait patterns - values
2025-02-21 10:43:01 +01:00
sync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
threadsafety.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
tinyformat.h
refactor: Introduce struct to hold a runtime format string
2025-01-15 12:16:08 +01:00
torcontrol.cpp
torcontrol: Fix addrOnion outdate comment
2025-04-16 19:59:52 +08:00
torcontrol.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
txdb.cpp
refactor: Remove manual CDBBatch size estimation
2025-04-07 15:59:41 +02:00
txdb.h
kernel: Move default cache constants to caches
2025-01-15 15:44:55 +01:00
txgraph.cpp
txgraph: make GroupClusters use partition numbers directly (optimization)
2025-04-11 10:43:56 -04:00
txgraph.h
Get*Union: disallow nulltpr Refs
2025-03-31 13:07:37 -04:00
txmempool.cpp
txmempool: fix typos in comments
2024-12-31 00:04:20 -03:00
txmempool.h
txmempool: fix typos in comments
2024-12-31 00:04:20 -03:00
txorphanage.cpp
[fuzz] TxOrphanage::SanityCheck accounting
2025-02-07 13:55:57 -05:00
txorphanage.h
[fuzz] TxOrphanage::SanityCheck accounting
2025-02-07 13:55:57 -05:00
txrequest.cpp
[refactor] make GetCandidatePeers take uint256 and in-out vector
2025-01-29 18:05:16 -05:00
txrequest.h
doc: txrequest: point to past censorship vulnerability in tx re-request handling
2025-02-12 15:10:28 -05:00
uint256.cpp
refactor: Remove SetHexDeprecated
2025-04-09 15:59:59 +01:00
uint256.h
refactor: Remove SetHexDeprecated
2025-04-09 15:59:59 +01:00
undo.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
validation.cpp
Merge bitcoin/bitcoin#31835: validation: set BLOCK_FAILED_CHILD correctly
2025-04-23 14:09:56 -07:00
validation.h
refactor: Use MockableSteadyClock in ReportHeadersPresync
2025-04-09 20:05:36 +02:00
validationinterface.cpp
refactor: include the proper header rather than forward-declaring RemovalReasonToString
2024-10-08 15:25:47 +00:00
validationinterface.h
[refactor] change ActiveTipChange to use CBlockIndex ref instead of ptr
2024-07-25 11:01:22 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00