fanquake 5a95c5179c Merge bitcoin/bitcoin#20191: wallet, refactor: make DescriptorScriptPubKeyMan agnostic of internal flag ...

181181019c refactor: remove m_internal from DescriptorSPKman (S3RK)

Pull request description:

  Rationale: improve consistency between `CWallet` and `DescriptorScriptPubKeyMan`; simplify `ScriptPubKeyMan` interface.

  Descriptor in itself is neither internal or external. It's responsibility of a wallet to assign and manage descriptors for a specific purpose. Duplicating information about internalness of a descriptor could lead to inconsistencies and unexpected behaviour (for example misreporting keypool size).

ACKs for top commit:
  instagibbs:
    reACK 181181019c
  achow101:
    reACK 181181019c

Tree-SHA512: d5613b7f6795b290bfa0fd8cb0536de1714d0cf72cba402266bd06d550758ebad690b54fc0a336a1c7414b5814aa4a37c90a6ae89926474a97d30956d7e034ff

2021-07-01 10:16:33 +08:00

..

test

Construct and use PrecomputedTransactionData in PSBT signing

2021-06-12 12:25:28 -07:00

bdb.cpp

…

bdb.h

…

coincontrol.cpp

…

coincontrol.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

coinselection.cpp

Have OutputGroup determine the value to use

2021-05-19 15:35:11 -04:00

coinselection.h

Have OutputGroup determine the value to use

2021-05-19 15:35:11 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

…

db.cpp

Merge bitcoin/bitcoin#21944: wallet: Fix issues when walletdir is root directory

2021-06-09 22:53:36 +12:00

db.h

…

dump.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

Merge bitcoin/bitcoin#21365: Basic Taproot signing support for descriptor wallets

2021-06-18 09:12:44 +12:00

external_signer_scriptpubkeyman.h

refactor: remove m_internal from DescriptorSPKman

2021-06-30 08:37:50 +02:00

feebumper.cpp

Replace size/weight estimate tuple with struct for named fields

2021-05-26 07:33:09 +08:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Merge bitcoin/bitcoin#18418: wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100

2021-05-26 19:32:51 +08:00

interfaces.cpp

Remove unused wallet pointer from NotifyAddressBookChanged

2021-06-28 10:39:49 +02:00

ismine.h

…

load.cpp

scripted-diff: Fix ellipsis after pr20773

2021-05-27 13:46:36 +03:00

load.h

…

receive.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

receive.h

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

rpcdump.cpp

Merge bitcoin/bitcoin#19651: wallet: importdescriptors update existing

2021-07-01 10:06:56 +08:00

rpcwallet.cpp

Remove priv option for ToNormalizedString

2021-06-24 13:49:22 -04:00

rpcwallet.h

…

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#20191: wallet, refactor: make DescriptorScriptPubKeyMan agnostic of internal flag

2021-07-01 10:16:33 +08:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#20191: wallet, refactor: make DescriptorScriptPubKeyMan agnostic of internal flag

2021-07-01 10:16:33 +08:00

spend.cpp

wallet: Add error message to GetReservedDestination

2021-06-22 21:57:04 -04:00

spend.h

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

sqlite.cpp

wallet: refactor: dedup sqlite PRAGMA assignments

2021-05-17 17:22:36 +02:00

sqlite.h

…

transaction.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

transaction.h

refactor: Switch serialize to uint8_t (1/n)

2021-05-31 14:56:17 +02:00

wallet.cpp

Merge bitcoin/bitcoin#20191: wallet, refactor: make DescriptorScriptPubKeyMan agnostic of internal flag

2021-07-01 10:16:33 +08:00

wallet.h

Merge bitcoin/bitcoin#19651: wallet: importdescriptors update existing

2021-07-01 10:06:56 +08:00

walletdb.cpp

Merge bitcoin/bitcoin#19651: wallet: importdescriptors update existing

2021-07-01 10:06:56 +08:00

walletdb.h

Merge bitcoin/bitcoin#19651: wallet: importdescriptors update existing

2021-07-01 10:06:56 +08:00

wallettool.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

wallettool.h

…

walletutil.cpp

scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls

2021-05-24 10:29:58 +02:00

walletutil.h

wallet: Upgrade existing descriptor caches

2021-06-24 13:49:22 -04:00