MarcoFalke baa9fc941c Merge bitcoin/bitcoin#22787: refactor: actual immutable pointing ...

54011e7aa2 refactor: use CWallet const shared pointers when possible (Karl-Johan Alm)
96461989a2 refactor: const shared_ptrs (Karl-Johan Alm)

Pull request description:

  ```C++
  const std::shared_ptr<CWallet> wallet = x;
  ```
  means we can not do `wallet = y`, but we can totally do `wallet->DestructiveOperation()`, contrary to what that line looks like.

  This PR

  * introduces a new convention: always use const shared pointers to `CWallet`s (even when we mutate the pointed-to thing)
  * uses `const shared_ptr<const CWallet>` everywhere where wallets are not modified

  In the future, this should preferably apply to all shared pointers, not limited to just `CWallet`s.

  Both of these serve the same purpose: to dispell the misconception that `const shared_ptr<X>` immutates `X`. It doesn't, and it's dangerous to leave this misconception as is, for obvious reasons.

ACKs for top commit:
  theStack:
    re-ACK 54011e7aa2

Tree-SHA512: 3bf4062fc821751be30770c6b4ead10a016847970f155a0a5156f304347d221b9830840030c2fbfba8cd1e282f4eda45f5b4107fe6df8138afdcb6c2e95a2836

2021-10-29 10:52:37 +02:00

..

test

Merge bitcoin/bitcoin#22787: refactor: actual immutable pointing

2021-10-29 10:52:37 +02:00

bdb.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

bdb.h

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

coincontrol.cpp

…

coincontrol.h

External input fund support cleanups

2021-10-06 06:55:34 +08:00

coinselection.cpp

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

coinselection.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

db.h

…

dump.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

ismine.h

…

load.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

load.h

…

receive.cpp

…

receive.h

…

rpcdump.cpp

refactor: use CWallet const shared pointers when possible

2021-10-25 16:12:21 +09:00

rpcwallet.cpp

refactor: use CWallet const shared pointers when possible

2021-10-25 16:12:21 +09:00

rpcwallet.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#23093: Add ability to flush keypool and always flush when upgrading non-HD to HD

2021-10-14 18:05:58 +02:00

scriptpubkeyman.h

…

spend.cpp

External input fund support cleanups

2021-10-06 06:55:34 +08:00

spend.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

sqlite.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

sqlite.h

…

transaction.cpp

…

transaction.h

doc: Fix CWalletTx::Confirmation doc

2021-10-21 22:13:35 +02:00

wallet.cpp

Merge bitcoin/bitcoin#22787: refactor: actual immutable pointing

2021-10-29 10:52:37 +02:00

wallet.h

doc: Fix CWalletTx::Confirmation doc

2021-10-21 22:13:35 +02:00

walletdb.cpp

walletdb: Use SQLiteDatabase for mock wallet databases

2021-10-22 17:49:43 -04:00

walletdb.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

wallettool.cpp

refactor: const shared_ptrs

2021-10-25 16:12:19 +09:00

wallettool.h

…

walletutil.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

walletutil.h

…