fanquake
c7ad94428a
Merge #19958 : doc: Better document features of feelers
...
2ea62cae48 Improve docs about feeler connections (Gleb Naumenko)
Pull request description:
"feeler" and "test-before-evict" are two different strategies suggest in [Eclipse Attacks on Bitcoin’s Peer-to-Peer Network](https://www.usenix.org/system/files/conference/usenixsecurity15/sec15-paper-heilman.pdf ). In our codebase, we use `ConnType::FEELER` to implement both.
It is confusing, up to the point that our documentation was just incorrect.
This PR:
- ~clarifies this aspect by renaming "ConnType::FEELER" to "ConnType::PROBE", meaning that this connections only probes that the node is operational, and then disconnects.~
- fixes the documentation
ACKs for top commit:
amitiuttarwar:
ACK 2ea62cae48 . thank you!
practicalswift:
ACK 2ea62cae48
Tree-SHA512: c9c03c09eefeacec28ea199cc3f697b0a98723f2f849f7a8115edc43791f8165e296e0e25a82f0b5a4a781a7de38c8954b48bf74c714eba02cdc21f7460673e5
2020-09-30 12:41:22 +08:00
..
2020-09-06 18:35:23 -07:00
2020-09-10 10:47:40 +09:00
2020-09-28 12:27:08 -07:00
2020-08-21 12:48:46 +08:00
2020-09-22 11:34:30 -04:00
2020-09-16 06:30:57 +08:00
2020-09-14 16:23:23 +02:00
2020-09-17 22:17:17 +02:00
2020-09-23 20:35:54 +02:00
2020-09-29 15:14:08 +08:00
2020-09-28 12:14:19 +10:00
2020-09-11 12:44:08 -07:00
2020-08-20 17:55:06 +00:00
2020-09-29 16:14:40 +08:00
2020-09-28 12:27:08 -07:00
2020-09-29 15:14:08 +08:00
2020-09-22 11:34:30 -04:00
2020-07-06 03:52:37 +02:00
2020-06-22 12:12:22 +02:00
2020-07-03 20:43:55 -07:00
2020-08-12 09:22:07 +01:00
2020-08-12 09:22:07 +01:00
2020-07-08 21:44:45 +08:00
2020-07-03 20:43:55 -07:00
2020-08-28 16:50:57 +02:00
2020-08-28 16:50:57 +02:00
2020-09-25 15:23:01 +03:00
2020-09-22 22:32:25 +02:00
2020-09-22 22:32:25 +02:00
2020-09-22 22:32:25 +02:00
2020-07-30 13:57:54 -07:00
2020-06-21 06:41:55 -04:00
2020-08-27 20:07:27 -04:00
2020-09-18 10:19:42 +09:00
2020-08-20 18:20:27 +00:00
2020-09-25 15:23:01 +03:00
2020-09-18 09:37:57 +09:00
2020-07-01 14:44:28 -04:00
2020-07-01 14:44:28 -04:00
2020-08-20 17:55:06 +00:00
2020-09-04 10:25:44 +01:00
2020-07-08 14:26:14 +03:00
2020-09-01 09:26:28 +08:00
2020-06-16 15:15:46 -04:00
2020-08-06 16:28:26 -07:00
2020-08-06 16:28:26 -07:00
2020-06-27 11:49:28 -04:00
2020-09-29 15:24:43 +02:00
2020-08-27 14:33:00 -04:00
2020-08-18 18:03:57 +00:00
2020-06-07 17:03:49 +02:00
2020-09-21 22:33:00 +02:00
2020-09-14 16:35:09 +08:00
2020-09-14 16:35:09 +08:00
2020-09-14 16:35:09 +08:00
2020-09-21 22:33:00 +02:00
2020-07-30 13:57:54 -07:00
2020-06-15 08:08:19 -04:00
2020-09-04 09:46:44 -07:00
2020-07-30 14:38:50 +03:00
2020-07-30 14:38:50 +03:00
2020-09-29 16:14:40 +08:00
2020-09-08 07:55:11 +02:00
2020-09-30 12:41:22 +08:00
2020-09-30 12:41:22 +08:00
2020-09-21 10:13:34 +02:00
2020-09-21 10:13:34 +02:00
2020-08-24 21:50:59 +02:00
2020-06-27 11:49:28 -04:00
2020-07-01 18:03:12 -04:00
2020-07-01 18:02:38 -04:00
2020-09-22 22:05:18 -04:00
2020-09-22 22:05:18 -04:00
2020-06-24 16:32:19 -04:00
2020-06-24 16:32:19 -04:00
2020-08-18 18:03:56 +00:00
2020-07-30 13:57:54 -07:00
2020-08-10 21:30:42 +08:00
2020-09-22 17:08:08 +02:00
2020-06-21 06:02:59 -04:00
2020-06-21 06:02:59 -04:00
2020-06-22 12:12:22 +02:00
2020-09-22 22:31:31 +02:00
2020-09-22 22:31:31 +02:00
2020-07-30 13:57:09 -07:00
2020-07-26 22:46:28 +03:00
2020-08-29 20:46:47 +03:00
2020-09-19 18:02:42 +03:00
2020-08-18 10:46:53 +03:00
2020-06-27 11:49:28 -04:00
2020-08-07 14:55:02 +02:00
2020-07-29 07:53:19 +02:00
2020-07-01 14:44:24 -04:00
2020-09-22 11:34:30 -04:00
2020-09-22 11:34:30 -04:00
2020-09-28 12:14:19 +10:00
2020-09-28 12:14:19 +10:00
2020-09-29 20:41:11 +08:00
2020-09-23 20:35:54 +02:00
2020-09-22 11:34:30 -04:00
2020-09-22 11:34:30 -04:00
2020-09-17 22:17:17 +02:00
2020-07-29 16:36:44 +07:00
2020-06-10 15:01:20 +03:00
2020-06-10 15:01:20 +03:00