MarcoFalke a9d0cec499 Merge bitcoin/bitcoin#23106: Ensure wallet is unlocked before signing PSBT with walletprocesspsbt and GUI ...

7e3ee4cdd0 GUI: Ask user to unlock wallet before signing psbt (Samuel Dobson)
0f3acecf33 Add test that walletprocesspsbt requires unlocked wallet when signing (Samuel Dobson)
0e895212bb Ensure wallet is unlocked before signing in walletprocesspsbt (Samuel Dobson)

Pull request description:

  If signing a PSBT, we need to ensure the wallet is unlocked.

  Fixes #22874, fixes bitcoin-core/gui#312

ACKs for top commit:
  achow101:
    ACK 7e3ee4cdd0
  lsilva01:
    Code Review ACK 7e3ee4cdd0
  benthecarman:
    ACK 7e3ee4cdd0

Tree-SHA512: 6726a873582747900ab454ea21153a92be86808a4c1517dc2856b389876a2da9e8df1ffa9b567b6bd017038342c3544ecf5ca3c97744e7debe0a5ee65563687d

2021-09-28 09:49:44 +02:00

..

test

test: Add remaining scenarios of 0 waste

2021-09-24 15:36:58 +05:30

bdb.cpp

scripted-diff: Rename overloaded int GetArg to GetIntArg

2021-09-27 06:57:20 -04:00

bdb.h

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

coinselection.cpp

Add SelectCoinsSRD function

2021-09-23 13:33:25 -04:00

coinselection.h

Add SelectCoinsSRD function

2021-09-23 13:33:25 -04:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

db.cpp

Merge bitcoin/bitcoin#21944: wallet: Fix issues when walletdir is root directory

2021-06-09 22:53:36 +12:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

dump.h

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

external_signer_scriptpubkeyman.cpp

Merge bitcoin/bitcoin#21365: Basic Taproot signing support for descriptor wallets

2021-06-18 09:12:44 +12:00

external_signer_scriptpubkeyman.h

refactor: remove m_internal from DescriptorSPKman

2021-06-30 08:37:50 +02:00

feebumper.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

…

init.cpp

Merge bitcoin/bitcoin#22219: multiprocess: Start using init makeNode, makeChain, etc methods

2021-09-16 08:47:38 +08:00

interfaces.cpp

Make GUI UTXO lock/unlock persistent

2021-09-25 23:50:06 +12:00

ismine.h

doc: Add developer documentation to isminetype

2021-01-19 19:04:45 +08:00

load.cpp

Enable clang-tidy bugprone-argument-comment and fix violations

2021-09-07 09:11:10 +02:00

load.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

receive.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

receive.h

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

rpcdump.cpp

scripted-diff: Rename overloaded int GetArg to GetIntArg

2021-09-27 06:57:20 -04:00

rpcwallet.cpp

Ensure wallet is unlocked before signing in walletprocesspsbt

2021-09-28 01:25:42 +13:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

scripted-diff: Rename overloaded int GetArg to GetIntArg

2021-09-27 06:57:20 -04:00

scriptpubkeyman.h

refactor: Remove unused KeyIDHasher

2021-08-22 17:31:58 +02:00

spend.cpp

Use SelectCoinsSRD if it has less waste

2021-09-23 13:33:25 -04:00

spend.h

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

sqlite.cpp

wallet: refactor: dedup sqlite PRAGMA assignments

2021-05-17 17:22:36 +02:00

sqlite.h

doc: fix various typos

2021-01-04 12:31:31 +08:00

transaction.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

transaction.h

wallet: refactor: avoid duplicate lookup on mapValue["timesmart"]

2021-09-12 23:41:32 +02:00

wallet.cpp

scripted-diff: Rename overloaded int GetArg to GetIntArg

2021-09-27 06:57:20 -04:00

wallet.h

Allow locked UTXOs to be store in the wallet database

2021-09-25 23:50:06 +12:00

walletdb.cpp

Allow locked UTXOs to be store in the wallet database

2021-09-25 23:50:06 +12:00

walletdb.h

Allow locked UTXOs to be store in the wallet database

2021-09-25 23:50:06 +12:00

wallettool.cpp

refactor: move first run detection to client code

2021-05-19 08:50:16 +02:00

wallettool.h

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

walletutil.cpp

scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls

2021-05-24 10:29:58 +02:00

walletutil.h

wallet: Upgrade existing descriptor caches

2021-06-24 13:49:22 -04:00