fanquake
f3dbd1c2b2
Merge bitcoin/bitcoin#22627 : [addrman] De-duplicate Add() function
...
60e0cbdd57 [addrman] Merge the two Add() functions (Amiti Uttarwar)
Pull request description:
This PR merges the two definitions of this overloaded function to reduce code duplication.
When these functions were introduced in 5fee401fe1 , there were multiple places that invoked `Add()` with a single addr and a vector of addrs each, so it made sense to overload the function. I could see how the small difference in log statement was more meaningful when a peer was added via IRC :)
Now, the definition of `Add()` that takes in a single address is only invoked from the hidden/test-only RPC `addpeeraddress`. These changes should not cause any observable difference, and are covered by the existing tests that use this RPC endpoint.
ACKs for top commit:
jnewbery:
Code review ACK 60e0cbdd57
Zero-1729:
crACK 60e0cbd
fanquake:
ACK 60e0cbdd57
Tree-SHA512: 782fb2ac6d2d403ba7d7ff543197ca42b610b9a8806952d271e57e2ee3527ad1a94af4ebbad5371b5e95d77df07c56ccc8c1d5a2c82cdecb0d2b5085b3bdd5ee
2021-08-17 10:05:03 +08:00
..
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-08-15 22:35:13 -07:00
2021-03-16 19:52:37 +01:00
2020-12-10 07:15:42 +01:00
2021-03-15 10:41:30 +08:00
2021-08-07 10:21:45 +02:00
2021-06-18 23:13:07 +00:00
2021-03-15 17:26:35 -07:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2021-03-15 10:41:30 +08:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-07-20 15:36:23 +02:00
2021-08-12 10:41:11 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-17 10:32:59 +02:00
2021-03-03 12:23:41 +02:00
2021-08-12 10:41:11 +01:00
2020-12-31 09:45:41 +01:00
2021-03-11 13:45:14 +08:00
2021-08-12 10:41:11 +01:00
2021-03-11 13:45:14 +08:00
2021-05-18 07:13:25 +02:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-07 13:41:14 +02:00
2021-05-21 19:41:43 +00:00
2021-08-06 12:31:28 +02:00
2021-03-09 12:56:44 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-05-24 10:29:58 +02:00
2021-07-04 21:30:50 +02:00
2021-07-04 21:30:50 +02:00
2021-03-11 13:45:14 +08:00
2021-08-04 19:20:32 +08:00
2021-06-13 09:43:54 +02:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2021-07-27 14:53:24 +03:00
2021-05-12 16:13:30 +02:00
2021-04-30 11:29:14 +01:00
2021-06-04 16:12:04 +02:00
2021-03-16 19:52:31 +01:00
2021-06-14 13:58:05 +02:00
2021-05-25 08:20:43 -07:00
2020-12-31 09:45:41 +01:00
2021-05-09 10:04:01 +02:00
2021-03-19 23:50:36 +01:00
2020-12-31 09:45:41 +01:00
2021-03-11 13:45:14 +08:00
2021-03-03 09:17:37 +01:00
2021-03-03 09:17:37 +01:00
2021-03-24 06:57:55 +01:00
2021-07-14 12:34:04 +02:00
2020-12-10 07:15:42 +01:00
2021-07-19 19:12:54 +02:00
2021-04-22 17:28:39 +03:00
2020-12-10 07:15:42 +01:00
2021-04-09 13:17:37 +02:00
2020-12-10 07:15:42 +01:00
2020-12-15 19:00:36 +01:00
2021-07-15 11:51:17 +02:00
2021-05-11 21:24:49 +02:00
2021-05-04 09:24:17 +02:00
2020-12-10 07:15:42 +01:00
2021-03-17 14:56:20 +08:00
2021-04-25 10:36:00 +02:00
2020-12-10 07:15:42 +01:00
2021-05-12 10:20:59 +02:00
2020-12-15 19:00:36 +01:00
2021-07-01 12:57:53 -04:00
2021-07-04 21:30:50 +02:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-03-30 10:42:45 +02:00
2021-03-03 09:17:37 +01:00
2021-03-16 19:52:37 +01:00
2020-12-10 07:15:42 +01:00
2020-12-31 09:45:41 +01:00
2021-08-04 19:20:32 +08:00
2021-05-09 10:25:21 +02:00
2021-08-06 12:31:28 +02:00
2021-05-11 08:54:24 +02:00
2021-03-04 08:39:27 +01:00
2021-05-20 17:26:24 +02:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2021-07-15 12:36:55 +02:00
2020-12-10 07:15:42 +01:00
2021-07-14 18:45:53 +05:30
2021-07-14 18:45:53 +05:30
2021-05-24 10:29:58 +02:00
2021-06-10 15:04:39 -04:00
2021-04-12 11:14:49 +10:00