mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-01 18:49:15 +01:00
cb3473a680
f700609e8adoc: Release notes for mining IPC interface bump (Ryan Ofsky)9453c15361ipc mining: break compatibility with existing clients (version bump) (Sjors Provoost)70de5cc2d2ipc mining: pass missing context to BlockTemplate methods (incompatible schema change) (Sjors Provoost)2278f017afipc mining: remove deprecated methods (incompatible schema change) (Ryan Ofsky)c6638fa7c5ipc mining: provide default option values (incompatible schema change) (Ryan Ofsky)a4603ac774ipc mining: declare constants for default field values (Ryan Ofsky)ff995b50cfipc test: add workaround to block_reserved_weight exception test (Ryan Ofsky)b970cdf20ftest framework: expand expected_stderr, expected_ret_code options (Ryan Ofsky)df53a3e5ecrpc refactor: stop using deprecated getCoinbaseCommitment method (Ryan Ofsky) Pull request description: This PR increments the field number of the `Init.makeMining` method and makes the old `makeMining` method return an error, so IPC mining clients not using the latest schema file will get an error and not be able to access the Mining interface. Normally, there shouldn't be a need to break compatibility this way, but the mining interface has evolved a lot since it was first introduced, with old clients using the original methods less stable and performant than newer clients. So now is a good time to introduce a cutoff, drop deprecated methods, and stop supporting old clients which can't function as well. Bumping the field number is also an opportunity to make other improvements that would be awkward to implement compatibly: - Making Cap'n Proto default parameter and field values match default values of corresponding C++ methods and structs. - Adding missing Context parameters to Mining.createNewBlock and checkBlock methods so these methods will be executed on separate execution threads and not block the Cap'n Proto event loop thread. More details about these changes are in the commit messages. ACKs for top commit: Sjors: ACKf700609e8aenirox001: ACKf700609e8aismaelsadeeq: ACKf700609e8asedited: ACKf700609e8aTree-SHA512: 0901886af00214c138643b33cec21647de5671dfff2021afe06d78dfd970664a844cde9a1e28f685bb27edccaf6e0c3f2d1e6bb4164bde6b84f42955946e366d