laanwj ba11eb354b Merge bitcoin/bitcoin#23542: net: open p2p connections to nodes that listen on non-default ports ...

36ee76d1af net: remove unused CNetAddr::GetHash() (Vasil Dimov)
d0abce9a50 net: include the port when deciding a relay destination (Vasil Dimov)
2e38a0e686 net: add CServiceHash constructor so the caller can provide the salts (Vasil Dimov)
97208634b9 net: open p2p connections to nodes that listen on non-default ports (Vasil Dimov)

Pull request description:

  By default, for mainnet, the p2p listening port is 8333. Bitcoin Core
  has a strong preference for only connecting to nodes that listen on that
  port.

  Remove that preference because connections over clearnet that involve
  port 8333 make it easy to detect, analyze, block or divert Bitcoin p2p
  traffic before the connection is even established (at TCP SYN time).

  For further justification see the OP of:
  https://github.com/bitcoin/bitcoin/pull/23306

ACKs for top commit:
  laanwj:
    Concept and light code review ACK 36ee76d1af
  prayank23:
    ACK 36ee76d1af
  stickies-v:
    tACK 36ee76d1a
  jonatack:
    ACK 36ee76d1af
  glozow:
    utACK 36ee76d1af

Tree-SHA512: 7f45ab7567c51c19fc50fabbaf84f0cc8883a8eef84272b76435c014c31d89144271d70dd387212cc1114213165d76b4d20a5ddb8dbc958fe7e74e6ddbd56d11

2022-03-02 09:33:03 +01:00

..

addition_overflow.cpp

util: Add SaturatingAdd helper

2022-02-21 14:32:53 +01:00

addrman.cpp

test: Fix Wambiguous-reversed-operator compiler warnings

2022-02-21 16:36:59 +01:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

…

base_encode_decode.cpp

…

bech32.cpp

…

block_header.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

Require CBlockIndex::RaiseValidity() to hold cs_main

2022-01-25 20:43:28 +01:00

checkqueue.cpp

…

coins_view.cpp

test: Avoid testing negative block heights

2022-02-02 15:32:06 +01:00

connman.cpp

Merge bitcoin/bitcoin#24021: Rename and move PoissonNextSend functions

2022-01-23 11:44:02 +08:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20_poly1305_aead.cpp

…

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

fuzz: non-addrman fuzz tests: override-able check ratio

2022-01-11 12:08:44 +01:00

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

Merge bitcoin/bitcoin#23438: refactor: Use spans of std::byte in serialize

2022-01-27 19:19:12 +01:00

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

…

netaddress.cpp

net: remove unused CNetAddr::GetHash()

2022-02-11 15:21:52 +01:00

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

p2p_transport_serialization.cpp

scripted-diff: Rename CNetMessage::m_command with CNetMessage::m_type

2022-01-15 20:59:19 +02:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

…

process_messages.cpp

…

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

…

rolling_bloom_filter.cpp

…

rpc.cpp

Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC

2022-01-28 08:46:03 +01:00

script_assets_test_minimizer.cpp

…

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

fuzz: Split script formatting from script fuzz target

2022-02-15 12:19:34 +01:00

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

fuzz: Split script formatting from script fuzz target

2022-02-15 12:19:34 +01:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

Optimize CHECKSIGADD Script Validation

2022-01-19 15:21:52 -08:00

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

fuzz: Avoid unsigned integer overflow in FormatParagraph

2022-02-09 14:38:22 +01:00

strprintf.cpp

…

system.cpp

…

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

…

txrequest.cpp

…

util.cpp

fuzz: FuzzedFileProvider::write should not return negative value

2022-02-27 17:03:35 -05:00

util.h

Merge bitcoin/bitcoin#23604: Use Sock in CNode

2022-02-04 09:24:17 +01:00

utxo_snapshot.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

validation_load_mempool.cpp

…

versionbits.cpp

rpc: getdeploymentinfo: include signalling info

2022-01-15 04:37:56 +10:00