Samuel Dobson a31a1ceec7 Merge bitcoin/bitcoin#21907: wallet: Do not iterate a directory if having an error while accessing it ...

29c9e2c2d2 wallet: Do not iterate a directory if having an error while accessing it (Hennadii Stepanov)

Pull request description:

  On Windows when `ListDatabases` tries to iterate any system folder, e.g., "System Volume Information", it falls into an infinite loop.

  This PR fixes this bug. Now the `debug.log` contains:
  ```
  2021-05-12T09:07:53Z ListDatabases: Access is denied D:/System Volume Information -- skipping.
  ```

  An easy way to reproduce the bug and test this PR is to pass the `-walletdir=D:\` command-line option, and run the `listwalletdir` RPC, or File -> Open Wallet in the GUI menu.

  Fixes #20081.
  Fixes #21136.
  Fixes #21904.

  Also https://bitcoin.stackexchange.com/questions/99243/listwalletdir-access-is-denied-d-system-volume-information

ACKs for top commit:
  prayank23:
    ACK 29c9e2c2d2
  promag:
    Code review ACK 29c9e2c2d2.
  meshcollider:
    Code review ACK 29c9e2c2d2

Tree-SHA512: b851c88e6d09626f4cb81acc2fa59a563b2aee64582963285715bf785c64b872e8bf738aa6b27bdbaf4c3e5c8565c2dc2c802135f9aa1f48b4b913435bc5d793

2021-05-13 21:09:32 +12:00

..

test

move-only: Move constants to blockstorage

2021-04-27 10:32:54 +02:00

bdb.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

bdb.h

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

coinselection.cpp

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

coinselection.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

db.cpp

wallet: Do not iterate a directory if having an error while accessing it

2021-05-12 12:11:47 +03:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

dump.h

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

external_signer_scriptpubkeyman.cpp

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

external_signer_scriptpubkeyman.h

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

feebumper.cpp

Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing

2021-03-09 10:42:21 +13:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

doc: Clarify that feerates are per virtual size

2021-05-01 18:21:05 +02:00

interfaces.cpp

Move external signer out of wallet module

2021-04-08 17:56:00 +02:00

ismine.h

doc: Add developer documentation to isminetype

2021-01-19 19:04:45 +08:00

load.cpp

scripted-diff: Replace three dots with ellipsis in the UI strings

2021-05-02 22:17:16 +03:00

load.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

rpcdump.cpp

Merge bitcoin/bitcoin#21836: scripted-diff: Replace three dots with ellipsis in the UI strings

2021-05-10 14:02:46 +02:00

rpcwallet.cpp

Merge bitcoin/bitcoin#21910: refactor: remove redundant fOnlySafe argument

2021-05-13 21:05:55 +12:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

scriptpubkeyman.h

wallet: ExternalSigner: add GetDescriptors method

2021-02-23 14:34:31 +01:00

sqlite.cpp

tests: Skip SQLite fsyncs while testing

2021-04-12 19:29:03 -04:00

sqlite.h

doc: fix various typos

2021-01-04 12:31:31 +08:00

wallet.cpp

refactor: remove redundant fOnlySafe argument

2021-05-11 09:58:13 +02:00

wallet.h

refactor: remove redundant fOnlySafe argument

2021-05-11 09:58:13 +02:00

walletdb.cpp

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

wallettool.h

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

walletutil.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

walletutil.h

wallet: add external_signer flag

2021-02-23 14:34:30 +01:00