MarcoFalke 42b25025fa Merge bitcoin/bitcoin#23644: wallet: Replace confusing getAdjustedTime() with GetTime() ...

fa37e798b2 wallet: Replace confusing getAdjustedTime() with GetTime() (MarcoFalke)

Pull request description:

  Setting `nTimeReceived` to the adjusted time has several issues:

  * `m_best_block_time` is set to the "unadjusted" time, thus a comparison of the two times is like comparing apples to oranges. In the worst case this opens up an attack vector where remote peers can force a premature re-broadcast of wallet txs.
  * The RPC documentation for `"timereceived"` doesn't mention that the network adjusted time is used, possibly confusing users when the time reported by RPC is off by a few seconds compared to their local timestamp.

  Fix all issues by replacing the call with `GetTime()`. Also a style fix: Use non-narrowing integer conversion in the RPC method.

ACKs for top commit:
  theStack:
    Code-review ACK fa37e798b2
  shaavan:
    crACK fa37e798b2

Tree-SHA512: 8d020ba400521246b7aed4b6c41319fc70552e8c69e929a5994500375466a9edac02a0ae64b803dbc6695df22276489561a23bd6e030c44c97d288f7b9b2b3fa

2021-12-07 09:02:06 +01:00

..

rpc

Merge bitcoin/bitcoin#23413: Replace MakeSpan helper with Span deduction guide

2021-12-03 10:44:37 +01:00

test

Merge bitcoin/bitcoin#23653: Generalize/simplify VectorReader into SpanReader

2021-12-03 10:25:24 +01:00

bdb.cpp

…

bdb.h

wallet: Fixed Grammatical error in bdb.h

2021-11-09 12:41:37 +01:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

context.cpp

…

context.h

wallet: Call load handlers without cs_wallet locked

2021-11-22 09:42:36 +00:00

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Mention bech32m in -addresstype and -changetype help

2021-11-16 12:20:13 -05:00

interfaces.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

ismine.h

refactor: Use underlying type of isminetype for isminefilter

2021-11-25 14:56:30 +01:00

load.cpp

…

load.h

…

receive.cpp

…

receive.h

…

rpcwallet.cpp

Merge bitcoin/bitcoin#23644: wallet: Replace confusing getAdjustedTime() with GetTime()

2021-12-07 09:02:06 +01:00

rpcwallet.h

MOVEONLY: Move LoadWalletHelper to wallet/rpc/util

2021-12-03 13:53:12 +13:00

salvage.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#22929: wallet: Automatically add receiving destinations to the address book

2021-12-02 19:37:33 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#22929: wallet: Automatically add receiving destinations to the address book

2021-12-02 19:37:33 +01:00

spend.cpp

…

spend.h

…

sqlite.cpp

…

sqlite.h

…

transaction.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

transaction.h

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

wallet.cpp

Merge bitcoin/bitcoin#23644: wallet: Replace confusing getAdjustedTime() with GetTime()

2021-12-07 09:02:06 +01:00

wallet.h

Merge bitcoin/bitcoin#22929: wallet: Automatically add receiving destinations to the address book

2021-12-02 19:37:33 +01:00

walletdb.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

walletdb.h

…

wallettool.cpp

Merge bitcoin/bitcoin#23349: util: Use FEATURE_LATEST for wallets created with bitcoin-wallet

2021-11-16 15:32:18 +13:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…