mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-13 06:04:42 +02:00
1a2523e901
735b25519asupport: clamp RLIMIT_MEMLOCK to size_t (Sjors Provoost)8ab4b9fc85init: clamp fd limits to int (Sjors Provoost)4afbabdcefFix startup failure with RLIM_INFINITY fd limits (Sjors Provoost) Pull request description: When setting the fd limit to unlimited, the node fails to start: ```sh ulimit -n unlimited build/bin/bitcoind Error: Not enough file descriptors available. -1 available, 160 required. ``` This was caused by `RaiseFileDescriptorLimit()` (introduced in #2568) casting `limitFD.rlim_cur` to `int`, which for `RLIM_INFINITY` overflows to `-1`. Fix it by returning `std::numeric_limits<int>::max()` instead. Some platforms implement `RLIM_INFINITY` as the maximum uint64, others as int64 (-1). So simply changing the return type to `uint64_t` wouldn't work. Similarly, though unlikely to actually happen: ```sh ulimit -n 214748364 build/bin/bitcoind Error: Not enough file descriptors available. -2147483648 available, 160 required. ``` The second commit expands the fix by clamping all values above `std::numeric_limits<int>::max()` instead of letting them overflow. This PR also expands `test/functional/feature_init.py` to cover these, using `resource.setrlimit`. The check is skipped on environments with a hard limit below infinity (or that don't have the Python [Resource module](https://docs.python.org/3/library/resource.html)). macOS by default has a hard limit of infinity, but on e.g. Ubuntu the default hard limit is 524288. The third commit applies a similar fix to `PosixLockedPageAllocator::GetLimit()` for 32-bit systems, but without a test. ACKs for top commit: winterrdog: Re-ACK735b25519aachow101: ACK735b25519asedited: Re-ACK735b25519apinheadmz: ACK735b25519aTree-SHA512: 0ce0292ecd61456bdec6943b06cbb9ecfc5180ee6dce850f8496ef54af22c1fae6ea473085202f5ba6f72e4dc51a29247620c9a0eae31e96658adc77b293129f
121 lines
3.5 KiB
C++
121 lines
3.5 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_UTIL_FS_HELPERS_H
|
|
#define BITCOIN_UTIL_FS_HELPERS_H
|
|
|
|
#include <util/fs.h>
|
|
|
|
#include <cstdint>
|
|
#include <cstdio>
|
|
#include <iosfwd>
|
|
#include <limits>
|
|
#include <optional>
|
|
#include <string>
|
|
|
|
#ifdef __APPLE__
|
|
enum class FSType {
|
|
EXFAT,
|
|
OTHER,
|
|
ERROR
|
|
};
|
|
|
|
/**
|
|
* Detect filesystem type for a given path.
|
|
* Currently identifies exFAT filesystems which cause issues on macOS.
|
|
*
|
|
* @param[in] path The directory path to check
|
|
* @return FSType enum indicating the filesystem type
|
|
*/
|
|
FSType GetFilesystemType(const fs::path& path);
|
|
#endif
|
|
|
|
/**
|
|
* Ensure file contents are fully committed to disk, using a platform-specific
|
|
* feature analogous to fsync().
|
|
*/
|
|
bool FileCommit(FILE* file);
|
|
|
|
/**
|
|
* Sync directory contents. This is required on some environments to ensure that
|
|
* newly created files are committed to disk.
|
|
*/
|
|
void DirectoryCommit(const fs::path& dirname);
|
|
|
|
bool TruncateFile(FILE* file, unsigned int length);
|
|
|
|
/**
|
|
* Try to raise the file descriptor limit to the requested number.
|
|
*
|
|
* @param[in] min_fd The requested minimum number of file descriptors.
|
|
* @returns The actual file descriptor limit. It may be lower or
|
|
* higher than min_fd. Returns std::numeric_limits<int>::max()
|
|
* if the OS imposes no limit (RLIM_INFINITY).
|
|
*
|
|
*/
|
|
int RaiseFileDescriptorLimit(int min_fd);
|
|
|
|
void AllocateFileRange(FILE* file, unsigned int offset, unsigned int length);
|
|
|
|
/**
|
|
* Rename src to dest.
|
|
* @return true if the rename was successful.
|
|
*/
|
|
[[nodiscard]] bool RenameOver(fs::path src, fs::path dest);
|
|
|
|
namespace util {
|
|
enum class LockResult {
|
|
Success,
|
|
ErrorWrite,
|
|
ErrorLock,
|
|
};
|
|
[[nodiscard]] LockResult LockDirectory(const fs::path& directory, const fs::path& lockfile_name, bool probe_only = false);
|
|
} // namespace util
|
|
void UnlockDirectory(const fs::path& directory, const fs::path& lockfile_name);
|
|
bool CheckDiskSpace(const fs::path& dir, uint64_t additional_bytes = 0);
|
|
|
|
/** Get the size of a file by scanning it.
|
|
*
|
|
* @param[in] path The file path
|
|
* @param[in] max Stop seeking beyond this limit
|
|
* @return The file size or max
|
|
*/
|
|
std::streampos GetFileSize(const char* path, std::streamsize max = std::numeric_limits<std::streamsize>::max());
|
|
|
|
/** Release all directory locks. This is used for unit testing only, at runtime
|
|
* the global destructor will take care of the locks.
|
|
*/
|
|
void ReleaseDirectoryLocks();
|
|
|
|
bool TryCreateDirectories(const fs::path& p);
|
|
fs::path GetDefaultDataDir();
|
|
|
|
/** Convert fs::perms to symbolic string of the form 'rwxrwxrwx'
|
|
*
|
|
* @param[in] p the perms to be converted
|
|
* @return Symbolic permissions string
|
|
*/
|
|
std::string PermsToSymbolicString(fs::perms p);
|
|
/** Interpret a custom permissions level string as fs::perms
|
|
*
|
|
* @param[in] s Permission level string
|
|
* @return Permissions as fs::perms
|
|
*/
|
|
std::optional<fs::perms> InterpretPermString(const std::string& s);
|
|
|
|
/** Check if a directory is writable by creating a temporary file on it.
|
|
*
|
|
* @param[in] dir_path Path of the directory to test
|
|
* @return true if a temporary file could be created and removed, false otherwise.
|
|
* @throw std::runtime_error if dir_path is not a directory.
|
|
*/
|
|
bool IsDirWritable(const fs::path& dir_path);
|
|
|
|
#ifdef WIN32
|
|
fs::path GetSpecialFolderPath(int nFolder, bool fCreate = true);
|
|
#endif
|
|
|
|
#endif // BITCOIN_UTIL_FS_HELPERS_H
|