highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 15:19:07 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
456c8d6cd80fc3461957a3553a0483756396b988
bitcoin/src
History
W. J. van der Laan 456c8d6cd8 Merge bitcoin-core/gui#313: qt: Optimize string concatenation by default 
a02c970eb0 qt, refactor: Revert explicit including QStringBuilder (Hennadii Stepanov)
3fd3a0fc87 qt, build: Optimize string concatenation (Hennadii Stepanov)

Pull request description:

  From [Qt docs](https://doc.qt.io/qt-5/qstring.html#more-efficient-string-construction):
  > ... multiple uses of the \[`QString`\] '+' operator usually means multiple memory allocations. When concatenating n substrings, where n > 2, there can be as many as n - 1 calls to the memory allocator.

  With this PR
  > ... the '+' will automatically be performed as the `QStringBuilder` '%' everywhere.

  The change in the `src/Makefile.qt.include` file does not justify submitting this PR into the main repo, IMHO.

ACKs for top commit:
  laanwj:
    Code review ACK a02c970eb0
  Talkless:
    utACK a02c970eb0, built successfully on Debian Sid with Qt 5.15.2, but did not check if any displayed strings are "wrong" after refactoring.
  jarolrod:
    ACK a02c970eb0

Tree-SHA512: cbb476ee96f27c3bd6e125efab74d8bf24bbdb4c30576b3feea45e203405f3bf5b497dd7d3e11361fc825fcbf4b893b152921a9efdeaf73b42d1865d85f0ae84
2021-05-26 15:01:18 +02:00
..
bench
Merge bitcoin/bitcoin#17331: Use effective values throughout coin selection
2021-05-26 01:35:43 +12:00
compat
Remove support for double serialization
2021-05-24 16:15:05 -07:00
config
…
consensus
versionbits: Add explicit NEVER_ACTIVE deployments
2021-04-12 11:14:49 +10:00
crc32c
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
crypto
crypto: Make MuHash Remove method efficient
2021-04-19 20:28:46 +02:00
index
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
init
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
interfaces
multiprocess: Add echoipc RPC method and test
2021-04-23 03:02:50 -05:00
ipc
multiprocess: Add echoipc RPC method and test
2021-04-23 03:02:50 -05:00
leveldb
Update to leveldb upstream using subtree merge
2020-01-28 16:59:07 +01:00
logging
Remove use of non-standard zero variadic macros
2020-04-30 18:02:04 +08:00
node
Merge bitcoin/bitcoin#21845: net processing: Don't require locking cs_main before calling RelayTransactions()
2021-05-07 11:11:05 +08:00
policy
Convert uses of double-serialization to {En,De}codeDouble
2021-05-24 16:15:05 -07:00
primitives
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
qt
Merge bitcoin-core/gui#313: qt: Optimize string concatenation by default
2021-05-26 15:01:18 +02:00
rpc
Merge bitcoin/bitcoin#22043: rpc, test: addpeeraddress test coverage, code simplify/constness
2021-05-25 09:40:00 +02:00
script
move-only: Add util/hash_type
2021-05-11 10:38:18 +02:00
secp256k1
Update secp256k1 subtree to latest master
2020-10-27 23:08:48 -07:00
support
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
test
Merge bitcoin/bitcoin#21966: Remove double serialization; use software encoder for fee estimation
2021-05-26 10:16:41 +02:00
univalue
Update univalue subtree
2020-11-19 15:48:24 +01:00
util
Remove support for double serialization
2021-05-24 16:15:05 -07:00
wallet
Merge bitcoin/bitcoin#18418: wallet: Increase OUTPUT_GROUP_MAX_ENTRIES to 100
2021-05-26 19:32:51 +08:00
zmq
refactor: Avoid &foo[0] on C-Style arrays
2021-05-04 06:55:30 +02:00
.clang-format
[tools] Allow argument/parameter bin packing in clang-format
2021-02-18 10:07:37 +00:00
addrdb.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
addrdb.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
addrman.cpp
p2p: pull time call out of loop in CAddrMan::GetAddr_()
2021-05-19 13:04:09 +02:00
addrman.h
p2p: allow CAddrMan::GetAddr() by network, add doxygen
2021-05-19 13:04:11 +02:00
amount.h
…
arith_uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
arith_uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
attributes.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
banman.cpp
scripted-diff: Replace three dots with ellipsis in the UI strings
2021-05-02 22:17:16 +03:00
banman.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
base58.cpp
refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17)
2021-01-31 17:35:16 +01:00
base58.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bech32.cpp
naming nits
2021-03-17 17:59:22 -07:00
bech32.h
naming nits
2021-03-17 17:59:22 -07:00
bitcoin-cli-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-cli.cpp
cli: use C++17 std::array class template argument deduction (CTAD)
2021-04-20 10:35:53 +02:00
bitcoin-tx-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-tx.cpp
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
bitcoin-util-res.rc
Add bitcoin-util command line utility
2021-01-12 18:34:25 +10:00
bitcoin-util.cpp
Merge #20938: build: fix linking against -latomic when building for riscv
2021-01-18 18:33:24 +01:00
bitcoin-wallet-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-wallet.cpp
util: Add ArgsManager::GetCommand() and use it in bitcoin-wallet
2021-01-21 19:31:28 +01:00
bitcoind-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoind.cpp
multiprocess: Add bitcoin-node process spawning support
2021-04-23 03:02:50 -05:00
blockencodings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockencodings.h
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockfilter.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockfilter.h
[indexes] Fix default [de]serialization of BlockFilter.
2020-05-26 17:27:15 -04:00
bloom.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bloom.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chain.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.h
simplify ChainstateManager::SnapshotBlockhash() return semantics
2021-02-12 07:53:29 -06:00
chainparams.cpp
fuzz: Add utxo_snapshot target
2021-05-16 11:34:27 +02:00
chainparams.h
refactor: Use type-safe assumeutxo hash
2021-05-11 10:40:40 +02:00
chainparamsbase.cpp
versionbits: Add support for delayed activation
2021-04-12 11:14:49 +10:00
chainparamsbase.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsseeds.h
net: add I2P seeds to chainparamsseeds
2021-05-02 13:37:50 +02:00
checkqueue.h
refactor: Drop boost::thread stuff in CCheckQueue
2020-09-24 06:55:34 +03:00
clientversion.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
clientversion.h
refactor: Move STRINGIZE macro to macros.h
2021-02-01 22:30:05 +02:00
coins.cpp
simplify ChainstateManager::SnapshotBlockhash() return semantics
2021-02-12 07:53:29 -06:00
coins.h
refactor: Remove unused code
2021-05-11 10:39:44 +02:00
compat.h
net: extend Sock with methods for robust send & read until terminator
2021-03-01 17:36:16 +01:00
compressor.cpp
refactor: Use CPubKey vector constructor where possible
2021-05-04 06:53:32 +02:00
compressor.h
compressor: use a prevector in compressed script serialization
2020-05-15 15:26:54 -07:00
core_io.h
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
core_memusage.h
…
core_read.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
core_write.cpp
rpc: deprecate addresses and reqSigs from rpc outputs
2021-03-23 10:51:43 -04:00
cuckoocache.h
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
dbwrapper.cpp
refactor: Use only one temporary buffer in CreateObfuscateKey
2021-05-04 06:53:37 +02:00
dbwrapper.h
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
dummywallet.cpp
tests: Skip SQLite fsyncs while testing
2021-04-12 19:29:03 -04:00
external_signer.cpp
external_signer: remove ExternalSignerException
2021-04-13 20:09:34 +08:00
external_signer.h
external_signer: remove ExternalSignerException
2021-04-13 20:09:34 +08:00
flatfile.cpp
log: Move "Pre-allocating up to position 0x[...] in [...].dat" log message to debug category
2021-02-10 20:46:25 +00:00
flatfile.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
fs.cpp
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
fs.h
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
hash.cpp
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
hash.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
httprpc.cpp
Drop JSONRPCRequest constructors after #21366
2021-04-07 04:53:26 -04:00
httprpc.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
httpserver.cpp
refactor: Add TSA annotations to the WorkQueue class members
2021-05-09 13:48:07 +03:00
httpserver.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
i2p.cpp
i2p: cancel the Accept() method if waiting on the socket errors
2021-04-08 16:31:55 +02:00
i2p.h
i2p: use pointers to Sock to accommodate mocking
2021-03-16 13:59:18 +01:00
indirectmap.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
init.cpp
Merge bitcoin/bitcoin#21992: p2p: Remove -feefilter option
2021-05-25 08:42:30 +02:00
init.h
Drop JSONRPCRequest constructors after #21366
2021-04-07 04:53:26 -04:00
key_io.cpp
Use Bech32m encoding for v1+ segwit addresses
2021-03-16 10:48:36 -07:00
key_io.h
Better error messages for invalid addresses
2021-01-24 02:44:53 +01:00
key.cpp
refactor: Avoid &foo[0] on C-Style arrays
2021-05-04 06:55:30 +02:00
key.h
refactor: Avoid &foo[0] on C-Style arrays
2021-05-04 06:55:30 +02:00
logging.cpp
multiprocess: Add Ipc interface implementation
2021-04-23 03:02:50 -05:00
logging.h
multiprocess: Add Ipc interface implementation
2021-04-23 03:02:50 -05:00
Makefile.am
Remove support for double serialization
2021-05-24 16:15:05 -07:00
Makefile.bench.include
net: Add libnatpmp support
2021-01-07 18:07:09 +02:00
Makefile.crc32c.include
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
Makefile.leveldb.include
build: Enable -Wsuggest-override
2020-05-12 18:03:39 +03:00
Makefile.qt_locale.include
qt: Pre-splitoff translations update
2020-10-27 19:40:44 +01:00
Makefile.qt.include
Merge bitcoin-core/gui#313: qt: Optimize string concatenation by default
2021-05-26 15:01:18 +02:00
Makefile.qttest.include
test: remove qt byteswap compattests
2021-03-29 11:12:26 +08:00
Makefile.test_fuzz.include
build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
2021-03-04 12:34:46 +08:00
Makefile.test_util.include
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
Makefile.test.include
Add unit tests for serfloat module
2021-05-24 16:04:44 -07:00
mapport.cpp
refactor: Use appropriate thread constructor
2021-04-29 18:39:01 +03:00
mapport.h
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
memusage.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
merkleblock.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
merkleblock.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
miner.cpp
miner: Pass in previous CBlockIndex to RegenerateCommitments
2021-04-05 11:13:51 -04:00
miner.h
miner: Pass in previous CBlockIndex to RegenerateCommitments
2021-04-05 11:13:51 -04:00
net_permissions.cpp
p2p: pass strings to NetPermissions::TryParse functions by const ref
2021-05-19 19:41:05 +02:00
net_permissions.h
p2p: pass strings to NetPermissions::TryParse functions by const ref
2021-05-19 19:41:05 +02:00
net_processing.cpp
Merge bitcoin/bitcoin#21992: p2p: Remove -feefilter option
2021-05-25 08:42:30 +02:00
net_processing.h
[net processing] Add internal _RelayTransactions()
2021-05-04 09:31:03 +01:00
net_types.h
refactor: Remove addrdb.h dependency from node.h
2019-10-29 11:30:12 +02:00
net.cpp
Merge bitcoin/bitcoin#22013: net: ignore block-relay-only peers when skipping DNS seed
2021-05-24 20:42:08 +08:00
net.h
Merge bitcoin/bitcoin#21186: net/net processing: Move addr data into net_processing
2021-05-24 20:28:31 +08:00
netaddress.cpp
net: Return IPv6 scope id in CNetAddr::ToStringIP()
2021-05-18 21:01:32 +02:00
netaddress.h
net: extend CNetAddr::SetSpecial() to support I2P
2021-03-01 13:22:11 +01:00
netbase.cpp
Merge #21387: p2p: Refactor sock to add I2P fuzz and unit tests
2021-03-30 17:41:13 +02:00
netbase.h
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
netmessagemaker.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
outputtype.cpp
refactor: Use C++17 std::array deduction for OUTPUT_TYPES
2021-01-03 18:37:59 +01:00
outputtype.h
refactor: Use C++17 std::array deduction for OUTPUT_TYPES
2021-01-03 18:37:59 +01:00
pow.cpp
…
pow.h
…
prevector.h
prevector: Avoid unnamed struct, which is a GNU extension
2020-04-30 18:02:03 +08:00
protocol.cpp
refactor: Replace memset calls with array initialization
2021-05-13 12:42:21 +01:00
protocol.h
refactor: Replace memset calls with array initialization
2021-05-13 12:42:21 +01:00
psbt.cpp
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
psbt.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
pubkey.cpp
Merge bitcoin/bitcoin#21745: refactor: Add missing includes in pubkey.cpp/pubkey.h
2021-05-10 14:35:31 +02:00
pubkey.h
Merge bitcoin/bitcoin#21745: refactor: Add missing includes in pubkey.cpp/pubkey.h
2021-05-10 14:35:31 +02:00
random.cpp
refactor: Replace &foo[0] with foo.data()
2021-05-04 06:55:31 +02:00
random.h
Add templated GetRandomDuration<>
2020-04-30 09:19:14 -04:00
randomenv.cpp
rand: only try and use freeifaddrs if available
2021-03-29 11:08:29 +08:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
Merge #21391: [Bundle 5/n] Prune g_chainman usage in RPC modules
2021-04-17 17:37:37 +02:00
reverse_iterator.h
…
scheduler.cpp
test: Fix off-by-one in mockscheduler test RPC
2021-05-14 12:49:16 +02:00
scheduler.h
refactor: remove boost::thread_group usage
2021-01-29 15:39:44 +08:00
serialize.h
Remove support for double serialization
2021-05-24 16:15:05 -07:00
shutdown.cpp
move-only: Move AbortNode to shutdown
2021-04-04 18:08:36 +02:00
shutdown.h
move-only: Move AbortNode to shutdown
2021-04-04 18:08:36 +02:00
signet.cpp
Merge #21330: Deal with missing data in signature hashes more consistently
2021-04-13 10:24:31 +08:00
signet.h
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
span.h
Merge #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute
2020-11-25 15:18:33 +01:00
streams.h
streams: Accept URef obj for VectorReader unserialize
2021-05-05 20:19:03 +02:00
sync.cpp
refactor: remove straggling boost::mutex usage
2021-01-26 15:57:28 +08:00
sync.h
refactor: Remove negative lock annotations from globals
2021-04-05 08:42:15 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
timedata.cpp
Avoid the use of abs64 in timedata
2020-10-12 19:50:16 -07:00
timedata.h
…
tinyformat.h
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
torcontrol.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
torcontrol.h
tests: Add fuzzing harness for TorController
2021-03-02 12:21:32 +00:00
txdb.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
txdb.h
txdb: add CCoinsViewDB::ChangeCacheSize
2020-07-01 14:44:24 -04:00
txmempool.cpp
refactor: Make TraceThread a non-template free function
2021-04-25 12:28:44 +03:00
txmempool.h
txmempool: add thread safety annotations
2021-05-21 12:14:01 +10:00
txorphanage.cpp
scripted-diff: Update txorphanage naming convention
2021-02-27 01:08:09 +10:00
txorphanage.h
doc: Fix typos from codespell lint
2021-04-07 19:26:25 +01:00
txrequest.cpp
doc: Fix typos from codespell lint
2021-04-07 19:26:25 +01:00
txrequest.h
Report and verify expirations
2020-10-12 12:14:53 -07:00
uint256.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
uint256.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
undo.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
validation.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
validation.h
Remove -feefilter option
2021-05-19 16:55:03 +02:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbits.cpp
versionbits: simplify state transitions
2021-04-12 11:14:49 +10:00
versionbits.h
versionbits: Add support for delayed activation
2021-04-12 11:14:49 +10:00
versionbitsinfo.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00