MarcoFalke 45952dab9d Merge #20932: refactor: Replace fs::absolute calls with AbsPathJoin calls ...

da9caa1ced Replace fs::absolute calls with AbsPathJoin calls (Kiminuo)
66576c4fd5 test: Clear forced -walletdir setting after wallet init_tests (Kiminuo)

Pull request description:

  This adds better test coverage and will make it easier in #20744 to remove our dependency on the two-argument boost::filesystem::absolute() function which does not have a direct equivalent in C++17.

  This PR doesn't change behavior aside from adding an assert and fixing a test bug.

ACKs for top commit:
  jonatack:
    Code review ACK da9caa1ced only doxygen improvements since my last review per `git diff d867d7a da9caa1`
  MarcoFalke:
    review ACK da9caa1ced 📯
  ryanofsky:
    Code review ACK da9caa1ced. Just comment and test tweaks since previous review.

Tree-SHA512: c940ee60f3ba374d4927cf34cf12d27c4c735c94af591fbc0ca408c641b30f8f8fbcfe521d66bfbddf9877a1fc8cd99bd8a47ebcd2fa59789de6bd87a7b9cf4d

2021-01-21 18:48:03 +01:00

..

test

test: Clear forced -walletdir setting after wallet init_tests

2021-01-15 20:19:31 +01:00

bdb.cpp

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

bdb.h

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

coinselection.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

db.cpp

wallet: List all wallets in non-SQLite or non-BDB builds

2020-12-04 11:03:28 -04:00

db.h

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

dump.cpp

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

dump.h

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

feebumper.cpp

Merge #20584: Declare de facto const reference variables/member functions as const

2021-01-07 09:05:09 +01:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

…

init.cpp

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

interfaces.cpp

Merge #20275: wallet: List all wallets in non-SQLite and non-BDB builds

2020-12-12 09:20:11 +01:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

Replace fs::absolute calls with AbsPathJoin calls

2021-01-15 22:48:15 +01:00

load.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

rpcdump.cpp

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet

2020-11-09 20:19:00 +01:00

rpcwallet.cpp

Merge #20891: rpc: Remove deprecated bumpfee behavior

2021-01-19 17:33:18 +01:00

rpcwallet.h

Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)

2020-09-22 20:49:30 +02:00

salvage.cpp

refactor: Drop call to GetWalletEnv in wallet salvage code

2020-12-04 11:03:28 -04:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Merge #20403: wallet: upgradewallet fixes, improvements, test coverage

2020-11-25 12:46:27 +01:00

scriptpubkeyman.h

Merge #19935: Move SaltedHashers to separate file and add some new ones

2021-01-13 08:49:17 +01:00

sqlite.cpp

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

sqlite.h

doc: fix various typos

2021-01-04 12:31:31 +08:00

wallet.cpp

Replace fs::absolute calls with AbsPathJoin calls

2021-01-15 22:48:15 +01:00

wallet.h

Don't declare de facto const member functions as non-const

2020-12-06 18:44:25 +00:00

walletdb.cpp

doc: fix various typos

2021-01-04 12:31:31 +08:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

Replace fs::absolute calls with AbsPathJoin calls

2021-01-15 22:48:15 +01:00

wallettool.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

walletutil.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

walletutil.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00