highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-03 00:10:52 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/rpc
History
fanquake 337d6f35a2
Merge bitcoin/bitcoin#28291: rpc: removed StrFormatInternalBug quote delimitation 
6e8f6468cbf1320b70cf01333002a31b44cb7c33 removed StrFormatInternalBug quote delimitation (Reese Russell)

Pull request description:

  This PR rectifies an unnecessary set of quotes delimiting the contents of  ```StrFormatInternalBug```. This is a follow up to MarcoFalke https://github.com/bitcoin/bitcoin/pull/28123#discussion_r1297191493.  The method of action was to remove the escaped quotes that were a part of strprintf. A single functional test case was modified to reflect the new output format.

  ```STR_INTERNAL_BUG``` was applied to https://github.com/bitcoin/bitcoin/pull/28123 in ```std::string RPCArg::ToString(const bool oneline)``` in ```rpc/util.cpp```

  The results can be seen below.

  Previously
  ![image](https://github.com/bitcoin/bitcoin/assets/3104223/53f9ea59-317f-4c62-9fc1-04255eeb4641)

  This PR
  ![image](https://github.com/bitcoin/bitcoin/assets/3104223/5c6a3110-f1f3-4b3c-8e8a-9c8f1c3176e7)

  Additional context can be found here.
  https://github.com/bitcoin/bitcoin/pull/28123#discussion_r1271871716

  Thank you.

ACKs for top commit:
  MarcoFalke:
    review ACK 6e8f6468cbf1320b70cf01333002a31b44cb7c33
  stickies-v:
    ACK 6e8f6468cbf1320b70cf01333002a31b44cb7c33

Tree-SHA512: 35317e31a527630495b566407e37db9941dab7f81cfaeb1ea3309683c48e4273284645ad615f73e646a137b4f2ae35933603e9182a7dbdd22cac98d038c491dc
2023-09-05 11:41:02 +03:00
..
blockchain.cpp
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
blockchain.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
client.cpp
rpc: add test-only sendmsgtopeer rpc
2023-08-22 13:28:15 -04:00
client.h
refactor: rpc: hide and rename ParseNonRFCJSONValue()
2023-03-23 18:18:46 +00:00
external_signer.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
fees.cpp
rpc: Run type check against RPCArgs
2023-01-11 17:42:09 +01:00
mempool.cpp
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
mempool.h
…
mining.cpp
rpc: Add MaybeArg() and Arg() default helper
2023-08-24 10:44:45 +02:00
mining.h
…
net.cpp
rpc: add test-only sendmsgtopeer rpc
2023-08-22 13:28:15 -04:00
node.cpp
Merge bitcoin/bitcoin#28186: kernel: Prune leveldb headers
2023-08-07 22:31:46 +02:00
output_script.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
protocol.h
…
rawtransaction_util.cpp
Fix clang-tidy performance-unnecessary-copy-initialization warnings
2023-05-09 18:48:52 +02:00
rawtransaction_util.h
wallet: add outputs arguments to bumpfee and psbtbumpfee
2023-01-17 13:28:53 +02:00
rawtransaction.cpp
Update help text for spend and rawtransaction rpcs
2023-08-22 22:29:08 -04:00
register.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
request.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
request.h
…
server_util.cpp
refactor: Split util::AnyPtr into its own file
2023-05-20 12:03:33 +02:00
server_util.h
net: add Ensure{any}Banman
2023-02-09 17:14:01 -03:00
server.cpp
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
server.h
RPC: Add add OBJ_NAMED_PARAMS type
2023-05-03 11:27:51 -05:00
signmessage.cpp
…
txoutproof.cpp
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
util.cpp
Merge bitcoin/bitcoin#28291: rpc: removed StrFormatInternalBug quote delimitation
2023-09-05 11:41:02 +03:00
util.h
rpc: Add MaybeArg() and Arg() default helper
2023-08-24 10:44:45 +02:00