highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-16 18:39:59 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
46a9c73083e0d1c9b0f7cd74081853f951889604
bitcoin/src
History
merge-script eb51963d87 Merge bitcoin/bitcoin#31884: cmake: Make implicit libbitcoinkernel dependencies explicit 
3b42e05aa9 cmake: Make implicit `libbitcoinkernel` dependencies explicit (Hennadii Stepanov)
3fd64efb43 cmake: Avoid using `OBJECT` libraries (Hennadii Stepanov)

Pull request description:

  This PR fixes two regressions introduced in https://github.com/bitcoin/bitcoin/pull/30911.

  For example, on the master branch @ 28dec6c5f8:
  - first regression:
  ```
  $ cmake -B build -G "Ninja" -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=/home/hebasto/INSTALL
  $ cmake --build build -j $(nproc) -t libbitcoinkernel
  $ cmake --install build --component libbitcoinkernel
  - Install configuration: "RelWithDebInfo"
  CMake Error at build/src/kernel/cmake_install.cmake:46 (file):
    file INSTALL cannot find
    "/home/hebasto/dev/bitcoin/build/src/crypto/libbitcoin_crypto.a": No such
    file or directory.
  Call Stack (most recent call first):
    build/src/cmake_install.cmake:172 (include)
    build/cmake_install.cmake:57 (include)

  ```

  - second regression:
  ```
  $ cmake -B build -G "Unix Makefiles" -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=/home/hebasto/INSTALL
  $ cmake --build build -j $(nproc) -t libbitcoinkernel
  ...
  gmake[3]: *** No rule to make target 'src/CMakeFiles/bitcoin_clientversion.dir/clientversion.cpp.o', needed by 'src/kernel/libbitcoinkernel.a'.  Stop.
  gmake[2]: *** [CMakeFiles/Makefile2:1360: src/kernel/CMakeFiles/bitcoinkernel.dir/all] Error 2
  gmake[1]: *** [CMakeFiles/Makefile2:1367: src/kernel/CMakeFiles/bitcoinkernel.dir/rule] Error 2
  gmake: *** [Makefile:647: bitcoinkernel] Error 2
  ```

  With this PR:
  ```
  $ cmake -B build -G "Ninja" -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=/home/hebasto/INSTALL
  $ cmake --build build -j $(nproc) -t libbitcoinkernel
  $ cmake --install build --component libbitcoinkernel
  ```
  and
  ```
  $ cmake -B build -G "Unix Makefiles" -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=/home/hebasto/INSTALL
  $ cmake --build build -j $(nproc) -t libbitcoinkernel
  $ cmake --install build --component libbitcoinkernel
  ```

  ---

  **A note for reviewers:** An alternative approach would be to disable the `OPTIMIZE_DEPENDENCIES` property for the `bitcoinkernel` target. However, I contend that this PR is preferable because (1) it preserves parallel builds for the `libbitcoinkernel` target, and (2) the resulting code has one less workaround for a CMake bug.

ACKs for top commit:
  TheCharlatan:
    ACK 3b42e05aa9
  theuni:
    utACK 3b42e05aa9

Tree-SHA512: 73e9da845688a02e5d61770b7cfd5e1a17440182eb524c7329a47df8f1daa6fe0f9cbde5274832bf43f52e17de86473881dc876dee4276c9c06b173b1b78b7a2
2025-02-20 12:08:35 -05:00
..
bench
cmake: add and use install_binary_component
2025-02-13 18:14:41 +00:00
common
net: Use mockable steady clock in PCP implementation
2025-01-13 21:53:56 +01:00
compat
…
consensus
Check leaves size maximum in MerkleComputation
2024-12-17 10:12:31 +07:00
crc32c
…
crypto
cmake: add optional source files to bitcoin_crypto directly
2025-02-07 09:11:27 +01:00
index
scripted-diff: rename block and undo functions for consistency
2025-01-09 15:17:02 +01:00
init
refactor: Avoid using IsArgSet() on -debug, -loglevel, and -vbparams list options
2025-02-13 12:30:15 -05:00
interfaces
Merge bitcoin/bitcoin#31157: Cleanups to port mapping module post UPnP drop
2025-02-14 11:15:53 +01:00
ipc
Merge bitcoin/bitcoin#31384: mining: bugfix: Fix duplicate coinbase tx weight reservation
2025-02-10 08:26:01 -05:00
kernel
cmake: Make implicit libbitcoinkernel dependencies explicit
2025-02-18 12:30:41 +00:00
leveldb
Update leveldb subtree to latest upstream
2025-01-16 11:09:56 +00:00
logging
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
minisketch
Update minisketch subtree to latest master
2024-06-12 14:38:39 +01:00
node
Merge bitcoin/bitcoin#31157: Cleanups to port mapping module post UPnP drop
2025-02-14 11:15:53 +01:00
policy
miner: init: add -blockreservedweight startup option
2025-02-04 11:53:11 -05:00
primitives
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
qt
Revert "cmake: Ensure generated sources are up to date for translate target"
2025-02-18 16:05:08 +00:00
rpc
Merge bitcoin/bitcoin#31384: mining: bugfix: Fix duplicate coinbase tx weight reservation
2025-02-10 08:26:01 -05:00
script
miniscript: Make NodeRef a unique_ptr
2025-01-21 13:17:20 -05:00
secp256k1
Update secp256k1 subtree to v0.6.0
2024-11-04 14:59:46 -05:00
support
util: Add missing types in make_secure_unique
2024-12-10 21:51:48 +01:00
test
Merge bitcoin/bitcoin#30746: test: cover base[32|58|64] with symmetric roundtrip fuzz (and padding) tests
2025-02-14 14:48:01 -08:00
univalue
test: clang-format -i src/univalue/test/unitester.cpp
2024-12-20 15:01:44 +01:00
util
cmake: Avoid using OBJECT libraries
2025-02-18 12:29:18 +00:00
wallet
Merge bitcoin/bitcoin#31794: wallet: abandon orphan coinbase txs, and their descendants, during startup
2025-02-18 18:39:00 -08:00
zmq
cmake: Add FindZeroMQ module
2024-10-25 18:09:36 +01:00
.clang-format
…
.clang-tidy
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
addrdb.cpp
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
addrdb.h
…
addresstype.cpp
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addresstype.h
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addrman_impl.h
Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t
2024-09-20 12:55:22 -04:00
addrman.cpp
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
addrman.h
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
arith_uint256.cpp
Add a fuzz test for Num3072 multiplication and inversion
2025-01-09 10:11:46 -05:00
arith_uint256.h
doc: Clarify comments about endianness after #30526
2025-01-03 09:19:53 -05:00
attributes.h
…
banman.cpp
refactor: Delay translation of _() literals
2025-01-14 19:21:37 +01:00
banman.h
…
base58.cpp
refactor: Avoid needless, unsafe c-style cast
2024-12-19 13:46:31 +01:00
base58.h
…
bech32.cpp
Split out bech32 separator char to header
2024-10-19 18:49:53 +02:00
bech32.h
Split out bech32 separator char to header
2024-10-19 18:49:53 +02:00
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
bitcoin-cli-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-cli.cpp
Fix nonsensical bitcoin-cli -norpcwallet behavior
2025-02-13 12:30:15 -05:00
bitcoin-tx-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-tx.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-util-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-util.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-wallet-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-wallet.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoind-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoind.cpp
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
blockencodings.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
blockencodings.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
doc: update NeedsRedownload() comment
2024-09-17 09:54:18 +02:00
chainparams.cpp
refactor: Avoid using IsArgSet() on -signetseednode and -signetchallenge list options
2025-02-13 12:30:15 -05:00
chainparams.h
…
chainparamsbase.cpp
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsbase.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsseeds.h
seeds: Regenerate mainnet seeds
2024-08-27 07:00:27 +02:00
checkqueue.h
Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
2024-12-03 18:02:37 -05:00
clientversion.cpp
refactor: Delay translation of _() literals
2025-01-14 19:21:37 +01:00
clientversion.h
scripted-diff: Clarify "user agent" variable name
2024-10-28 12:35:49 +00:00
cluster_linearize.h
doc: correct typos
2024-11-11 14:14:39 +00:00
CMakeLists.txt
Merge bitcoin/bitcoin#31884: cmake: Make implicit libbitcoinkernel dependencies explicit
2025-02-20 12:08:35 -05:00
coins.cpp
Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests
2024-12-04 14:09:05 -05:00
coins.h
coins, refactor: Remove direct GetFlags access
2024-12-02 13:52:34 +01:00
compressor.cpp
…
compressor.h
…
core_io.h
rpc: add getdescriptoractivity
2024-11-26 20:47:08 -05:00
core_memusage.h
…
core_read.cpp
ci: Update Clang in "tidy" job
2024-12-05 14:37:47 +00:00
core_write.cpp
…
cuckoocache.h
validation: Don't error if maxsigcachesize exceeds uint32::max
2024-07-04 22:35:29 +02:00
dbwrapper.cpp
dbwrapper: Bump max file size to 32 MiB
2024-11-30 20:19:08 +01:00
dbwrapper.h
dbwrapper: Bump max file size to 32 MiB
2024-11-30 20:19:08 +01:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
external_signer.h
…
flatfile.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
flatfile.h
refactor: Add FlatFileSeq member variables in BlockManager
2024-07-24 09:39:35 +02:00
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 2f2ccc46954..0cdc758a563
2024-11-04 14:59:46 -05:00
headerssync.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
headerssync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
httprpc.cpp
Fix nonsensical -norpcwhitelist behavior
2025-02-13 12:30:15 -05:00
httprpc.h
…
httpserver.cpp
Fix nonsensical -norpcbind and -norpcallowip behavior
2025-02-13 12:30:15 -05:00
httpserver.h
rpc: increase the defaults for -rpcthreads and -rpcworkqueue
2024-11-04 17:08:21 +01:00
i2p.cpp
Merge bitcoin/bitcoin#29833: i2p: fix and improve logs
2024-06-26 15:28:26 -04:00
i2p.h
i2p: log errors properly according to their severity
2024-06-12 16:19:50 -03:00
indirectmap.h
…
init.cpp
refactor: Avoid using IsArgSet() on -connect list option
2025-02-13 12:30:15 -05:00
init.h
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
key_io.cpp
key: clear out secret data in DecodeExtKey
2024-10-27 15:38:54 +01:00
key_io.h
…
key.cpp
refactor: remove un-tested early returns
2024-08-04 08:52:22 +02:00
key.h
refactor: move SignSchnorr to KeyPair
2024-08-04 08:51:36 +02:00
logging.cpp
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
logging.h
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
mapport.cpp
mapport: make ProcessPCP void
2024-11-04 14:19:40 -05:00
mapport.h
mapport: rename 'use_pcp' to 'enable'
2024-10-29 11:58:51 -04:00
memusage.h
memusage: Add DynamicUsage for std::string
2024-11-04 18:46:40 +01:00
merkleblock.cpp
…
merkleblock.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
tracing: add misbehaving conn tracepoint
2025-02-04 10:25:22 +01:00
net_processing.h
net: add GetOrphanTransactions() to PeerManager
2024-10-01 21:55:18 -04:00
net_types.cpp
…
net_types.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net.cpp
Merge bitcoin/bitcoin#30529: Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior
2025-02-14 15:10:09 -08:00
net.h
net: reduce CAddress usage to CService or CNetAddr
2025-02-13 12:38:55 +01:00
netaddress.cpp
net: Add optional length checking to CService::SetSockAddr
2025-01-13 21:53:56 +01:00
netaddress.h
net: Add optional length checking to CService::SetSockAddr
2025-01-13 21:53:56 +01:00
netbase.cpp
scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
2024-10-10 12:22:12 +02:00
netbase.h
net: add All() in ReachableNets
2024-09-10 11:20:40 -03:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
consensus: add DeriveTarget() to pow.h
2025-01-22 11:29:05 +01:00
pow.h
consensus: add DeriveTarget() to pow.h
2025-01-22 11:29:05 +01:00
prevector.h
prevector: avoid GCC bogus warnings in insert method
2024-09-11 17:41:26 +02:00
protocol.cpp
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
protocol.h
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
psbt.cpp
…
psbt.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
pubkey.cpp
refactor: Use immediate lambda to work around GCC bug 117966
2024-12-16 10:39:28 +01:00
pubkey.h
refactor: Make XOnlyPubKey tolerate constexpr std::arrays
2024-08-28 19:09:51 +02:00
random.cpp
Revert "Merge bitcoin/bitcoin#31826: random: Check GetRNDRRS is supported in InitHardwareRand to avoid infinite loop"
2025-02-19 10:28:13 -05:00
random.h
refactor: Drop unused UCharCast
2025-01-14 19:01:53 +01:00
randomenv.cpp
util: Remove RandAddSeedPerfmon
2024-10-21 23:24:17 +02:00
randomenv.h
…
rest.cpp
Merge bitcoin/bitcoin#31583: rpc: add target to getmininginfo field and show next block info
2025-01-22 15:01:23 -05:00
rest.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Allow std::span in stream serialization
2024-12-19 14:41:21 +01:00
signet.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
signet.h
…
span.h
refactor: Simplify SpanPopBack
2024-12-19 13:46:52 +01:00
streams.cpp
streams: add DataStream::GetMemoryUsage
2024-11-04 18:46:40 +01:00
streams.h
refactor: Avoid passing span iterators when data pointers are expected
2024-12-19 14:39:55 +01:00
sync.cpp
…
sync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
threadsafety.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
tinyformat.h
refactor: Introduce struct to hold a runtime format string
2025-01-15 12:16:08 +01:00
torcontrol.cpp
Normalize inconsistent -noonlynet behavior
2025-02-13 12:30:15 -05:00
torcontrol.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
txdb.cpp
refactor: Rely on returned value of GetCoin instead of parameter
2024-09-18 20:03:47 +02:00
txdb.h
kernel: Move default cache constants to caches
2025-01-15 15:44:55 +01:00
txmempool.cpp
txmempool: fix typos in comments
2024-12-31 00:04:20 -03:00
txmempool.h
txmempool: fix typos in comments
2024-12-31 00:04:20 -03:00
txorphanage.cpp
[fuzz] TxOrphanage::SanityCheck accounting
2025-02-07 13:55:57 -05:00
txorphanage.h
[fuzz] TxOrphanage::SanityCheck accounting
2025-02-07 13:55:57 -05:00
txrequest.cpp
[refactor] make GetCandidatePeers take uint256 and in-out vector
2025-01-29 18:05:16 -05:00
txrequest.h
[refactor] make GetCandidatePeers take uint256 and in-out vector
2025-01-29 18:05:16 -05:00
uint256.cpp
scripted-diff: Rename SetHex to SetHexDeprecated
2024-07-24 09:15:34 +02:00
uint256.h
doc: Clarify comments about endianness after #30526
2025-01-03 09:19:53 -05:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#31439: validation: In case of a continued reindex, only activate chain in the end
2025-02-14 13:59:34 -08:00
validation.h
Merge bitcoin/bitcoin#31483: kernel: Move kernel-related cache constants to kernel cache
2025-01-16 15:04:58 +00:00
validationinterface.cpp
refactor: include the proper header rather than forward-declaring RemovalReasonToString
2024-10-08 15:25:47 +00:00
validationinterface.h
[refactor] change ActiveTipChange to use CBlockIndex ref instead of ptr
2024-07-25 11:01:22 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00