mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-27 01:31:08 +01:00
630756cac0
8c47d599b8doc: improve -debuglogfile help to be a bit clearer (jonatack)20d89d6802bench: document expected results in logging benchmarks (jonatack)d8deba8c36bench: add LogPrintfCategory and LogPrintLevel benchmarks (Jon Atack)102b203349bench: order the logging benchmark code by output (Jon Atack)4b3fdbf6febench: update logging benchmark naming for clarity (Jon Atack)4684aa8733bench: allow logging benchmarks to be order-independent (Larry Ruane) Pull request description: Update our logging benchmarks for evaluating ongoing work like #25203 and refactoring proposals like #26619 and #26697. - make the logging benchmarks order-independent (Larry Ruane) - add missing benchmarks for the `LogPrintLevel` and `LogPrintfCategory` macros that our logging is migrating to; at some later point it should be feasible to drop some of the previous logging benchmarks - update the logging benchmark naming to be clear which benchmark corresponds to which log macro, and update the ordering to be the same as the output - add clarifying documentation to the logging benchmarks - improve the `-debuglogfile` config option help to be clearer; can be tested by running `./src/bitcoind -help | grep -A4 '\-debuglogfile'` Reviewers can run the logging benchmarks with: ```bash ./src/bench/bench_bitcoin -filter='LogP*.*' ``` ACKs for top commit: LarryRuane: ACK8c47d599b8martinus: code review & tested ACK8c47d599b8, here are my benchmark results: achow101: ACK8c47d599b8Tree-SHA512: 705f8720c9ceaf14a1945039c7578a0c17a12215cbc44908099af4ac444561c3f95d833c5a91b325cdd4470737d8a01e2da64db2d542dd7c9a3747fbfdbf213e