Ava Chow 7f28e80329 Merge bitcoin/bitcoin#32758: wallet: remove dead code in legacy wallet migration ...

150b5c99ca wallet: replace `reload_wallet` with inline functionality (rkrux)
0f86da382d wallet: remove dead code in legacy wallet migration (rkrux)

Pull request description:

  A discussion on a previous [PR 32481](https://github.com/bitcoin/bitcoin/pull/32481#discussion_r2145152084) related to legacy wallet dead
  code removal made me realize that checking if the legacy
  wallet was loaded prior to the start of the migration is not
  required ever since legacy wallets can't be loaded in the first
  place. I also verified that the `load_on_start` persistent
  setting can also not cause the legacy wallets to be loaded, which
  further makes the case for removal of the above mentioned checks
  during migration.
  The current test coverage also shows these lines uncovered.

ACKs for top commit:
  achow101:
    ACK 150b5c99ca
  furszy:
    ACK 150b5c99ca

Tree-SHA512: 9bc7043cac1f4051228557208895e43648de3c7ffae6860c0676d1aa2db3a8ed3a09d1f9defacd96ca50bbb9699ba86652ccb0c5e55cc88be248a1fe727c13d9

2025-07-10 14:41:44 -07:00

..

rpc

Merge bitcoin/bitcoin#32862: rpc: use CScheduler for relocking wallet and remove RPCTimer

2025-07-07 17:59:21 -07:00

test

Merge bitcoin/bitcoin#29307: util: explicitly close all AutoFiles that have been written

2025-07-03 15:37:44 -07:00

CMakeLists.txt

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

coincontrol.cpp

…

coincontrol.h

wallet, spend: Remove fWatchOnly from CCoinControl

2025-07-01 11:26:42 -07:00

coinselection.cpp

…

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

wallet: refactor: introduce CMasterKey::DEFAULT_DERIVE_ITERATIONS constant

2025-01-27 18:11:05 +01:00

db.cpp

log: Use warning level while scanning wallet dir

2025-06-13 13:55:54 +02:00

db.h

Merge bitcoin/bitcoin#31423: wallet: migration, avoid creating spendable wallet from a watch-only legacy wallet

2025-07-02 13:25:33 -07:00

dump.cpp

doc: fix typos

2025-06-03 08:09:28 +01:00

dump.h

…

external_signer_scriptpubkeyman.cpp

wallet: use PSBTError::EXTERNAL_SIGNER_NOT_FOUND

2025-06-05 11:46:08 +02:00

external_signer_scriptpubkeyman.h

refactor: use util::Result for GetExternalSigner()

2025-06-05 11:32:23 +02:00

feebumper.cpp

Merge bitcoin/bitcoin#31622: psbt: add non-default sighash types to PSBTs and unify sighash type match checking

2025-05-21 10:02:49 +01:00

feebumper.h

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

fees.cpp

…

fees.h

…

init.cpp

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

interfaces.cpp

wallet, interfaces: Use BERKELEY_RO in isEncrypted

2025-06-04 16:51:51 -07:00

load.cpp

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets

2025-06-02 13:31:35 -07:00

load.h

wallet: Remove unnecessary database Close step on shutdown

2025-05-14 11:03:57 -07:00

migrate.cpp

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

migrate.h

wallet: introduce method to return all db created files

2025-05-28 05:55:27 -04:00

receive.cpp

wallet: Remove watchonly balances

2025-07-01 11:10:25 -07:00

receive.h

wallet: Remove watchonly balances

2025-07-01 11:10:25 -07:00

scriptpubkeyman.cpp

wallet: Remove ISMINE_WATCH_ONLY

2025-07-01 11:26:42 -07:00

scriptpubkeyman.h

wallet, refactor: Remove unused SetupGeneration

2025-06-10 16:34:17 -03:00

spend.cpp

wallet, spend: Remove fWatchOnly from CCoinControl

2025-07-01 11:26:42 -07:00

spend.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

sqlite.cpp

Merge bitcoin/bitcoin#31423: wallet: migration, avoid creating spendable wallet from a watch-only legacy wallet

2025-07-02 13:25:33 -07:00

sqlite.h

wallet: introduce method to return all db created files

2025-05-28 05:55:27 -04:00

transaction.cpp

wallet: IsEquivalentTo should strip witness data in addition to scriptsigs

2025-06-10 21:25:14 +00:00

transaction.h

wallet: Remove unused CachedTxGet{Available,Immature}Credit

2025-06-25 14:08:49 -07:00

types.h

wallet: Remove ISMINE_WATCH_ONLY

2025-07-01 11:26:42 -07:00

wallet.cpp

Merge bitcoin/bitcoin#32758: wallet: remove dead code in legacy wallet migration

2025-07-10 14:41:44 -07:00

wallet.h

wallet: remove dead code in legacy wallet migration

2025-07-03 14:27:47 +05:30

walletdb.cpp

walletdb: Load Txs last

2025-06-25 14:08:49 -07:00

walletdb.h

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

wallettool.cpp

Remove create options from wallet tool

2025-05-09 15:07:04 +02:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…