fanquake 479ecc0515
Merge bitcoin/bitcoin#29192 : Weaken serfloat tests ...
6e873df347b45f1f5658Closes #28941 .
Our current tests for serfloat verify two distinct properties:
1. Whether they roundtrip `double`->`uint64_t`->`double` (excluding NaN values) on all systems.
2. Whether on systems with a typical floating point unit that encoding matches the hardware representation, as before v22.0, we would dump the hardware representation directly to disk and we wanted to retain compatibility with that.
#28941 seems to show that the second property doesn't always hold, but just for "subnormal" numbers (below $2^{-1021}$). Since we don't care about encoding these numbers, we could exclude such subnormal numbers from the hardware-identical representation test, but this PR goes further and just drops the second property entirely, as I don't think we care about edge-case compatibility with pre-v22.0 code for fee_estimates.dat (the only place it is used).
ACKs for top commit:
glozow:
ACK 6e873df3476e873df347
2024-03-19 17:09:07 +00:00
2024-03-11 09:59:35 -04:00
2024-03-11 10:29:31 -04:00
2024-03-01 13:13:07 -05:00
2023-11-16 11:36:22 +10:00
2024-02-27 18:28:19 +00:00
2024-03-01 11:19:58 -05:00
2024-03-11 13:49:37 +01:00
2024-01-11 11:01:28 -06:00
2024-01-05 10:42:10 +00:00
2023-11-28 12:35:50 -05:00
2024-03-11 13:49:37 +01:00
2024-03-18 18:24:06 +00:00
2024-03-01 15:23:03 +00:00
2024-02-27 14:19:15 +00:00
2024-03-13 06:53:07 -04:00
2024-03-18 18:24:06 +00:00
2024-03-15 13:34:05 +00:00
2024-01-04 14:40:28 +00:00
2024-02-13 20:10:44 +00:00
2024-03-19 17:09:07 +00:00
2023-07-27 14:24:52 +02:00
2024-03-14 15:53:43 +01:00
2024-03-11 08:59:06 -04:00
2024-03-12 12:46:46 -04:00
2023-10-12 11:27:19 +02:00
2023-12-15 15:20:54 +01:00
2024-03-15 13:34:05 +00:00
2024-03-12 10:05:06 +00:00
2023-09-05 10:13:25 +02:00
2023-09-12 12:14:31 -04:00
2023-10-25 22:46:55 +02:00
2023-10-04 18:08:49 +02:00
2024-02-20 13:07:48 +00:00
2024-01-15 16:19:53 -05:00
2023-11-21 17:37:25 +01:00
2023-11-21 17:37:25 +01:00
2023-11-02 14:09:27 -04:00
2023-11-02 14:09:27 -04:00
2023-09-10 16:11:52 -04:00
2023-09-10 16:11:52 -04:00
2024-02-16 17:12:52 +01:00
2024-01-09 15:27:08 -06:00
2023-12-11 13:08:46 -05:00
2023-11-16 11:36:22 +10:00
2023-12-04 15:39:15 -04:00
2023-11-16 11:14:13 +10:00
2023-11-14 08:45:30 +10:00
2023-11-28 12:42:07 +01:00
2023-08-17 18:28:15 +02:00
2024-02-01 13:52:05 +01:00
2024-03-04 19:53:30 -05:00
2023-10-03 10:52:17 +01:00
2024-02-13 20:10:44 +00:00
2023-11-21 13:15:44 +00:00
2023-11-24 14:41:58 +00:00
2023-08-14 17:38:27 -04:00
2023-12-11 18:22:13 +01:00
2023-11-16 11:36:22 +10:00
2023-12-11 18:22:13 +01:00
2023-09-12 12:07:39 +02:00
2023-09-12 12:07:39 +02:00
2023-11-30 11:28:19 +01:00
2024-03-11 13:49:37 +01:00
2024-01-05 17:12:38 +01:00
2023-11-16 11:36:22 +10:00
2024-02-01 13:52:05 +01:00
2023-09-19 15:54:17 -06:00
2024-01-10 14:11:32 -05:00
2023-12-04 15:39:15 -04:00
2024-03-13 06:53:07 -04:00
2024-03-01 14:47:29 -05:00
2024-03-13 06:53:07 -04:00
2023-12-04 15:39:15 -04:00
2024-01-16 15:29:18 +01:00
2023-08-14 17:38:27 -04:00
2024-01-16 15:29:18 +01:00
2024-01-16 15:29:18 +01:00
2023-12-15 11:03:25 +10:00
2024-03-12 16:26:15 +01:00
2024-03-08 20:58:04 -05:00
2024-02-28 17:23:54 +00:00
2024-03-04 10:02:26 +00:00
2023-10-19 13:25:49 +01:00
2023-11-20 15:57:50 -03:00
2023-07-19 10:26:11 +01:00
2024-02-03 17:59:43 +01:00
2023-09-13 11:37:45 +01:00
2023-11-28 17:49:41 +01:00
2023-11-28 17:49:41 +01:00
2024-02-28 10:05:56 -03:00
2024-02-28 10:05:56 -03:00
2024-03-13 07:26:34 -04:00
2024-01-15 10:28:20 -03:00
2024-03-13 06:53:07 -04:00
2024-02-28 10:05:56 -03:00
2024-03-01 13:13:07 -05:00
2024-03-01 13:13:07 -05:00
2024-03-13 14:09:50 -04:00
2024-03-01 14:47:28 -05:00
2023-12-06 11:22:42 -05:00
2023-12-02 22:03:08 +01:00
2023-11-20 14:02:27 +01:00
2023-08-14 17:38:27 -04:00
2023-08-14 17:38:27 -04:00
2024-01-18 19:29:34 +01:00
2024-01-23 10:25:16 -03:00
2024-01-23 10:25:16 -03:00
2023-11-30 11:28:19 +01:00
2023-11-28 12:42:07 +01:00
2023-10-08 02:43:19 +02:00
2024-01-16 10:58:57 +01:00
2024-02-13 20:10:44 +00:00
2024-02-26 16:13:12 +00:00
2023-09-12 22:51:48 +02:00
2024-03-12 12:48:04 -04:00
2024-02-15 14:43:14 +01:00
2024-02-16 17:12:52 +01:00
2024-03-01 11:19:58 -05:00
2023-11-28 12:42:07 +01:00
2023-12-22 09:58:19 +01:00
2023-07-19 18:12:42 +02:00
2023-11-30 11:27:54 +01:00
2024-02-13 20:10:44 +00:00
2023-10-26 15:02:13 -04:00
2024-01-05 17:16:38 +00:00
2024-02-01 13:52:05 +01:00
2024-01-10 14:11:32 -05:00
2023-08-17 23:58:47 -05:00
2023-09-05 11:37:35 +01:00
2023-08-01 15:27:33 +02:00
2024-02-15 13:28:45 +01:00
2024-02-15 14:45:51 +01:00
2023-12-08 13:14:46 +00:00
2023-12-08 13:14:46 +00:00
2023-12-07 11:06:01 +01:00
2023-06-28 15:12:12 -04:00
2023-11-16 11:36:22 +10:00
2024-03-18 18:24:06 +00:00
2024-03-18 18:24:06 +00:00
2024-02-16 17:12:52 +01:00
2024-02-16 17:12:52 +01:00
2024-02-13 20:10:44 +00:00
479ecc0515