highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-24 07:51:24 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
fanquake 48cb468ce3
Merge #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache 
0a433fc876d82df1005f175c1254fff62f0f36f8 [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCache (John Newbery)

Pull request description:

  CheckInputsFromMempoolAndCache() is only called in one place, and
  cacheSigStore is set to true in that call site. Remove the argument
  entirely.

  Also improve commenting.

ACKs for top commit:
  MarcoFalke:
    unsigned ACK 0a433fc876d82df1005f175c1254fff62f0f36f8 Comment looks good
  jamesob:
    ACK 0a433fc876
  laanwj:
    ACK 0a433fc876d82df1005f175c1254fff62f0f36f8
  fanquake:
    ACK 0a433fc876d82df1005f175c1254fff62f0f36f8. Checked that `CheckInputsFromMempoolAndCache` is only called once, in `MemPoolAccept::ConsensusScriptChecks`, and that `cacheSigStore` is true.

Tree-SHA512: e4b4d2550e35df55c8f8fa4c539174cc2d3728112ddb937cb2ff759d8630a01566b5ec42a70a82e33994e6586f5a457a75a59f64b15d27c65331c723cbb097af
2019-10-25 08:14:11 -04:00
..
bench
refactor: test/bench: dedup Build{Crediting,Spending}Transaction()
2019-10-23 01:59:32 +02:00
compat
build: Fix #include sys/poll.h to just poll.h (without sys/)
2019-10-09 13:30:36 +02:00
config
…
consensus
consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it
2019-10-24 14:58:34 -04:00
crypto
Remove unused includes
2019-10-15 22:56:43 +00:00
index
Remove unused includes
2019-10-15 22:56:43 +00:00
interfaces
Merge #17154: wallet: Remove return value from CommitTransaction
2019-10-24 10:16:12 +02:00
leveldb
…
node
Remove unused includes
2019-10-15 22:56:43 +00:00
policy
Remove unused includes
2019-10-15 22:56:43 +00:00
primitives
Remove unused includes
2019-10-15 22:56:43 +00:00
qt
Merge #17226: gui: Fix payAmount tooltip in SendCoinsEntry
2019-10-24 13:41:25 +02:00
rpc
Merge #17004: validation: Remove REJECT code from CValidationState
2019-10-24 10:49:45 +02:00
script
Merge #16889: Add some general std::vector utility functions
2019-10-18 09:57:00 -04:00
secp256k1
…
support
Improve documentation of memory_cleanse()
2019-07-01 12:59:44 +02:00
test
Merge #17220: tests: Add unit testing for the CompressScript function
2019-10-25 13:55:58 +02:00
univalue
…
util
Merge #17004: validation: Remove REJECT code from CValidationState
2019-10-24 10:49:45 +02:00
wallet
Merge #17154: wallet: Remove return value from CommitTransaction
2019-10-24 10:16:12 +02:00
zmq
Remove unused includes
2019-10-15 22:56:43 +00:00
.clang-format
util: Add AllowShortCaseLabelsOnASingleLine option
2019-10-14 13:24:54 +03:00
addrdb.cpp
addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests.
2019-06-14 08:30:43 +02:00
addrdb.h
…
addrman.cpp
…
addrman.h
…
amount.h
…
arith_uint256.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
arith_uint256.h
Remove unused includes
2019-10-15 22:56:43 +00:00
attributes.h
…
banman.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
bech32.h
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #16659: refactoring: Remove unused includes
2019-10-16 17:33:57 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
bitcoind-res.rc
…
bitcoind.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
blockencodings.cpp
…
blockencodings.h
Remove unused includes
2019-10-15 22:56:43 +00:00
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
chain: Set all CBlockIndex members to null, remove SetNull helper
2019-10-16 13:06:50 -04:00
chainparams.cpp
chainparams: Bump assumed chain params
2019-10-01 07:33:24 -04:00
chainparams.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsbase.cpp
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
2019-09-06 22:05:33 +02:00
chainparamsbase.h
Remove wallet settings from chainparams
2019-07-16 16:22:14 -04:00
chainparamsseeds.h
contrib: Remove invalid nodes from seeds list
2019-10-02 08:51:12 +02:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
2019-07-21 21:00:31 -04:00
coins.h
make SaltedOutpointHasher noexcept
2019-09-25 20:56:38 +02:00
compat.h
…
compressor.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
Don't show addresses or P2PK in decoderawtransaction
2019-08-30 11:29:21 +09:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
Remove unused includes
2019-10-15 22:56:43 +00:00
dummywallet.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
flatfile.cpp
Style cleanup.
2019-02-22 17:38:45 -08:00
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
httprpc.h
Remove unused includes
2019-10-15 22:56:43 +00:00
httpserver.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
httpserver.h
Remove unused includes
2019-10-15 22:56:43 +00:00
indirectmap.h
…
init.cpp
p2p: Remove BIP61 reject messages
2019-10-02 10:39:14 -04:00
init.h
…
key_io.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
key_io.h
…
key.cpp
…
key.h
refactor: Remove unused CExt{Pub,}Key (de)serialization methods
2019-10-22 00:07:31 +02:00
limitedmap.h
…
logging.cpp
util: Filter control characters out of log messages
2019-10-15 10:53:17 +02:00
logging.h
test: Log to debug.log in all tests
2019-06-20 12:12:24 -04:00
Makefile.am
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
Makefile.bench.include
refactor: test/bench: dedup Build{Crediting,Spending}Transaction()
2019-10-23 01:59:32 +02:00
Makefile.leveldb.include
…
Makefile.qt_locale.include
qt: Periodic translations update
2019-09-30 09:41:11 +02:00
Makefile.qt.include
Always generate bitcoinstrings.cpp on make translate
2019-10-07 15:38:07 +11:00
Makefile.qttest.include
…
Makefile.test.include
Merge #17018: tests: Add descriptor Parse(...) fuzzing harness
2019-10-23 12:42:48 -04:00
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
miner.h
…
net_permissions.cpp
util: Move ResolveErrMsg to util/error
2019-08-15 10:05:32 -04:00
net_permissions.h
Make whitebind/whitelist permissions more flexible
2019-08-11 11:33:27 +09:00
net_processing.cpp
Merge #16851: Continue relaying transactions after they expire from mapRelay
2019-10-24 17:50:42 -04:00
net_processing.h
p2p: Remove BIP61 reject messages
2019-10-02 10:39:14 -04:00
net.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
net.h
txmempool: Make entry time type-safe (std::chrono)
2019-09-23 08:00:14 -04:00
netaddress.cpp
Fix spelling errors identified by codespell 1.15.0
2019-06-11 17:18:16 +02:00
netaddress.h
Remove unused includes
2019-10-15 22:56:43 +00:00
netbase.cpp
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netbase.h
util: refactor upper/lowercase functions
2019-08-08 11:35:14 +09:00
netmessagemaker.h
…
noui.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
noui.h
Suppress output in test_bitcoin for expected errors
2019-07-03 14:03:21 +02:00
optional.h
…
outputtype.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
outputtype.h
Move various SigningProviders to signingprovider.{cpp,h}
2019-07-09 16:20:18 -04:00
pow.cpp
…
pow.h
…
prevector.h
Remove unused includes
2019-10-15 22:56:43 +00:00
protocol.cpp
p2p: Remove BIP61 reject messages
2019-10-02 10:39:14 -04:00
protocol.h
Remove unused includes
2019-10-15 22:56:43 +00:00
psbt.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
psbt.h
Fix bug where duplicate PSBT keys are accepted
2019-10-08 01:45:36 +03:00
pubkey.cpp
…
pubkey.h
refactor: Remove unused CExt{Pub,}Key (de)serialization methods
2019-10-22 00:07:31 +02:00
random.cpp
random: remove call to RAND_screen() (Windows only)
2019-10-18 14:24:21 -04:00
random.h
net: Use mockable time for tx download
2019-06-17 14:12:32 -04:00
rest.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Remove unused includes
2019-10-15 22:56:43 +00:00
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
Remove unused includes
2019-10-15 22:56:43 +00:00
sync.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
sync.h
refactor: consolidate PASTE macros
2019-09-25 10:56:00 -04:00
threadinterrupt.cpp
…
threadinterrupt.h
Remove unused includes
2019-10-15 22:56:43 +00:00
threadsafety.h
…
timedata.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
timedata.h
…
tinyformat.h
tinyformat: Add doc to Bitcoin Core specific strprintf
2019-06-13 09:30:40 -04:00
torcontrol.cpp
fix: tor: Call event_base_loopbreak from the event's callback
2019-07-17 15:32:38 +01:00
torcontrol.h
Remove unused includes
2019-10-15 22:56:43 +00:00
txdb.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
txdb.h
Remove unused includes
2019-10-15 22:56:43 +00:00
txmempool.cpp
feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic
2019-10-03 14:03:27 -04:00
txmempool.h
Remove unused includes
2019-10-15 22:56:43 +00:00
ui_interface.cpp
Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit
2019-06-18 15:59:53 -04:00
ui_interface.h
Remove unused includes
2019-10-15 22:56:43 +00:00
uint256.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
uint256.h
Remove unused includes
2019-10-15 22:56:43 +00:00
undo.h
…
validation.cpp
Merge #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache
2019-10-25 08:14:11 -04:00
validation.h
Merge #17004: validation: Remove REJECT code from CValidationState
2019-10-24 10:49:45 +02:00
validationinterface.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
validationinterface.h
Remove extra CBlockIndex declaration
2019-06-25 15:02:34 -04:00
version.h
…
versionbits.cpp
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbits.h
doc: Improve versionbits.h documentation
2019-08-15 11:02:55 -04:00
versionbitsinfo.cpp
[Consensus] Bury segwit deployment
2019-08-14 15:52:52 -04:00
versionbitsinfo.h
…
walletinitinterface.h
refactor: Cleanup walletinitinterface.h
2019-09-08 17:29:30 +03:00
warnings.cpp
scripted-diff: Make translation bilingual
2019-07-24 16:33:20 +03:00
warnings.h
Remove unused includes
2019-10-15 22:56:43 +00:00