highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 07:09:15 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
498b323425d960274c40472a6a847afc1982201d
bitcoin/src/test/fuzz
History
MarcoFalke a8fdfea77b Merge bitcoin/bitcoin#22791: init: Fix asmap/addrman initialization order bug 
724c497562 [fuzz] Add ConsumeAsmap() function (John Newbery)
5840476714 [addrman] Make m_asmap private (John Newbery)
f9002cb5db [net] Rename the copyStats arg from m_asmap to asmap (John Newbery)
f572f2b204 [addrman] Set m_asmap in CAddrMan initializer list (John Newbery)
593247872d [net] Remove CConnMan::SetAsmap() (John Newbery)
50fd77045e [init] Read/decode asmap before constructing addrman (John Newbery)

Pull request description:

  Commit 181a1207 introduced an initialization order bug: CAddrMan's m_asmap must be set before deserializing peers.dat.

  The first commit restores the correct initialization order. The remaining commits make `CAddrMan::m_asmap` usage safer:

  - don't reach into `CAddrMan`'s internal data from `CConnMan`
  - set `m_asmap` in the initializer list and make it const
  - make `m_asmap` private, and access it (as a reference to const) from a getter.

  This ensures that peers.dat deserialization must happen after setting m_asmap, since m_asmap is set during CAddrMan construction.

ACKs for top commit:
  mzumsande:
    Tested ACK 724c497562
  amitiuttarwar:
    code review but utACK 724c497562
  naumenkogs:
    utACK 724c497562
  vasild:
    ACK 724c497562
  MarcoFalke:
    review ACK 724c497562 👫

Tree-SHA512: 684a4cf9e3d4496c9997fb2bc4ec874809987055c157ec3fad1d2143b8223df52b5a0af787d028930b27388c8efeba0aeb2446cb35c337a5552ae76112ade726
2021-09-06 12:41:36 +02:00
..
addition_overflow.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
addrman.cpp
[fuzz] Add ConsumeAsmap() function
2021-08-27 11:01:45 +01:00
asmap_direct.cpp
test: add missing netaddress include headers
2021-03-16 19:52:37 +01:00
asmap.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
autofile.cpp
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
banman.cpp
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
base_encode_decode.cpp
fuzz: add missing ECCVerifyHandle to base_encode_decode
2021-06-18 23:13:07 +00:00
bech32.cpp
Implement Bech32m encoding/decoding
2021-03-15 17:26:35 -07:00
block_header.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
block.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
blockfilter.cpp
fuzz: Avoid timeout in blockfilter fuzz target
2021-08-20 15:45:15 +02:00
bloom_filter.cpp
scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext
2021-02-22 10:27:22 +01:00
buffered_file.cpp
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
chain.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
checkqueue.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
coins_view.cpp
Merge bitcoin/bitcoin#22232: refactor: Pass interpreter flags as uint32_t instead of signed int
2021-07-20 15:36:23 +02:00
connman.cpp
[addrman] Set m_asmap in CAddrMan initializer list
2021-08-27 10:55:41 +01:00
crypto_aes256.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
crypto_aes256cbc.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
crypto_chacha20_poly1305_aead.cpp
scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext
2021-02-22 10:27:22 +01:00
crypto_chacha20.cpp
scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext
2021-02-22 10:27:22 +01:00
crypto_common.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
crypto_hkdf_hmac_sha256_l32.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
crypto_poly1305.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
crypto.cpp
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
cuckoocache.cpp
build: Fix fuzz-cuckoocache cross-compiling for Windows with DEBUG=1
2021-03-03 12:23:41 +02:00
data_stream.cpp
[addrman] Set m_asmap in CAddrMan initializer list
2021-08-27 10:55:41 +01:00
decode_tx.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
descriptor_parse.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
deserialize.cpp
Merge bitcoin/bitcoin#22791: init: Fix asmap/addrman initialization order bug
2021-09-06 12:41:36 +02:00
eval_script.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
fee_rate.cpp
refactor: Make CFeeRate constructor architecture-independent
2021-05-18 07:13:25 +02:00
fees.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
flatfile.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
float.cpp
fuzz: Increase branch coverage of the float fuzz target
2021-06-07 13:41:14 +02:00
fuzz.cpp
fuzz: Terminate immediately if a fuzzing harness ever tries to perform a DNS lookup (belts and suspenders)
2021-05-21 19:41:43 +00:00
fuzz.h
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
FuzzedDataProvider.h
fuzz: Bump FuzzedDataProvider.h
2021-03-09 12:56:44 +01:00
golomb_rice.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
hex.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
http_request.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
i2p.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
integer.cpp
util: make ParseMoney return a std::optional<CAmount>
2021-08-04 19:48:24 +08:00
key_io.cpp
fuzz: Move CTxDestination fuzzing to script fuzz target
2021-07-04 21:30:50 +02:00
key.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
kitchen_sink.cpp
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
load_external_block_file.cpp
refactor: Remove chainparams arg from CChainState member functions
2021-06-13 09:43:54 +02:00
locale.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
merkleblock.cpp
scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext
2021-02-22 10:27:22 +01:00
message.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
muhash.cpp
scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext
2021-02-22 10:27:22 +01:00
multiplication_overflow.cpp
build: Fix undefined reference to __mulodi4
2021-07-27 14:53:24 +03:00
net_permissions.cpp
scripted-diff: rename NetPermissionFlags enumerators
2021-05-12 16:13:30 +02:00
net.cpp
Merge bitcoin/bitcoin#22791: init: Fix asmap/addrman initialization order bug
2021-09-06 12:41:36 +02:00
netaddress.cpp
fuzz: reduce possible networks check
2021-06-04 16:12:04 +02:00
netbase_dns_lookup.cpp
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-16 19:52:31 +01:00
node_eviction.cpp
p2p: remove unused m_is_onion member from NodeEvictionCandidate struct
2021-06-14 13:58:05 +02:00
p2p_transport_serialization.cpp
[fuzz] Occasional valid magic bytes for transport serialization test
2021-05-25 08:20:43 -07:00
parse_hd_keypath.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
parse_iso8601.cpp
fuzz: Limit ParseISO8601DateTime fuzzing to 32-bit
2021-05-09 10:04:01 +02:00
parse_numbers.cpp
util: make ParseMoney return a std::optional<CAmount>
2021-08-04 19:48:24 +08:00
parse_script.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
parse_univalue.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
policy_estimator_io.cpp
Move MakeNoLogFileContext to common libtest_util, and use it in bench
2021-03-03 09:17:37 +01:00
policy_estimator.cpp
Move MakeNoLogFileContext to common libtest_util, and use it in bench
2021-03-03 09:17:37 +01:00
pow.cpp
fuzz: [refactor] Use PickValue where possible
2021-03-24 06:57:55 +01:00
prevector.cpp
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
primitives_transaction.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
process_message.cpp
scripted-diff: Revert "fuzz: Add Temporary debug assert for oss-fuzz issue"
2021-07-19 19:12:54 +02:00
process_messages.cpp
net: Restrict period when cs_vNodes mutex is locked
2021-04-22 17:28:39 +03:00
protocol.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
psbt.cpp
fuzz: Extend psbt fuzz target a bit
2021-04-09 13:17:37 +02:00
random.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
rbf.cpp
Merge #20560: fuzz: Link all targets once
2020-12-15 19:00:36 +01:00
rolling_bloom_filter.cpp
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
rpc.cpp
fuzz: Avoid timeout in EncodeBase58
2021-05-11 21:24:49 +02:00
script_assets_test_minimizer.cpp
fuzz: Limit toxic test globals to their respective scope
2021-05-04 09:24:17 +02:00
script_bitcoin_consensus.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
script_descriptor_cache.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
script_flags.cpp
fuzz: Ensure prevout is consensus-valid
2021-04-25 10:36:00 +02:00
script_interpreter.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
script_ops.cpp
fuzz: Run const CScript member functions only once
2021-05-12 10:20:59 +02:00
script_sigcache.cpp
Merge #20560: fuzz: Link all targets once
2020-12-15 19:00:36 +01:00
script_sign.cpp
Change SignTransaction's input_errors to use bilingual_str
2021-07-01 12:57:53 -04:00
script.cpp
fuzz: Move CTxDestination fuzzing to script fuzz target
2021-07-04 21:30:50 +02:00
scriptnum_ops.cpp
scripted-diff: Rename MakeFuzzingContext to MakeNoLogFileContext
2021-02-22 10:27:22 +01:00
secp256k1_ec_seckey_import_export_der.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
secp256k1_ecdsa_signature_parse_der_lax.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
signature_checker.cpp
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
signet.cpp
Move MakeNoLogFileContext to common libtest_util, and use it in bench
2021-03-03 09:17:37 +01:00
socks5.cpp
test: add missing netaddress include headers
2021-03-16 19:52:37 +01:00
span.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
spanparsing.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
string.cpp
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
strprintf.cpp
fuzz: Remove strprintf test cases that are known to fail
2021-05-09 10:25:21 +02:00
system.cpp
fuzz: Avoid OOM in system fuzz target
2021-08-06 12:31:28 +02:00
timedata.cpp
fuzz: Limit max insertions in timedata fuzz test
2021-05-11 08:54:24 +02:00
torcontrol.cpp
fuzz: Add missing include (test/util/setup_common.h)
2021-03-04 08:39:27 +01:00
transaction.cpp
fuzz: Speed up transaction fuzz target
2021-05-20 17:26:24 +02:00
tx_in.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
tx_out.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
tx_pool.cpp
fuzz: Use LIMITED_WHILE instead of limit_max_ops
2021-08-21 19:25:33 +02:00
txrequest.cpp
fuzz: Link all targets once
2020-12-10 07:15:42 +01:00
util.cpp
Move implementations of non-template fuzz helpers
2021-07-14 18:45:53 +05:30
util.h
Move implementations of non-template fuzz helpers
2021-07-14 18:45:53 +05:30
utxo_snapshot.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
validation_load_mempool.cpp
fuzz: Initialize a TestingSetup for test_one_input
2021-06-10 15:04:39 -04:00
versionbits.cpp
versionbits: simplify state transitions
2021-04-12 11:14:49 +10:00