Ava Chow c1223188e0 Merge bitcoin/bitcoin#29672: validation: Make translations of fatal errors consistent ...

824f47294a node: Use log levels in noui_ThreadSafeMessageBox (TheCharlatan)
ddc7872c08 node: Make translations of fatal errors consistent (TheCharlatan)

Pull request description:

  The extra `bilingual_str` argument of the fatal error notifications and `node::AbortNode()` is often unused and when used usually contains the same string as the message argument. It also seems to be confusing, since it is not consistently used for errors requiring user action. For example some assumeutxo fatal errors require the user to do something, but are not translated.

  So simplify the fatal error and abort node interfaces by only passing a translated string. This slightly changes the fatal errors displayed to the user.

ACKs for top commit:
  stickies-v:
    re-ACK 824f47294a
  maflcko:
    ACK 824f47294a 🔎
  achow101:
    ACK 824f47294a
  hebasto:
    re-ACK 824f47294a.

Tree-SHA512: 2868ee7b045fe7f3ac582ce5039141b398480b7627734976201dafaaef7544b8461635a7292fee4a7f32ff1bfc26f9bd4d0c292dca424ba42fb7fc4483d7ce8d

2024-03-22 14:50:58 -04:00

..

base.cpp

Merge bitcoin/bitcoin#29672: validation: Make translations of fatal errors consistent

2024-03-22 14:50:58 -04:00

base.h

bench: basic block filter index initial sync

2024-03-12 09:30:42 -03:00

blockfilterindex.cpp

index: cache last block filter header

2024-03-12 11:55:04 -03:00

blockfilterindex.h

index: cache last block filter header

2024-03-12 11:55:04 -03:00

coinstatsindex.cpp

scripted-diff: Replace error() with LogError()

2024-03-11 13:49:37 +01:00

coinstatsindex.h

index: add [nodiscard] attribute to functions writing to the db

2023-09-08 10:04:14 -03:00

disktxpos.h

Replace READWRITEAS macro with AsBase wrapping function

2023-08-28 17:48:15 +02:00

txindex.cpp

scripted-diff: Replace error() with LogError()

2024-03-11 13:49:37 +01:00

txindex.h

…