mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-05-07 18:31:09 +02:00
4ac1efb147
92787dd52cd4ddc378cf1bcb7e92a649916a0f42 test: raise an error when target_vsize is below tx virtual size (ismaelsadeeq) a8780c937f730f4fa2ef2045458e3908bb2176e4 test: raise an error if output value is <= 0 in `create_self_transfer` (ismaelsadeeq) f6e88931f071f06cb8aefeac61cf3bce662eea74 test: test that `create_self_transfer_multi` respects `target_vsize` (ismaelsadeeq) Pull request description: This is a simple test PR that does two things: 1. Raise an exception in `_bulk_tx_` when `target_vsize` is too low, i.e., below the tx vsize. 2. Addresses some review comments from https://github.com/bitcoin/bitcoin/pull/30162, which are: - Raise an error if the output value is less than or equal to zero in `create_self_transfer`. This prevents creating transactions with a value of 0 or less. - Add a test to verify that `create_self_transfer_multi` also respects the passed `target_vsize`. ACKs for top commit: achow101: ACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 theStack: ACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 rkrux: reACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 glozow: ACK 92787dd52cd4ddc378cf1bcb7e92a649916a0f42 Tree-SHA512: 1f2767f2cf715ed65074c5fff347eec160b142685777d833d5e872cfef364d3dc1916b52ee442e99c7b9a8d514ff62bc67a9899d8854f65a4b93ac3ae300d18e