MarcoFalke 4c1090c882 Merge #17279: refactor: Remove redundant c_str() calls in formatting ...

c72906dcc1 refactor: Remove redundant c_str() calls in formatting (Wladimir J. van der Laan)

Pull request description:

  Our formatter, tinyformat, *never* needs `c_str()` for strings. Still, many places call it redundantly, resulting in longer code and a slight overhead.

  Remove redundant `c_str()` calls for:

  - `strprintf`
  - `LogPrintf`
  - `tfm::format`

  (also, combined with #17095, I think this improves logging in case of unexpected embedded NULL characters)

ACKs for top commit:
  ryanofsky:
    Code review ACK c72906dcc1. Easy to review with `git log -p -n1 --word-diff-regex=. -U0 c72906dcc11a73fa06a0adf97557fa756b551bee`

Tree-SHA512: 9e21e7bed8aaff59b8b8aa11571396ddc265fb29608c2545b1fcdbbb36d65b37eb361db6688dd36035eab0c110f8de255375cfda50df3d9d7708bc092f67fefc

2019-10-28 15:10:06 -04:00

..

bip32.cpp

Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}

2019-02-14 14:00:28 -05:00

bip32.h

Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}

2019-02-14 14:00:28 -05:00

bytevectorhash.cpp

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

bytevectorhash.h

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

check.h

util: Add CHECK_NONFATAL and use it in src/rpc

2019-10-18 17:19:36 -04:00

error.cpp

util: Make util/error bilingual_str (refactor)

2019-08-28 15:52:26 -04:00

error.h

util: Make util/error bilingual_str (refactor)

2019-08-28 15:52:26 -04:00

fees.cpp

[wallet] abort when attempting to fund a transaction above maxtxfee

2019-06-28 22:44:38 -04:00

fees.h

[build] Add several util units

2019-04-09 17:53:08 -04:00

macros.h

refactor: consolidate PASTE macros

2019-09-25 10:56:00 -04:00

memory.h

scripted-diff: Move util files to separate directory.

2018-11-04 22:46:07 -08:00

moneystr.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

moneystr.h

Remove unused includes

2019-10-15 22:56:43 +00:00

rbf.cpp

[build] Add several util units

2019-04-09 17:53:08 -04:00

rbf.h

[build] Add several util units

2019-04-09 17:53:08 -04:00

spanparsing.cpp

Abstract out some of the descriptor Span-parsing helpers

2019-09-18 12:12:13 -07:00

spanparsing.h

Add documenting comments to spanparsing.h

2019-09-18 12:25:55 -07:00

strencodings.cpp

util: refactor upper/lowercase functions

2019-08-08 11:35:14 +09:00

strencodings.h

util: refactor upper/lowercase functions

2019-08-08 11:35:14 +09:00

string.cpp

util: Add Join helper to join a list of strings

2019-08-20 16:51:41 -04:00

string.h

Remove unused includes

2019-10-15 22:56:43 +00:00

system.cpp

refactor: Remove redundant c_str() calls in formatting

2019-10-28 13:31:33 +01:00

system.h

Merge #15864: Fix datadir handling

2019-08-19 10:01:30 -04:00

threadnames.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

threadnames.h

Don't rename main thread at process level

2019-10-03 06:58:47 +02:00

time.cpp

Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp

2019-10-27 01:00:05 +03:00

time.h

Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp

2019-10-27 01:00:05 +03:00

translation.h

Remove unused includes

2019-10-15 22:56:43 +00:00

url.cpp

[build] Add several util units

2019-04-09 17:53:08 -04:00

url.h

[build] Add several util units

2019-04-09 17:53:08 -04:00

validation.cpp

[logging] Don't log REJECT code when transaction is rejected

2019-10-10 11:19:42 -04:00

validation.h

[build] Add several util units

2019-04-09 17:53:08 -04:00

vector.h

Add some general std::vector utility functions

2019-10-16 08:56:57 -07:00