Ava Chow 733317ba94 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors ...

3305972f7b refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors (Lőrinc)

Pull request description:

  A follow-up of https://github.com/bitcoin/bitcoin/pull/31305.

  The `clang-tidy` check can be run via:
  ```bash
  cmake -B build -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DBUILD_FOR_FUZZING=ON && cmake --build build -j$(nproc)

  run-clang-tidy -quiet -p build -j $(nproc) -checks='-*,performance-unnecessary-copy-initialization' | grep -v 'clang-tidy'
  ```

ACKs for top commit:
  maflcko:
    review ACK 3305972f7b 🏀
  achow101:
    ACK 3305972f7b
  theuni:
    ACK the much more constrained 3305972f7b.
  hebasto:
    ACK 3305972f7b, tested with clang 19.1.5 + clang-tidy.

Tree-SHA512: 64dc3b35f33b7ac064ebf9e56e9f0ceca5d26681a1379dcd2168987960020fe1a282ec4de8c353c82ddf0a534a4866b607fc691e690010c6cea78887045897fb

2024-11-26 17:00:01 -05:00

..

data

…

addrman.cpp

…

base58.cpp

…

bech32.cpp

…

bench_bitcoin.cpp

bench: add support for custom data directory

2024-11-11 11:31:04 -05:00

bench.cpp

bench: add support for custom data directory

2024-11-11 11:31:04 -05:00

bench.h

bench: add support for custom data directory

2024-11-11 11:31:04 -05:00

bip324_ecdh.cpp

…

block_assemble.cpp

…

ccoins_caching.cpp

…

chacha20.cpp

…

checkblock.cpp

…

checkblockindex.cpp

…

checkqueue.cpp

…

cluster_linearize.cpp

…

CMakeLists.txt

bench: Add basic CheckEphemeralSpends benchmark

2024-11-12 09:41:24 -05:00

coin_selection.cpp

…

crypto_hash.cpp

Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues

2024-11-03 12:36:49 +01:00

descriptors.cpp

…

disconnected_transactions.cpp

…

duplicate_inputs.cpp

…

ellswift.cpp

…

examples.cpp

…

gcs_filter.cpp

…

hashpadding.cpp

…

index_blockfilter.cpp

…

load_external.cpp

…

lockedpool.cpp

…

logging.cpp

…

mempool_ephemeral_spends.cpp

Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups

2024-11-25 13:47:44 -05:00

mempool_eviction.cpp

Apply mempool changeset transactions directly into the mempool

2024-11-13 13:26:56 -05:00

mempool_stress.cpp

Apply mempool changeset transactions directly into the mempool

2024-11-13 13:26:56 -05:00

merkle_root.cpp

…

nanobench.cpp

…

nanobench.h

…

parse_hex.cpp

…

peer_eviction.cpp

…

poly1305.cpp

…

pool.cpp

…

prevector.cpp

refactor: Preallocate PrevectorFillVector(In)Direct without vector resize

2024-11-25 20:09:44 +01:00

random.cpp

…

readblock.cpp

…

rollingbloom.cpp

…

rpc_blockchain.cpp

…

rpc_mempool.cpp

Apply mempool changeset transactions directly into the mempool

2024-11-13 13:26:56 -05:00

sign_transaction.cpp

refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors

2024-11-25 20:11:54 +01:00

streams_findbyte.cpp

…

strencodings.cpp

…

util_time.cpp

…

verify_script.cpp

…

wallet_balance.cpp

…

wallet_create_tx.cpp

…

wallet_create.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

wallet_ismine.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

wallet_loading.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

wallet_migration.cpp

bench: add coverage for wallet migration process

2024-10-21 08:29:22 -03:00

xor.cpp

…