mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 05:32:22 +02:00
773b1c9aa5
72db4accbfcoins: drop stale cursor null checks (Lőrinc)3d2f2d8de0coins: pass UTXO stats view by reference (Lőrinc)35aedb2823coins: drop cursor from base view (Lőrinc)c6fbe2f66ccoins: pass DB view to cursor users (Lőrinc) Pull request description: **Problem:** `CCoinsView::Cursor()` makes cursor iteration look like a generic coins view operation, but cursor iteration is only supported by the DB-backed coins view. The cache override only threw, and the `coins_view` fuzz target only asserted that deterministic unsupported throw path. **Fix:** Make cursor iteration a `CCoinsViewDB` operation. Cursor users now take the DB-backed view directly, `CCoinsView` no longer exposes `Cursor()`, and the fuzz target keeps DB-backed cursor coverage while dropping the unsupported cache throw probe. The UTXO stats path is also tightened to pass the non-null DB view by reference, and stale null handling for DB cursors is removed. This was extracted from review discussion in https://github.com/bitcoin/bitcoin/pull/35295#discussion_r3420576781 and extended based on https://github.com/bitcoin/bitcoin/pull/35562#issuecomment-4746585893. ACKs for top commit: achow101: ACK72db4accbfsedited: Re-ACK72db4accbfw0xlt: ACK72db4accbfandrewtoth: ACK72db4accbfTree-SHA512: 12a81330a6ec1b91a7e4393f3761ea9ed4702ecb24312f1defa5a9a079a396ce921fc52f74fe296e5ac7ab20d5b5a8a84e858c96847f333c58b7fa9de9e8143e
73 lines
2.5 KiB
C++
73 lines
2.5 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_TXDB_H
|
|
#define BITCOIN_TXDB_H
|
|
|
|
#include <coins.h>
|
|
#include <dbwrapper.h>
|
|
#include <kernel/caches.h>
|
|
#include <kernel/cs_main.h>
|
|
#include <sync.h>
|
|
#include <util/fs.h>
|
|
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
#include <future>
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
class COutPoint;
|
|
class uint256;
|
|
|
|
//! User-controlled performance and debug options.
|
|
struct CoinsViewOptions {
|
|
//! Maximum database write batch size in bytes.
|
|
uint64_t batch_write_bytes{DEFAULT_DB_CACHE_BATCH};
|
|
//! If non-zero, randomly exit when the database is flushed with (1/ratio) probability.
|
|
int simulate_crash_ratio{0};
|
|
};
|
|
|
|
/** CCoinsView backed by the coin database (chainstate/) */
|
|
class CCoinsViewDB final : public CCoinsView
|
|
{
|
|
protected:
|
|
DBParams m_db_params;
|
|
CoinsViewOptions m_options;
|
|
//! Prevents CompactFull() from using m_db while ResizeCache() replaces it.
|
|
Mutex m_db_mutex;
|
|
std::unique_ptr<CDBWrapper> m_db;
|
|
std::shared_future<void> m_compaction;
|
|
public:
|
|
explicit CCoinsViewDB(DBParams db_params, CoinsViewOptions options);
|
|
~CCoinsViewDB() override;
|
|
|
|
std::optional<Coin> GetCoin(const COutPoint& outpoint) const override;
|
|
std::optional<Coin> PeekCoin(const COutPoint& outpoint) const override;
|
|
bool HaveCoin(const COutPoint& outpoint) const override;
|
|
uint256 GetBestBlock() const override;
|
|
std::vector<uint256> GetHeadBlocks() const override;
|
|
void BatchWrite(CoinsViewCacheCursor& cursor, const uint256& block_hash) override;
|
|
//! Get a cursor to iterate over the whole state.
|
|
std::unique_ptr<CCoinsViewCursor> Cursor() const;
|
|
|
|
//! Whether an unsupported database format is used.
|
|
bool NeedsUpgrade();
|
|
size_t EstimateSize() const override;
|
|
|
|
//! Dynamically alter the underlying leveldb cache size.
|
|
void ResizeCache(size_t new_cache_size) EXCLUSIVE_LOCKS_REQUIRED(cs_main, !m_db_mutex);
|
|
|
|
//! Perform a full compaction of the underlying LevelDB on a one-shot background thread.
|
|
std::shared_future<void> CompactFullAsync() EXCLUSIVE_LOCKS_REQUIRED(cs_main, !m_db_mutex);
|
|
|
|
//! Return an underlying LevelDB property value, if available.
|
|
std::optional<std::string> GetDBProperty(const std::string& property);
|
|
};
|
|
|
|
#endif // BITCOIN_TXDB_H
|