mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-11 14:38:29 +01:00

Files

Ryan Ofsky c92fd63886 Merge bitcoin/bitcoin#27708 : Return EXIT_FAILURE on post-init fatal errors

61c569ab60 refactor: decouple early return commands from AppInit (furszy)
4927167f85 gui: return EXIT_FAILURE on post-init fatal errors (furszy)
3b2c61e819 Return EXIT_FAILURE on post-init fatal errors (furszy)
3c06926cf2 refactor: index: use `AbortNode` in fatal error helper (Sebastian Falbesoner)
9ddf7e03a3 move ThreadImport ABC error to use AbortNode (furszy)

Pull request description:

  It seems odd to return `EXIT_SUCCESS` when the node aborted execution due a fatal internal error
  or any post-init problem that triggers an unrequested shutdown.

  e.g. blocks or coins db I/O errors, disconnect block failure, failure during thread import (external
  blocks loading process error), among others.

ACKs for top commit:
  TheCharlatan:
    ACK 61c569ab60
  ryanofsky:
    Code review ACK 61c569ab60
  pinheadmz:
    ACK 61c569ab60
  theStack:
    Code-review ACK 61c569ab60

Tree-SHA512: 18a59c3acc1c6d12cbc74a20a401e89659740c6477fccb59070c9f97922dfe588468e9e5eef56c5f395762187c34179a5e3954aa5b844787fa13da2e666c63d3

2023-06-12 12:54:49 -04:00

chain.h

scripted-diff: move settings to common namespace

2023-05-30 17:26:51 +02:00

echo.h

…

handler.h

…

init.h

…

ipc.h

…

node.h

Merge bitcoin/bitcoin#27708 : Return EXIT_FAILURE on post-init fatal errors

2023-06-12 12:54:49 -04:00

README.md

…

wallet.h

wallet: Replace use of purpose strings with an enum

2023-04-11 15:55:31 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.