Ava Chow 4e4fa0199e Merge bitcoin/bitcoin#33680: validation: do not wipe utxo cache for stats/scans/snapshots ...

c6ca2b85a3 validation: do not wipe utxo cache for stats/scans/snapshots (Pieter Wuille)
7099e93d0a refactor: rename `FlushStateMode::ALWAYS` to `FORCE_FLUSH` (Lőrinc)

Pull request description:

  Revival of https://github.com/bitcoin/bitcoin/pull/30610#issuecomment-3432564955 with the remaining comments applied on top

  > Since #28280, the cost of a non-wiping sync of the UTXO cache is only proportional to the number of dirty entries, rather than proportional to the size of the entire cache. Because of that, there is no reason to perform a wiping flush in case the contents of the cache is still useful.
  >
  > Split the `FlushStateMode::ALWAYS` mode into a FORCE_SYNC (non-wiping) and a FORCE_FLUSH (wiping), and then use the former in `scantxoutset`, `gettxoutsetinfo`, snapshot creation.

  (slightly updated after #30214)

ACKs for top commit:
  optout21:
    reACK c6ca2b85a3
  cedwies:
    reACK c6ca2b8 (trivial)
  achow101:
    ACK c6ca2b85a3
  sedited:
    ACK c6ca2b85a3

Tree-SHA512: f3525a85dc512db4a0a9c749ad47c0d3fa44085a121aa54cd77646260a719c71f754ec6570ae77779c0ed68a24799116f79c686e7a17ce57a26f6a598f7bf926

2026-01-29 14:43:27 -08:00

..

util

fuzz: Exclude too expensive inputs in descriptor_parse targets

2026-01-22 21:01:55 +01:00

addition_overflow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

addrman.cpp

fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration()

2026-01-23 15:59:07 +01:00

asmap_direct.cpp

…

asmap.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

autofile.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

banman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

base_encode_decode.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bech32.cpp

…

bip324.cpp

…

bitdeque.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bitset.cpp

…

block_header.cpp

Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications

2026-01-14 11:38:07 -08:00

block_index_tree.cpp

validation: invert m_cached_finished_ibd to m_cached_is_ibd

2026-01-12 16:54:11 +01:00

block_index.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

block.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

blockfilter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

bloom_filter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

buffered_file.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

chain.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

checkqueue.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cluster_linearize.cpp

clusterlin: minimize chunks (feature)

2026-01-12 17:38:30 -05:00

CMakeLists.txt

fuzz: Add fuzzer for block index

2025-12-16 11:25:46 -05:00

coins_view.cpp

refactor: Let CCoinsViewCache::BatchWrite return void

2025-12-14 22:25:31 +01:00

coinscache_sim.cpp

fuzz: keep coinscache_sim backend free of spent coins

2026-01-06 12:16:46 +01:00

connman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_aes256.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_aes256cbc.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_diff_fuzz_chacha20.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_hkdf_hmac_sha256_l32.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto_poly1305.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

crypto.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

cuckoocache.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

decode_tx.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

descriptor_parse.cpp

fuzz: Exclude too expensive inputs in descriptor_parse targets

2026-01-22 21:01:55 +01:00

deserialize.cpp

move-only: Move CBlockFileInfo to kernel namespace

2025-10-28 16:08:44 +01:00

difference_formatter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

eval_script.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

fee_rate.cpp

…

feefrac.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

feeratediagram.cpp

…

fees.cpp

fees: refactor: rename fees to block_policy_estimator

2025-10-27 10:41:02 +01:00

flatfile.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

float.cpp

…

fuzz.cpp

fuzz: doc: remove any mention to address_deserialize_v2

2025-12-17 11:57:11 -03:00

fuzz.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

FuzzedDataProvider.h

…

golomb_rice.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

headerssync.cpp

fuzz: Use min option in ConsumeTime

2026-01-16 11:00:58 +01:00

hex.cpp

refactor: Move transaction_identifier.h to primitives

2025-08-11 16:47:51 +01:00

http_request.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

i2p.cpp

net: Fix -Wmissing-braces

2025-12-17 16:54:35 +00:00

integer.cpp

Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count

2026-01-20 15:47:17 -08:00

key_io.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

key.cpp

…

kitchen_sink.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

load_external_block_file.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

locale.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

merkle.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

merkleblock.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

message.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

mini_miner.cpp

scripted-diff: rename AddToMempool -> TryAddToMempool

2025-11-30 10:57:48 -05:00

miniscript.cpp

Merge bitcoin/bitcoin#32471: wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key

2026-01-20 12:17:19 -08:00

minisketch.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

muhash.cpp

refactor: Revert "disable self-assign warning for tests"

2025-10-09 20:47:25 +02:00

multiplication_overflow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net_permissions.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

net.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netaddress.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

netbase_dns_lookup.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

node_eviction.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

overflow.cpp

…

p2p_handshake.cpp

fuzz: Avoid non-determinism in process_message(s) target (PeerMan)

2025-07-18 14:02:55 +02:00

p2p_headers_presync.cpp

fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration()

2026-01-23 15:59:07 +01:00

p2p_transport_serialization.cpp

…

package_eval.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

parse_hd_keypath.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

parse_iso8601.cpp

…

parse_numbers.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

parse_script.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

parse_univalue.cpp

…

partially_downloaded_block.cpp

refactor: unify container presence checks - trivial counts

2025-12-03 13:36:58 +01:00

pcp.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

policy_estimator_io.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

policy_estimator.cpp

Merge bitcoin/bitcoin#33629: Cluster mempool

2025-11-25 10:35:11 +00:00

poolresource.cpp

…

pow.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

prevector.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

primitives_transaction.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

process_message.cpp

fuzz: Restore SendMessages coverage in process_message(s) fuzz targets

2026-01-15 15:17:12 +01:00

process_messages.cpp

fuzz: Restore SendMessages coverage in process_message(s) fuzz targets

2026-01-15 15:17:12 +01:00

protocol.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

psbt.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

random.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

rbf.cpp

Merge bitcoin/bitcoin#33985: fuzz: gate mempool entry based on weight

2025-12-02 15:07:01 +00:00

rolling_bloom_filter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

rpc.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_assets_test_minimizer.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_descriptor_cache.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_flags.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_format.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_interpreter.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_ops.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_parsing.cpp

…

script_sigcache.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script_sign.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

script.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

scriptnum_ops.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

secp256k1_ec_seckey_import_export_der.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

secp256k1_ecdsa_signature_parse_der_lax.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

signature_checker.cpp

script/verify_flags: make script_verify_flags type safe

2025-08-14 10:17:32 +10:00

signet.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

socks5.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

span.cpp

…

string.cpp

fuzz: Add a test case for ParseByteUnits()

2025-12-05 15:23:54 +00:00

strprintf.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

system.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

timeoffsets.cpp

…

torcontrol.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

transaction.cpp

refactor: rename CTransaction::GetTotalSize to signal that it's not cached

2026-01-19 20:20:13 +01:00

tx_in.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

tx_out.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

tx_pool.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

txdownloadman.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

txgraph.cpp

doc: fix double-word typos in comments

2025-12-30 12:12:26 -08:00

txorphan.cpp

refactor: unify container presence checks - trivial counts

2025-12-03 13:36:58 +01:00

txrequest.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

util.cpp

fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration()

2026-01-23 15:59:07 +01:00

util.h

Merge bitcoin/bitcoin#34337: fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration()

2026-01-26 11:36:24 +00:00

utxo_snapshot.cpp

Merge bitcoin/bitcoin#33680: validation: do not wipe utxo cache for stats/scans/snapshots

2026-01-29 14:43:27 -08:00

utxo_total_supply.cpp

validation: do not wipe utxo cache for stats/scans/snapshots

2026-01-03 12:43:57 +01:00

validation_load_mempool.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

vecdeque.cpp

…

versionbits.cpp

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00