highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
526f67a5cabf8e8a8b276bcc1166f2d3f730701d
bitcoin/src
History
Hennadii Stepanov 526f67a5ca Merge bitcoin-core/gui#704: Correctly limit overview transaction list 
08209c039f Correctly limit overview transaction list (John Moffett)

Pull request description:

  Fixes #703

  The way the main overview page limits the number of transactions displayed (currently 5) is not an appropriate use of Qt. Our subclassed transaction sort/filter proxy model returns a maximum of `5` in `rowCount()`. However, the model itself actually may hold significantly more. While this has _worked_, it breaks the contract of `rowCount()`.

  If `bitcoin-qt` is run with a DEBUG build of Qt, it'll result in an assert-crash in certain relatively common situations (see #703 for details). Instead of artificially limiting the `rowCount()` in the subclassed filter, we can hide/unhide the rows in the displaying `QListView` upon any changes in the sorted proxy filter.

  I loaded a wallet with 20,000 transactions and did not notice any performance differences between master and this branch.

  For reference, this is the list I'm referring to:

  <img width="934" alt="image" src="https://user-images.githubusercontent.com/116917595/214947304-3f289380-3510-487b-80e8-d19428cf2f0f.png">

ACKs for top commit:
  Sjors:
    tACK 08209c039f
  hebasto:
    ACK 08209c039f, tested on Ubuntu 22.04.

Tree-SHA512: c2a7b1a2a6e6ff30694830d7c722274c4c47494a81ce9ef25f8e5587c24871b02343969f4437507693d4fd40ba7a212702b159cf54b3357d8d76c02bc8245113
2023-02-02 11:45:26 +00:00
..
bench
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
common
Use DataStream where possible
2023-01-26 10:44:05 +01:00
compat
compat: use STDIN_FILENO over 0
2023-01-04 12:00:25 +00:00
config
…
consensus
Merge bitcoin/bitcoin#26603: doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed
2023-01-04 18:07:31 +00:00
crc32c
Update crc32c subtree to latest upstream master
2022-08-13 13:55:38 +01:00
crypto
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
index
refactor: use Hash helper for double-SHA256 calculations
2023-01-31 19:34:35 +01:00
init
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
interfaces
Merge bitcoin/bitcoin#26752: wallet: Remove mempool_sequence from interface methods
2023-01-04 17:53:58 +00:00
ipc
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
kernel
doc: Fix comment syntax error
2023-01-30 10:26:02 +00:00
leveldb
Update leveldb-subtree subtree to latest upstream
2022-09-29 16:43:30 +01:00
logging
Use steady clock for logging timer
2023-01-31 18:48:50 +01:00
minisketch
Update minisketch subtree to latest upstream
2022-10-23 15:03:04 +01:00
node
Merge bitcoin/bitcoin#26965: refactor: Remove stray cs_main redundant declaration
2023-01-30 17:27:44 +00:00
policy
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
primitives
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
qt
Merge bitcoin-core/gui#704: Correctly limit overview transaction list
2023-02-02 11:45:26 +00:00
rpc
Merge bitcoin/bitcoin#26974: refactor: rpc: set TxToJSON default verbosity to SHOW_DETAILS
2023-01-31 18:22:19 +01:00
script
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
secp256k1
Update secp256k1 subtree to upstream libsecp256k1 version 0.2.0
2022-12-12 23:40:36 -05:00
support
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
test
Merge bitcoin/bitcoin#26992: refactor: Remove unused CDataStream SerializeMany constructor
2023-02-02 10:47:37 +00:00
univalue
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
util
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
wallet
Merge bitcoin/bitcoin#26910: wallet: migrate wallet, exit early if no legacy data exist
2023-02-01 17:14:13 -05:00
zmq
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
.bear-tidy-config
…
.clang-format
…
.clang-tidy
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
addrdb.cpp
Merge bitcoin/bitcoin#26847: p2p: track AddrMan totals by network and table, improve precision of adding fixed seeds
2023-01-31 16:08:44 -05:00
addrdb.h
…
addrman_impl.h
addrman, refactor: combine two size functions
2023-01-26 18:11:13 -05:00
addrman.cpp
Merge bitcoin/bitcoin#26847: p2p: track AddrMan totals by network and table, improve precision of adding fixed seeds
2023-01-31 16:08:44 -05:00
addrman.h
addrman: Use std::nullopt instead of {}
2023-02-01 10:18:08 -05:00
arith_uint256.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
arith_uint256.h
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
attributes.h
…
banman.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
banman.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
base58.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
base58.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
bech32.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
bech32.h
…
bitcoin-chainstate.cpp
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#26328: doc: fix -netinfo relaytxes help
2023-01-11 16:39:11 +00:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0
2023-01-13 09:40:57 +00:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
Use DataStream where possible
2023-01-26 10:44:05 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0
2023-01-13 09:40:57 +00:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
blockencodings.cpp
Use DataStream where possible
2023-01-26 10:44:05 +01:00
blockencodings.h
[block encodings] Make CheckBlock mockable for PartiallyDownloadedBlock
2023-01-23 17:18:35 +01:00
blockfilter.cpp
refactor: use Hash helper for double-SHA256 calculations
2023-01-31 19:34:35 +01:00
blockfilter.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
chain.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
chain.h
refactor: add kernel/cs_main.*
2023-01-05 09:05:14 +00:00
chainparams.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
Merge bitcoin/bitcoin#25853: net: update testnet torv3 hardcoded seeds for 24.x
2022-09-09 10:07:39 +02:00
checkqueue.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
clientversion.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
clientversion.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins.cpp
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
coins.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
compressor.cpp
…
compressor.h
…
core_io.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
core_memusage.h
…
core_read.cpp
Use DataStream where possible
2023-01-26 10:44:05 +01:00
core_write.cpp
refactor: rpc: set TxToJSON default verbosity to SHOW_DETAILS
2023-01-26 11:51:33 +00:00
cuckoocache.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
dbwrapper.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
dbwrapper.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
deploymentstatus.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
dummywallet.cpp
…
external_signer.cpp
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
external_signer.h
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
flatfile.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
flatfile.h
…
fs.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
fs.h
clang-tidy: Fix performance-move-const-arg in headers
2023-01-18 15:47:06 +00:00
hash.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
hash.h
Merge bitcoin/bitcoin#26649: refactor: Use AutoFile and HashVerifier (without ser-type and ser-version) where possible
2023-01-30 15:57:12 +00:00
headerssync.cpp
Move headerssync logging to BCLog::NET
2022-08-30 12:09:04 -04:00
headerssync.h
Track headers presync progress and log it
2022-08-29 08:10:35 -04:00
httprpc.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
httprpc.h
…
httpserver.cpp
refactor: Make ThreadHTTP return void
2023-01-05 17:54:08 +00:00
httpserver.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
i2p.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
i2p.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#26900: refactor: Add BlockManager getters
2023-01-27 17:33:11 +01:00
init.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
key_io.cpp
…
key_io.h
…
key.cpp
refactor: use Hash helper for double-SHA256 calculations
2023-01-31 19:34:35 +01:00
key.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
logging.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
logging.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
Makefile.am
Merge bitcoin/bitcoin#23670: build: Build minisketch test in make check, not in make
2023-01-31 17:55:44 +00:00
Makefile.bench.include
Merge bitcoin/bitcoin#16981: Improve runtime performance of --reindex
2022-11-15 19:23:39 -05:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
build: Build minisketch test in make check, not in make
2022-07-21 10:42:09 +01:00
Makefile.qt_locale.include
…
Makefile.qt.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.qttest.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.test_fuzz.include
[fuzz] Move ConsumeNetAddr to fuzz/util/net.h
2022-11-17 14:52:45 +00:00
Makefile.test_util.include
test, build: Separate read_json function into its own module
2023-01-27 09:26:29 +00:00
Makefile.test.include
[fuzz] Add PartiallyDownloadedBlock target
2023-01-23 17:29:41 +01:00
Makefile.univalue.include
…
mapport.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
mapport.h
Remove configure-time setting of DEFAULT_UPNP
2023-01-28 15:24:13 +00:00
memusage.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
net_processing.cpp
net_processing: simplify logging statement
2023-01-29 17:35:15 -05:00
net_processing.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
net_types.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#26888: net: simplify the call to vProcessMsg.splice()
2023-02-01 09:42:46 +01:00
net.h
net: Load fixed seeds from reachable networks for which we don't have addresses
2023-01-26 18:11:13 -05:00
netaddress.cpp
doc: net: fix link to onion address encoding scheme [ONIONADDRESS]
2023-01-10 14:23:27 +01:00
netaddress.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
netbase.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
netbase.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
netgroup.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
netgroup.h
…
netmessagemaker.h
…
noui.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
noui.h
…
outputtype.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
outputtype.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
pow.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
pow.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
prevector.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
protocol.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
protocol.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
psbt.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
psbt.h
Merge bitcoin/bitcoin#25877: refactor: Do not use CScript for tapleaf scripts until the tapleaf version is known
2023-01-19 17:51:21 -05:00
pubkey.cpp
Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0
2023-01-13 09:40:57 +00:00
pubkey.h
Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0
2023-01-13 09:40:57 +00:00
random.cpp
doc: remove usages of C++11
2023-01-12 13:42:44 +00:00
random.h
doc: remove usages of C++11
2023-01-12 13:42:44 +00:00
randomenv.cpp
Merge bitcoin/bitcoin#26826: refactor: remove windows-only compat.h usage in randomenv
2023-01-23 16:36:27 +01:00
randomenv.h
…
rest.cpp
Use DataStream where possible
2023-01-26 10:44:05 +01:00
rest.h
…
reverse_iterator.h
doc: remove usages of C++11
2023-01-12 13:42:44 +00:00
scheduler.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
scheduler.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
serialize.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
shutdown.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
streams.h
Merge bitcoin/bitcoin#26992: refactor: Remove unused CDataStream SerializeMany constructor
2023-02-02 10:47:37 +00:00
sync.cpp
…
sync.h
doc: Export threadsafety.h from sync.h
2023-01-25 09:33:26 +01:00
threadsafety.h
…
timedata.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
timedata.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
tinyformat.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
torcontrol.cpp
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
torcontrol.h
clang-tidy: Fix modernize-use-default-member-init in headers
2023-01-31 11:50:10 +00:00
txdb.cpp
coins: add Sync() method to allow flush without cacheCoins drop
2023-01-20 10:36:48 -05:00
txdb.h
coins: add Sync() method to allow flush without cacheCoins drop
2023-01-20 10:36:48 -05:00
txmempool.cpp
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
txmempool.h
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
txorphanage.cpp
Merge bitcoin/bitcoin#26551: p2p: Track orphans by who provided them
2023-01-26 10:36:18 +00:00
txorphanage.h
Merge bitcoin/bitcoin#26551: p2p: Track orphans by who provided them
2023-01-26 10:36:18 +00:00
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
undo.h
…
validation.cpp
Add BlockManager::IsPruneMode()
2023-01-16 17:31:32 +01:00
validation.h
Merge bitcoin/bitcoin#26251: refactor: add kernel/cs_main.h
2023-01-16 13:44:56 +01:00
validationinterface.cpp
Fix clang-tidy readability-const-return-type violations
2023-02-01 11:33:35 +01:00
validationinterface.h
refactor: add kernel/cs_main.*
2023-01-05 09:05:14 +00:00
version.h
…
versionbits.cpp
refactor: use braced init for integer constants instead of c style casts
2023-01-03 19:31:29 -06:00
versionbits.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
walletinitinterface.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
warnings.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
warnings.h
…